-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update kubectl generator for 1.24 #275
Conversation
@@ -252,6 +252,7 @@ func WriteCommandFile(manifest *Manifest, t *template.Template, params TopLevelC | |||
">", ">", | |||
"[", "<span>[</span>", | |||
"]", "<span>]</span>", | |||
"\n", "<br>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generator choked on usage strings that included newlines without this
/sig cli |
/approve |
/approve I'm not much cop with Golang so won't LGTM. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, sftim, tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
xref kubernetes/website#33676 and kubernetes/website#33674