Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve generation of config APIs #321

Merged
merged 1 commit into from
May 23, 2023
Merged

Improve generation of config APIs #321

merged 1 commit into from
May 23, 2023

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented May 18, 2023

Update the kube-controller-manager config API by fixing its API group. Added two more metrics APIs.

@tengqm
Improve generation of config APIs
972821c 
Update the kube-controller-manager config API by fixing its API group.
Added two more metrics APIs.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 18, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 18, 2023
sftim
sftim reviewed May 18, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to split changes into:

  • generator change
  • the outcome of that generator (second commit)

this makes reverts and merges a bit easier if we need them.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim, tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tengqm tengqm merged commit 1ac13c9 into kubernetes-sigs:master May 23, 2023
@tengqm tengqm deleted the improve-configapi branch May 23, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@jimangel jimangel Awaiting requested review from jimangel

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tengqm @k8s-ci-robot @sftim