[genref] Strip prefix in map types.

[trasc]

This PR applies the StripPrefix logic for map types (keys and values).

[tengqm]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm, trasc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tengqm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[alculquicondor]

@tengqm did you miss the LGTM or are you waiting for someone else to take a look?

[sftim]

This needs an LGTM review in order to merge. @alculquicondor if you can point this PR out to people who review Go code, it'll help.

[sftim]

(I don't know your intent here @tengqm )

[tengqm]

I was trying to let someone else chime in with a lgtm, although I think this is a good improvement to the current code.
If the PR receives no reviews from other reviewers, and I still remember here is a PR to be merged, I'll give it a lgtm.

[trasc]

@tengqm @sftim Not necessary related to this PR, but , is there a plan to have releases in this project, or adding go module version tags?

[tengqm]

@tengqm @sftim Not necessary related to this PR, but , is there a plan to have releases in this project, or adding go module version tags?

No plan yet. Open to all kinds of suggestions.

[trasc]

@tengqm @sftim Not necessary related to this PR, but , is there a plan to have releases in this project, or adding go module version tags?

No plan yet. Open to all kinds of suggestions.

We are thinking of using genref in kueue (https://kueue.sigs.k8s.io/docs/) and being able to reference by a version instead of a commit hash will help.

Currently we are doing something like:

https://github.com/kubernetes-sigs/kueue/blob/099ed21f62fe46f2ee451f7ffa40bcea03def9ff/Makefile#L317-L321

[tengqm]

@tengqm @sftim Not necessary related to this PR, but , is there a plan to have releases in this project, or adding go module version tags?

No plan yet. Open to all kinds of suggestions.

We are thinking of using genref in kueue (https://kueue.sigs.k8s.io/docs/) and being able to reference by a version instead of a commit hash will help.

Currently we are doing something like:

https://github.com/kubernetes-sigs/kueue/blob/099ed21f62fe46f2ee451f7ffa40bcea03def9ff/Makefile#L317-L321

Okay. If a version tag is needed, we can actually do it starting now.
How about we tag the current master head as 'v0.28.0' or something like that?

[trasc]

@tengqm @sftim Not necessary related to this PR, but , is there a plan to have releases in this project, or adding go module version tags?

No plan yet. Open to all kinds of suggestions.

We are thinking of using genref in kueue (https://kueue.sigs.k8s.io/docs/) and being able to reference by a version instead of a commit hash will help.
Currently we are doing something like:
https://github.com/kubernetes-sigs/kueue/blob/099ed21f62fe46f2ee451f7ffa40bcea03def9ff/Makefile#L317-L321

Okay. If a version tag is needed, we can actually do it starting now. How about we tag the current master head as 'v0.28.0' or something like that?

It should be fine, but in order to reference genref we might also need the genref/v0.28.0 tag, and it will be even better if this PR is also merged.

[tengqm]

/lgtm

[tengqm]

PR kicked in and tag 'v0.28.0' for the project has been added.

[trasc]

PR kicked in and tag 'v0.28.0' for the project has been added.

Thanks @tengqm.
Can you also push a tag called genref/v0.28.0?
We need that to be able to do thinks like go install github.com/kubernetes-sigs/reference-docs/genref@0.28.0 since genref it's a go module (has it's own go.mod/ go.sum).

[tengqm]

PR kicked in and tag 'v0.28.0' for the project has been added.

Thanks @tengqm. Can you also push a tag called genref/v0.28.0? We need that to be able to do thinks like go install github.com/kubernetes-sigs/reference-docs/genref@0.28.0 since genref it's a go module (has it's own go.mod/ go.sum).

done

[trasc]

PR kicked in and tag 'v0.28.0' for the project has been added.

Thanks @tengqm. Can you also push a tag called genref/v0.28.0? We need that to be able to do thinks like go install github.com/kubernetes-sigs/reference-docs/genref@0.28.0 since genref it's a go module (has it's own go.mod/ go.sum).

done

Hi @tengqm, it looks to be a small issue , the tag should be genref/v0.28.0. (not generef/v0.28.0)

[tengqm]

should be okay now.