Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add NewWithTokenWithClient #326

Merged
merged 2 commits into from
Mar 26, 2024
Merged

add NewWithTokenWithClient #326

merged 2 commits into from
Mar 26, 2024

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Mar 26, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • add NewWithTokenWithClient
    in some cases we want to pass a custom http client

/assign @xmudrii @saschagrunert @ameukam

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add NewWithTokenWithClient

@cpanato
add NewWithTokenWithClient
888cc42 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Mar 26, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 26, 2024
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 26, 2024
@saschagrunert
Copy link
Member

Ah CI is not happy:

github/github.go:204:11: string `unauthenticated` has 3 occurrences, make it a constant (goconst)
	state := "unauthenticated"

saschagrunert
saschagrunert reviewed Mar 26, 2024
View reviewed changes
github/github.go Outdated Show resolved Hide resolved
@cpanato
update string
d6594be 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit cb59713 into kubernetes-sigs:main Mar 26, 2024
5 checks passed
@cpanato cpanato deleted the add-custom branch March 26, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@jrsapi jrsapi Awaiting requested review from jrsapi

Assignees

@saschagrunert saschagrunert

@ameukam ameukam

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cpanato @saschagrunert @k8s-ci-robot @ameukam @xmudrii