-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Readme for helm #383
Conversation
Welcome @chetak123! |
Hi @chetak123. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @helayoty |
| `controller.replicaCount` | Controller replicaCount | `1` | | ||
| `plugins.enabled` | Plugins enabled | `["Coscheduling","CapacityScheduling","NodeResourceTopologyMatch", "NodeResourcesAllocatable"]` | | ||
| `global.queueSort` | global queueSort, needs to be globally enabled once | `["Coscheduling"]` | | ||
| `global.extensions.preFilter` | global extensions preFilter | `["Coscheduling", "CapacityScheduling"]` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description should be something like:
`preFilter` extension config. This is be used if the `preFilter` plugin is enabled.
Please apply the same for the rest of all extensions. parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution. Added some comments.
@@ -1 +1,45 @@ | |||
# Chart to run scheduler plugin as a second scheduler in cluster. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update the title to have the chart name only scheduler-plugins as a second scheduler in cluster
| --------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------- | | ||
| `scheduler.name` | Scheduler name | `scheduler-plugins-scheduler` | | ||
| `scheduler.image` | Scheduler image | `k8s.gcr.io/scheduler-plugins/kube-scheduler:v0.22.6` | | ||
| `scheduler.namespace` | Scheduler namespace | `scheduler-plugins` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `scheduler.namespace` | Scheduler namespace | `scheduler-plugins` | | |
| `scheduler.namespace` | Default scheduler-plugins namespace | `scheduler-plugins` | |
| `scheduler.name` | Scheduler name | `scheduler-plugins-scheduler` | | ||
| `scheduler.image` | Scheduler image | `k8s.gcr.io/scheduler-plugins/kube-scheduler:v0.22.6` | | ||
| `scheduler.namespace` | Scheduler namespace | `scheduler-plugins` | | ||
| `scheduler.replicaCount` | Scheduler replicaCount | `1` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `scheduler.replicaCount` | Scheduler replicaCount | `1` | | |
| `scheduler.replicaCount` | scheduler-plugins replicas | `1` | |
| `controller.image` | Controller image | `k8s.gcr.io/scheduler-plugins/controller:v0.22.6` | | ||
| `controller.namespace` | Controller namespace | `scheduler-plugins` | | ||
| `controller.replicaCount` | Controller replicaCount | `1` | | ||
| `plugins.enabled` | Plugins enabled | `["Coscheduling","CapacityScheduling","NodeResourceTopologyMatch", "NodeResourcesAllocatable"]` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| `plugins.enabled` | Plugins enabled | `["Coscheduling","CapacityScheduling","NodeResourceTopologyMatch", "NodeResourcesAllocatable"]` | | |
| `plugins.enabled` | All Plugins are enabled by default. Plugins enabled | `["Coscheduling","CapacityScheduling","NodeResourceTopologyMatch", "NodeResourcesAllocatable"]` | |
| `controller.namespace` | Controller namespace | `scheduler-plugins` | | ||
| `controller.replicaCount` | Controller replicaCount | `1` | | ||
| `plugins.enabled` | Plugins enabled | `["Coscheduling","CapacityScheduling","NodeResourceTopologyMatch", "NodeResourcesAllocatable"]` | | ||
| `global.queueSort` | global queueSort, needs to be globally enabled once | `["Coscheduling"]` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove global
from all parameters' descriptions.
| `global.queueSort` | global queueSort, needs to be globally enabled once | `["Coscheduling"]` | | |
| `global.queueSort` | THe default `queueSort` Plugin, needs to be enabled once | `["Coscheduling"]` | |
/ok-to-test |
Hey @helayoty I have made the required changes. (and I'm very sorry for the delay - due to exams) |
@chetak123 I added one more suggestion to the README. I believe we just need to change one thing. Currently the Can you remove the |
@chetak123 this looks good to me now. /lgtm @helayoty do you want to review one more time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢 @Huang-Wei
/assign @Huang-Wei |
/release-note-none |
/lgtm Thanks @chetak123 ! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chetak123, helayoty, Huang-Wei The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it: Readme for Helm chart along with it's parameters
Which issue(s) this PR fixes:
Fixes #353
Special notes for your reviewer:
I have completed task 1 as specified in issue but not able to fully understand task 2 -
Update the
docspecifying the steps to use helm chart -if any other place other than the above-
It would be really helpful if you can please specify what needs to be done,
Thanks.