Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix codeql workflow permissions #739

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

pjbgf
Copy link
Member

@pjbgf pjbgf commented Dec 1, 2021

What type of PR is this?

/kind cleanup
/kind regression

What this PR does / why we need it:

The changes on #737 made the analyze workflow to stop working at the branch main:

image

Further analysis showed that the issue was the codeql-action trying to PUT an analysis status:

image

This PR adds security-events: write for those workflows only, which is aligned with the recomendations from the component's documentation.

Which issue(s) this PR fixes:

None

Does this PR have test?

N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Signed-off-by: Paulo Gomes <pjbgf@linux.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/regression Categorizes issue or PR as related to a regression from a prior release. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 1, 2021
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #739 (9258f07) into main (c2c7fcf) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #739   +/-   ##
=======================================
  Coverage   53.94%   53.94%           
=======================================
  Files          41       41           
  Lines        4121     4121           
=======================================
  Hits         2223     2223           
  Misses       1831     1831           
  Partials       67       67           

@pjbgf
Copy link
Member Author

pjbgf commented Dec 1, 2021

Another occurrency of flakeness on fedora-e2e:
--- FAIL: TestSuite/TestSecurityProfilesOperator/cluster-wide:_Seccomp:_Verify_profile_recording_bpf (248.72s)

@pjbgf
Copy link
Member Author

pjbgf commented Dec 2, 2021

fedora-e2e flakeness:
--- FAIL: TestSuite/TestSecurityProfilesOperator/cluster-wide:_Seccomp:_Verify_profile_recording_bpf (234.79s)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pjbgf, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [pjbgf,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3337c47 into kubernetes-sigs:main Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/regression Categorizes issue or PR as related to a regression from a prior release. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants