Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Service Catalog cleaner should not fail when controller-manager is not deployed #2815

Closed
mszostok opened this issue May 25, 2020 · 2 comments · Fixed by #2817
Closed

Service Catalog cleaner should not fail when controller-manager is not deployed #2815

mszostok opened this issue May 25, 2020 · 2 comments · Fixed by #2817
Labels
kind/bug Categorizes issue or PR as related to a bug.
Milestone

Comments

@mszostok
Copy link
Contributor

mszostok commented May 25, 2020

Bug Report

What happened:
The service catalog cleaner job fails when controller-manager deployment cannot be found. This job is executed as a pre-delete hook.

The problem is that when the svc-cat helm release fails and controller-manager is not installed then release cannot be removed because the cleaner job is executed and fails with not found error.

What you expected to happen:

cleaner job should only ensure that the CRDs and all svcat CRs are removed. With ensure I mean that if they do not exist then it should not fail.

@mszostok mszostok added the kind/bug Categorizes issue or PR as related to a bug. label May 25, 2020
@mszostok mszostok changed the title Service Catalog cleaner cannot fail when controller-manager is not deployed Service Catalog cleaner should not fail when controller-manager is not deployed May 25, 2020
@mszostok mszostok added this to the 0.3.1 milestone May 25, 2020
@mszostok
Copy link
Contributor Author

/assign @gmrodgers

@k8s-ci-robot
Copy link
Contributor

@mszostok: GitHub didn't allow me to assign the following users: gmrodgers.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @gmrodgers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants