This repository has been archived by the owner on May 6, 2022. It is now read-only.
Adding list of resource types #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 19, 2016 14:40
The types herein will be used in future documents that make progress toward completing kubernetes-retired#14. This patch partially replaces kubernetes-retired#13 cc/ @pmorie @bgrant0607 @duglin @judkowitz @slack @MHBauer
krancour
reviewed
Oct 20, 2016
| upon successful execution. | ||
|
|
||
| Successfully executed claims will also serve as a record of an application that's | ||
| bound to a backing service. |
There was a problem hiding this comment.
@arschles did we eliminate dynamic provisioning of a dedicated ServiceInstance by referencing a ServiceClass within a claim? I ask because it seems conspicuously absent from the definition of a ServiceInstanceClaim.
There was a problem hiding this comment.
@krancour I think it is best if we don't get prescriptive about that for now and add it later. It's easier to get pieces everyone agrees on in first.
There was a problem hiding this comment.
+1
I purposefully left out specific mechanics of that sort
pmorie
reviewed
Oct 20, 2016
|
|
||
| # Resource Types | ||
|
|
||
| This section lists descriptions of Kubernetes resource types. |
There was a problem hiding this comment.
s/Kubernetes resource types/the resources in the API/
There was a problem hiding this comment.
Add a note saying that all names are TBD, these are just placeholders for discussion.
There was a problem hiding this comment.
Both done in a128762
pmorie
reviewed
Oct 20, 2016
|
|
||
| ## `ServiceInstanceClaim` | ||
|
|
||
| This resource is used by the consumer to get credentials for the backing service |
There was a problem hiding this comment.
I would actually just call this ServiceClaim for now, and say that there needs to be a resource on a service or instance somehow, but the specifics are TBD. I don't think anyone debates the need for a claim of some kind but there are clearly different opinions about what the claim should be against. I think you can keep the part about a claim resulting in resources that let you use the service.
|
LGTM, thanks. |
mdshuai
pushed a commit
to mdshuai/service-catalog
that referenced
this pull request
Mar 27, 2017
Get API server to start
jboyd01
pushed a commit
to jboyd01/service-catalog
that referenced
this pull request
Jul 27, 2018
Rebase to v0.1.25
piotrmiskiewicz
pushed a commit
to piotrmiskiewicz/service-catalog
that referenced
this pull request
Apr 8, 2019
* Replace ServiceBinding plugin by webhook * Replace Broker plugins by webhook * Adjust webhooks to multi validation handlers
mszostok
referenced
this pull request
in mszostok/service-catalog
May 16, 2019
* Replace ServiceBinding plugin by webhook * Replace Broker plugins by webhook * Adjust webhooks to multi validation handlers
mszostok
referenced
this pull request
in mszostok/service-catalog
May 16, 2019
* Replace ServiceBinding plugin by webhook * Replace Broker plugins by webhook * Adjust webhooks to multi validation handlers
piotrmiskiewicz
pushed a commit
to piotrmiskiewicz/service-catalog
that referenced
this pull request
Jun 12, 2019
* Replace ServiceBinding plugin by webhook * Replace Broker plugins by webhook * Adjust webhooks to multi validation handlers
k8s-ci-robot
pushed a commit
that referenced
this pull request
Sep 20, 2019
… (CRDs) solution (#2630) * Add basic validation to crds * Add webhook skeleton, remove api-server from chart, add webhoook server in chart, move PrepareForCreate login into webhook handler (#2) * Add webhook skeleton, remove api-server from chart, add webhoook server in chart, move PrepareForCreate login into webhook handler * Add logger and GVK matcher * Add test coverage for webhook (#6) * Add Status entry initialization in binding and instance controller (#5) * Change fs to label selector (#9) * Fix removing finalizer after switching to CRD /status sub-resource (#8) * Add tests to webhooks (#11) * Replace changevalidator with webhook (#14) * Replace default service plan with webhook (#10) * Add tests to webhooks - fix * Rewrite defaultServicePlan feature to webhook * Replace plugins by webhook (#16) * Replace ServiceBinding plugin by webhook * Replace Broker plugins by webhook * Adjust webhooks to multi validation handlers * Service Catalog going towards to CRDs (#18) * Migrate registry/strategy Updates to webhooks (#17) * Use Update instead of updateReference method (#19) * Replace tableconvertor with APC (#20) * Fix svcat tests after the rebase with the upstream master branch * Pre delete jobs - remove CRD after delete helm release (#21) * Apply fixes after executing `make verify` * Create docs about webhook implementation (#24) * Change the securePort for the webhook server because colidates with old api-server * Change import paths to kubernetes-sigs, and rebase with master * Apply fixes after rebase Fixes: * makefile targets, * instance deprovision operation * entries under additionalPrinterColumns in crds.yaml * unit tests after rebase * Update documentation (#40) * Update docs * Fix vendor after rebase with k8s 1.15 bump * Apply changes after review - remove the contrib/hack/crd folder - remove reference to Kyma project - rebase with current master - restore the image in chart - extract CRDs defintion to dedicated folder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The types herein will be used in future documents that make progress toward completing #14.
This patch partially replaces #13
cc/ @pmorie @bgrant0607 @duglin @judkowitz @slack @MHBauer
TODO:
api.mddocument