Add hack/release.sh to do releasing automatically #34
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/L
cofyc
force-pushed
the
release
branch
2 times, most recently
from
e379c84
to
9b4f506
Compare
|
@msau42 will build and release quay.io/cofyc/local-volume-provisioner:latest and quay.io/cofyc/local-volume-provisioner:v2.3.0. I suggest to do stable version releasing manually for now, because even if we configured a prow job to build/push image automatically, we need to check later again to make sure image are built and pushed successfully. If failed because of temporary issues (e.g. network), we need to delete/create tag again to trigger prow job to rerun. One thing I think it is useful is to automate unstable/canary image build on master branch. What do you think? |
| echo "info: building is skipped" | ||
| fi | ||
|
|
||
| echo "info: pushing $image" |
There was a problem hiding this comment.
Can you add a check somewhere here that if a stable image has already been pushed, we should not override it?
There was a problem hiding this comment.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cofyc, msau42 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
|
||
| if ! is_stable_version "$VERSION"; then | ||
| echo "error: VERSION '$VERSION' is not stable version, skipped pushing as latest image" | ||
| exit 1 |
There was a problem hiding this comment.
do we want to exit with error here? will this cause canary build jobs to fail?
There was a problem hiding this comment.
You are right. Job will fail, I will update it when configuring job in prow.
Add hack/release.sh to do releasing automatically
…ncy-openshift-4.10-local-storage-static-provisioner Updating local-storage-static-provisioner images to be consistent with ART
No description provided.