feat: add enableWindows as helm values for Windows DaemonSet creation

[jennwah]

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: add enableWindows as helm values for Windows DaemonSet creation
Add feature for enabling Windows DaemonSet if specified. By default its false.

Which issue(s) this PR fixes:
Fixes #381

Special notes for your reviewer:

Release note:

feat: add enableWindows helm chart value to control the deployment of Windows manifests

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: jennwah / name: Jenn Wah (384652a)

[k8s-ci-robot]

Welcome @jennwah!

It looks like this is your first PR to kubernetes-sigs/sig-storage-local-static-provisioner 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/sig-storage-local-static-provisioner has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jennwah. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jennwah]

/cc @mauriciopoppe perhaps you can help with moving this easy feature PR forward from issues #381 . Thank you!

[jennwah]

/cc @mauriciopoppe

[mauriciopoppe]

/ok-to-test

Please squash your changes into 1 commit

[jennwah]

Hi @mauriciopoppe , looks like all the tests have passed, can we get a lgtm and approval? Also, I have squashed the changes into 1 single commit with beautiful commit message. Thank you!

[mauriciopoppe]

Maybe the default value should be false to make Windows deployment an opt-in, unfortunately the chart was already released so I'd argue this'd be a breaking change.

@msau42 @andyzhangx thoughts? I don't know how many people are relying on the helm chart to install the Windows component, as far as I know it was only Microsoft that's using it, maybe we can make this change in a minor patch (e.g. release 1.1.0 of the helm chart).

[jennwah]

It looks like perhaps enabling windows deployment by default makes most sense here, for obvious reasons (not introducing breaking changes etc)

[jennwah]

@msau42 @andyzhangx @mauriciopoppe What do you think guys? Is this feature necessary, considering there're users asking for disabling windows deployment for its redundancy.

[mauriciopoppe]

yeah I think we can add it however we need to be ok whether it should be enabled by default

[jennwah]

@andyzhangx @msau42 please give your valuable opinions here for this feature addition.

Anything would happen if we don't enableWindows by default? How many users would be affected?

Or maybe perhaps we add the feature to disableWindows. But it is counterintuitive in nature....considering all features in helm values are addition add-ons, rather than removals...

Dilemma here.

[mauriciopoppe]

I think we can make it enableWindows: false by default but we'd need to bump the Helm Chart to v2 because there might be people who already rely on this manifest being installed by default. The more we wait the harder it's going to make this switch.

@andyzhangx are you installing LVP through the Helm chart?

[jennwah]

@mauriciopoppe Alright lets change to enableWindows: false by default. I have changed the necessary and also added into documentation as well.

[mauriciopoppe]

Looking better, a few comments:

• We have chart examples in https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/tree/master/helm/examples I think you need to run https://github.com/kubernetes-sigs/sig-storage-local-static-provisioner/blob/master/hack/update-generated.sh as well, please try to create a new commit for the generated changes.
• We also need to bump the version of the chart, this is done in

  sig-storage-local-static-provisioner/helm/provisioner/Chart.yaml

  Line 5 in be7c637

  version: 1.0.0

  .
• This change feat(helm): Added volume support for init containers #386 is also ongoing which will create a conflict in the line above, I believe it's a breaking change so I think we could go for the safe route and bump it to v2

[jennwah]

Ran the generated scripts for generated examples and also bumped it to v2 for helm chart.

[mauriciopoppe]

We flattened a few values in #393 so please update your copy adding the enableWindows flat as a top level value

[mauriciopoppe]

Thanks a lot for your patience @jennwah!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jennwah, mauriciopoppe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mauriciopoppe]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment