-
Notifications
You must be signed in to change notification settings - Fork 329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add allowedTopologies for storage class in helm #413
feat: add allowedTopologies for storage class in helm #413
Conversation
|
Hi @AndrewChubatiuk. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4731a33
to
3402dbc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
@@ -67,6 +69,8 @@ classes: | |||
fsType: ext4 | |||
# File name pattern to discover. By default, discover all file names. | |||
namePattern: "*" | |||
# Restrict topology of provisioned volumes to specific labels | |||
allowedTopologies: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this empty setting work? I suppose it should write like this allowedTopologies: {}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
condition in storage class checks if allowedTopologies is defined, so empty value is okay
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrewChubatiuk, andyzhangx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / why we need it:
Added support of allowedTopologies to allow mounting local volume to a pod only on nodes filtered by certain labels
Added ability to add additional rbac rules for a case when K8S API is triggered by init container
Special notes for your reviewer:
allowedTopologies
variable can be as a dict (and it will be converted to yaml) or as a yaml string template (useful to generate allowedTopologies from nodeAffinity)Release note: