Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

True Windows Support #203

Closed
luthermonson opened this issue Aug 4, 2022 · 16 comments
Closed

True Windows Support #203

luthermonson opened this issue Aug 4, 2022 · 16 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@luthermonson
Copy link
Contributor

The solution for windows support is to run everything in WSL since there is no real support for make on windows. This is functional but everything in this repo can be ran in windows with no issues if we do one of the following two things...

  1. There really isn't any great support for Makefile on windows and it's best to avoid if you want a cross platform tool. My personal favorite way to fix this problem is to use Mage. This way you're doing everything in go and people can install mage and use it cross platform on their own.
  2. We could migrate from a Makefile to a go cli and put all the functionality in there. Since this is a tool to boot kube clusters in vagrant it might make the most sense since it's more likely you'll be working in a branch of kube and it doesn't make sense to change dir over to this repo to run make commands to test your changes.

I'm open to both implementations if someone wants to make a decision on which direction we should take.
@dougsland dougsland mentioned this issue Aug 31, 2022
Closed
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 2, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 2, 2022
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 1, 2023
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mloskot mloskot mentioned this issue Apr 14, 2023
Merged
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 14, 2023
@mloskot
docs: Clarify requirement of Linux host with make
04eb8a0 
See also kubernetes-sigs#186 and kubernetes-sigs#203
@mloskot
Copy link
Contributor

mloskot commented Apr 14, 2023

I found this issue while learning the actual host environment requirements, see #244
Would it be possible to resurrect this idea?

mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 14, 2023
@mloskot
docs: Clarify requirement of Linux host with make
17e2965 
See also kubernetes-sigs#186 and kubernetes-sigs#203
@mloskot mloskot mentioned this issue Apr 21, 2023
Closed
@mloskot
Copy link
Contributor

mloskot commented Apr 21, 2023

I submitted a PowerShell-based prototype in #254
The Mage, or a driver written in Go in general, is still a compelling idea to me and I'd like to work on it as soon the cluster setup is in shape and runnable with the simple script.

@knabben
Copy link
Member

knabben commented Apr 21, 2023

/remove-lifecycle rotten
/reopen

@k8s-ci-robot
Copy link
Contributor

@knabben: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot reopened this Apr 21, 2023
@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 21, 2023
@knabben
Copy link
Member

knabben commented Apr 21, 2023

+1 for aiming in Made in the long run

@knabben
Copy link
Member

knabben commented Apr 21, 2023

The solution uses Powershell-script for now, what can fulfill the requirement of the issue. Closing as soon #254 is merged.

mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 23, 2023
@mloskot
Port Makefile to Magefile
4012490 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This implements the idea of true Windows support suggested in kubernetes-sigs#203
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 24, 2023
@mloskot
Port Makefile to Magefile
5ad0aa3 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This implements the idea of true Windows support suggested in kubernetes-sigs#203
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 24, 2023
@mloskot
Port Makefile to Magefile
03a146b 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This implements the idea of true Windows support suggested in kubernetes-sigs#203
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 24, 2023
@mloskot
Port Makefile to Magefile
59a980d 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This implements the idea of true Windows support suggested in kubernetes-sigs#203
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 24, 2023
@mloskot
Port Makefile to Magefile
542d1ff 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This implements the idea of true Windows support suggested in kubernetes-sigs#203
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 24, 2023
@mloskot
Add Magefiles as alternative port of Makefile
fa8dda4 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This implements the idea of true Windows support suggested in kubernetes-sigs#203
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 24, 2023
@mloskot
Add Magefiles as alternative port of Makefile
6dd4803 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This implements the idea of true Windows support suggested in kubernetes-sigs#203
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 24, 2023
@mloskot
Add Magefiles as alternative port of Makefile
ab9c038 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This implements the idea of true Windows support suggested in kubernetes-sigs#203
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 24, 2023
@mloskot
Add Magefiles as port of Makefile functionality
21f6a17 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This is first stab at the idea of the true Windows support in kubernetes-sigs#203
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 24, 2023
@mloskot
Add Magefiles as port of Makefile functionality
9394e08 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This is first stab at the idea of the true Windows support in kubernetes-sigs#203
@mloskot mloskot mentioned this issue Apr 24, 2023
Closed
@mloskot
Copy link
Contributor

mloskot commented Apr 24, 2023

@knabben & @luthermonson

+1 for aiming in Made in the long run

I've just proposed Magefiles for Mage in

mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 25, 2023
@mloskot
Add Magefiles as port of Makefile functionality
be7da71 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This is first stab at the idea of the true Windows support in kubernetes-sigs#203
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 27, 2023
@mloskot
Add Magefiles as port of Makefile functionality
9dc4a65 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This is first stab at the idea of the true Windows support in kubernetes-sigs#203

Complete Mage target with smoke test

Complete Mage target with end-to-end test

Run tests as part of all target

Comment on unchecked error code from sh.Run

Fix and update Mage target status

Add TODO reference on VAGRANT_VARIABLES env var
mloskot added a commit to mloskot/sig-windows-dev-tools that referenced this issue Apr 27, 2023
@mloskot
Add Magefiles as port of Makefile functionality
83e69fe 
This port is supposed to offer functional equivalent of the existing
Makefile, but its implementation is also inspired by make.ps1
recently proposed in kubernetes-sigs#254. If the Magefile is preferred and accepted,
then it is supposed to replace make.ps1 without merging of kubernetes-sigs#254.

This is first stab at the idea of the true Windows support in kubernetes-sigs#203

Complete Mage target with smoke test

Complete Mage target with end-to-end test

Run tests as part of all target

Comment on unchecked error code from sh.Run

Fix and update Mage target status

Add TODO reference on VAGRANT_VARIABLES env var
@mloskot mloskot mentioned this issue Apr 27, 2023
Merged
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 19, 2024
@mloskot
Copy link
Contributor

mloskot commented Jan 19, 2024

I think this can be closed as replaced by the currently ongoing SWDT CLI sub-project

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 18, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

@k8s-ci-robot k8s-ci-robot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 19, 2024
@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue, marking it as "Not Planned".

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Reopen this issue with /reopen
  • Mark this issue as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close not-planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mloskot @knabben @luthermonson @k8s-ci-robot @k8s-triage-robot