Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicity disable dualstack for win overlay #147

Conversation

jsturtevant
Copy link
Contributor

Reason for PR:

1.21 broke win overlay with dualstack: kubernetes/kubernetes#100966

The kubeadm tests are broken becuase of this:
https://testgrid.k8s.io/sig-windows-master-release#kubeadm-windows-gcp-k8s-stable

Issue Fixed:

Issue #

Requirements

  • Sqaush commits
  • Documentation
  • Tests

Notes:

/assign @marosset @neolit123

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsturtevant

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 12, 2021
@github-actions github-actions bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Apr 12, 2021
@neolit123
Copy link
Member

given this is a breaking change in kube-proxy we should be fixing it in a 1.21 patch release?
to me it seems we should wait for that, instead of toggling off the feature gate.

@jsturtevant
Copy link
Contributor Author

agree they should be fixed in a patch release, but win overlay isn't supported with dualstack either way. While waiting for the patch release I would rather have the tests running to catch other issues that might be introduced

@neolit123
Copy link
Member

ok, understood.
/lgtm
/hold

cancel the hold if you think this should merge now.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 12, 2021
@jsturtevant
Copy link
Contributor Author

PR to for fixing the patch: kubernetes/kubernetes#101047
Issue to track rolling this back: #148
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 19, 2021
@k8s-ci-robot k8s-ci-robot merged commit 004c32f into kubernetes-sigs:master Apr 19, 2021
@neolit123 neolit123 mentioned this pull request Apr 11, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants