Improve tooling installation

[mrueg]

• Update tools to latest version
• Don't repeat ourselves in the install.sh

[k8s-ci-robot]

Hi @mrueg. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[logicalhan]

/assign @ehashman
/triage accepted
/ok-to-test

[ehashman]

I understand what this does but this sacrifices clarity for reusability, can you add a brief comment explaining what this does? The grep expression is also very broad, might want to scope it down. e.g.

Suggested change

	cat tools.go | grep _ | awk -F'"' '{print $2}' | xargs -tI % go install %
	# Find import lines matching _, drop the _ and whitespace, pass as arguments to go install
	grep '^\s*_' tools.go | awk '{print $2}' | xargs -t go install

Changes I made in the suggestion here:

• cat isn't necessary
• reduced scope of grep to only match lines that start with possible whitespace then _
• no need to set the field separator to ", the shell will handle them fine
• pass all lines directly to a single go install command rather than installing each dep separately, which preserves the current behaviour of this script

[mrueg]

Not sure why this downgraded here.

[ehashman]

@mrueg I set up the CI installer to use 21.21, if this is regenerating locally with a lower version then your local install might be behind? As is this will fail the vet CI job.

usage-metrics-collector/tools/install-protoc.sh

Line 7 in 519fe97

PB_VERSION=${PB_VERSION:-21.12}

[ehashman]

MIT - what is pulling this in?

[mrueg]

./github.com/golangci/golangci-lint/pkg/golinters/testpackage.go: "github.com/maratori/testpackage/pkg/testpackage"
./github.com/golangci/golangci-lint/pkg/golinters/testableexamples.go: "github.com/maratori/testableexamples/pkg/testableexamples"

[ehashman]

@mrueg I set up the CI installer to use 21.21, if this is regenerating locally with a lower version then your local install might be behind? As is this will fail the vet CI job.

usage-metrics-collector/tools/install-protoc.sh

Line 7 in 519fe97

PB_VERSION=${PB_VERSION:-21.12}

[ndipebot]

/lgtm

[k8s-ci-robot]

@ndipebot: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[pwittrock]

neat trick

[pwittrock]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mrueg, ndipebot, pwittrock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pwittrock]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment