GC online volume expansion #1136

kavyashree-r · 2021-07-14T08:52:35Z

What this PR does / why we need it: GC Online volume expansion - set4

Which issue this PR fixes (optional, in fixes #(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Release notes:
Online volume expansion test cases for GC
Special notes for your reviewer:

1.Verify online volume expansion when PV with reclaim policy is reused to create PVC
2.verify online block volume expansion triggered when SVC CSI pod is down succeeds once SVC CSI pod comes up
3.Verify online volume expansion when POD is deleted and re-created
4.Verify online volume expansion when PVC is deleted
5.Volume expansion on shared VVOL, shared NFS and shared VMFS datastores
6.Verify online volume expansion on deployments

Logs : https://gist.github.com/kavyashree-r/bf25b80ed6dc02497721a367e485b961#file-gc-onlineresize-logs
https://gist.github.com/kavyashree-r/4ccaca23b858a2ae67ebc462cbf74ef1

k8s-ci-robot · 2021-07-14T08:52:43Z

Hi @kavyashree-r. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

rpanduranga · 2021-07-14T16:38:08Z

tests/e2e/gc_block_volume_expansion.go

+	/* Verify Online block volume expansion triggered when SVC CSI pod is down succeeds once SVC CSI pod comes up.
+	   Steps:
+	 	1. Create a SC with allowVolumeExpansion set to 'true' in GC.
+		2. create a PVC using the SC created in step 1 in GC and wait for binding
+		    with PV.
+		3. create a pod using the pvc created in step 2 in GC and wait FS init.
+	    4. bring CSI-controller pod down in SVC.
+	    5. Resize PVC with new size in GC.
+	    6. check for retries in GC.
+	    7. PVC in GC is in "Resizing" state and PVC in SVC has no state related
+		    to expansion.
+		8. bring the CSI-controller pod up in SVC.
+	    9. wait for PVC Status Condition changed to "FilesystemResizePending"
+	       in GC.
+	    10. Check Size from CNS query is same as what was used in step 7.
+	    11. wait for new size of PVC in GC and compare with SVC PVC size for
+	       equality.
+	    12. delete the pod, pvc,sc
+	*/


Please correct the formatting

rpanduranga · 2021-07-14T16:39:36Z

tests/e2e/gc_block_volume_expansion.go

+	       equality.
+	    12. delete the pod, pvc,sc
+	*/
+	ginkgo.It("verify online block volume expansion triggered when SVC CSI pod is down succeeds once SVC CSI pod comes up", func() {


This test should be marked destructive test so that the test runs before any other tests in e2e.

Please check with Chethan about the tag to use

For now, We have the respective change to handle destructive test in case of block "csi-block-vanilla-destructive"
Same is not available for GC . We need to take that in separate PR.
Till that I will make a TODO point in this test to add it for destructive test

chethanv28

/ok-to-test

svcbot-qecnsdp · 2021-07-26T06:18:00Z

Build ID: 98
WCP build status: FAILURE 
Stage before exit: null

svcbot-qecnsdp · 2021-07-26T07:40:09Z

Started WCP block pre-checkin pipeline... Build Number: 99

svcbot-qecnsdp · 2021-07-26T08:32:01Z

Build ID: 99
WCP build status: FAILURE 
Stage before exit: null 
Jenkins E2E Test Results: 
Ran 13 of 213 Specs in 2980.776 seconds
FAIL! -- 11 Passed | 2 Failed | 0 Pending | 200 Skipped
--- FAIL: TestE2E (2980.90s)
FAIL

Ginkgo ran 1 suite in 50m14.14885808s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/csi-wcp-pre-check-in/Results/99/vsphere-csi-driver`

svcbot-qecnsdp · 2021-07-26T11:54:01Z

Started WCP block pre-checkin pipeline... Build Number: 100

svcbot-qecnsdp · 2021-07-26T14:08:11Z

Build ID: 100
WCP build status: FAILURE 
Stage before exit: null 
Jenkins E2E Test Results: 
Ran 39 of 213 Specs in 7918.864 seconds
FAIL! -- 30 Passed | 9 Failed | 0 Pending | 174 Skipped
--- FAIL: TestE2E (7918.97s)
FAIL

Ginkgo ran 1 suite in 2h12m31.090381577s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/csi-wcp-pre-check-in/Results/100/vsphere-csi-driver`

kavyashree-r · 2021-07-27T09:52:44Z

Build ID: 100
WCP build status: FAILURE 
Stage before exit: null 
Jenkins E2E Test Results: 
Ran 39 of 213 Specs in 7918.864 seconds
FAIL! -- 30 Passed | 9 Failed | 0 Pending | 174 Skipped
--- FAIL: TestE2E (7918.97s)
FAIL

Ginkgo ran 1 suite in 2h12m31.090381577s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/csi-wcp-pre-check-in/Results/100/vsphere-csi-driver`

Failures are not related to the tests added added in this PR

rpanduranga · 2021-07-29T09:13:36Z

/approve

marunachalam · 2021-07-29T13:21:19Z

/approve

marunachalam · 2021-07-30T04:18:46Z

/approve

chethanv28

/ok-to-test

chethanv28

/approve
/lgtm

k8s-ci-robot · 2021-07-30T05:50:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, kavyashree-r, marunachalam, rpanduranga

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [chethanv28]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot requested review from chethanv28 and xing-yang July 14, 2021 08:52

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2021

kavyashree-r force-pushed the gc-online-vol-expansion branch from 5029056 to 5c11eb0 Compare July 14, 2021 09:49

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 14, 2021

kavyashree-r force-pushed the gc-online-vol-expansion branch 2 times, most recently from be64021 to 2a50106 Compare July 14, 2021 10:57

kavyashree-r changed the title ~~Gc online vol expansion~~ GC online volume expansion Jul 14, 2021

kavyashree-r force-pushed the gc-online-vol-expansion branch from 2a50106 to e37009d Compare July 14, 2021 11:30

rpanduranga reviewed Jul 14, 2021

View reviewed changes

chethanv28 reviewed Jul 15, 2021

View reviewed changes

GC-online volume resize tests

7c38d0a

kavyashree-r force-pushed the gc-online-vol-expansion branch from e37009d to 7c38d0a Compare July 26, 2021 07:33

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 26, 2021

chethanv28 reviewed Jul 30, 2021

View reviewed changes

chethanv28 approved these changes Jul 30, 2021

View reviewed changes

k8s-ci-robot assigned chethanv28 Jul 30, 2021

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2021

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2021

k8s-ci-robot merged commit ed994f6 into kubernetes-sigs:master Jul 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

GC online volume expansion #1136

GC online volume expansion #1136

kavyashree-r commented Jul 14, 2021 •

edited

k8s-ci-robot commented Jul 14, 2021

rpanduranga Jul 14, 2021

kavyashree-r Jul 26, 2021

rpanduranga Jul 14, 2021

kavyashree-r Jul 26, 2021 •

edited

chethanv28 left a comment

svcbot-qecnsdp commented Jul 26, 2021

svcbot-qecnsdp commented Jul 26, 2021

svcbot-qecnsdp commented Jul 26, 2021

svcbot-qecnsdp commented Jul 26, 2021

svcbot-qecnsdp commented Jul 26, 2021

kavyashree-r commented Jul 27, 2021

rpanduranga commented Jul 29, 2021

marunachalam commented Jul 29, 2021

marunachalam commented Jul 30, 2021

chethanv28 left a comment

chethanv28 left a comment

k8s-ci-robot commented Jul 30, 2021

GC online volume expansion #1136

GC online volume expansion #1136

Conversation

kavyashree-r commented Jul 14, 2021 • edited

k8s-ci-robot commented Jul 14, 2021

rpanduranga Jul 14, 2021

Choose a reason for hiding this comment

kavyashree-r Jul 26, 2021

Choose a reason for hiding this comment

rpanduranga Jul 14, 2021

Choose a reason for hiding this comment

kavyashree-r Jul 26, 2021 • edited

Choose a reason for hiding this comment

chethanv28 left a comment

Choose a reason for hiding this comment

svcbot-qecnsdp commented Jul 26, 2021

svcbot-qecnsdp commented Jul 26, 2021

svcbot-qecnsdp commented Jul 26, 2021

svcbot-qecnsdp commented Jul 26, 2021

svcbot-qecnsdp commented Jul 26, 2021

kavyashree-r commented Jul 27, 2021

rpanduranga commented Jul 29, 2021

marunachalam commented Jul 29, 2021

marunachalam commented Jul 30, 2021

chethanv28 left a comment

Choose a reason for hiding this comment

chethanv28 left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 30, 2021

kavyashree-r commented Jul 14, 2021 •

edited

kavyashree-r Jul 26, 2021 •

edited