Cleanup stale volume operation requests from snapshot operations

[lintongj]

What this PR does / why we need it:
Cleanup stale volume operation requests from snapshot operations

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:

regression test: PASS
functional test: PASS

2021-10-11T07:00:35.259Z        INFO    cnsvolumeoperationrequest/cnsvolumeoperationrequest.go:80       Creating CnsVolumeOperationRequest definition on API server and initializing VolumeOperationRequest instance {"TraceId": "bb2edc4d-b73f-4149-ab53-eaa9a80d4507"}
2021-10-11T07:00:35.274Z        INFO    kubernetes/kubernetes.go:434    "cnsvolumeoperationrequests.cns.vmware.com" CRD updated successfully    {"TraceId": "bb2edc4d-b73f-4149-ab53-eaa9a80d4507"}
2021-10-11T07:00:35.307Z        INFO    cnsvolumeoperationrequest/cnsvolumeoperationrequest.go:315      CnsVolumeOperationRequest clean up interval is set to 120 minutes    {"TraceId": "ed38494d-be52-4503-9fef-d11d0b39157d"}
2021-10-11T07:00:35.307Z        INFO    cnsvolumeoperationrequest/cnsvolumeoperationrequest.go:317      Cleaning up stale CnsVolumeOperationRequest instances.  {"TraceId": "ed38494d-be52-4503-9fef-d11d0b39157d"}
2021-10-11T07:00:35.343Z        DEBUG   cnsvolumeoperationrequest/cnsvolumeoperationrequest.go:293      Deleting CnsVolumeOperationRequest instance with name vmware-system-csi/deletesnapshot-b6d66f4d-dabd-43cd-9337-314d5dd04240-bd45f52b-e1d7-43f8-90a9-33dd058a38fa     {"TraceId": "ed38494d-be52-4503-9fef-d11d0b39157d"}
2021-10-11T07:00:35.352Z        DEBUG   cnsvolumeoperationrequest/cnsvolumeoperationrequest.go:293      Deleting CnsVolumeOperationRequest instance with name vmware-system-csi/snapshot-a2787e7e-afd9-4d0a-b4d7-9a680e67fe92-b6d66f4d-dabd-43cd-9337-314d5dd04240   {"TraceId": "ed38494d-be52-4503-9fef-d11d0b39157d"}
2021-10-11T07:00:35.357Z        INFO    cnsvolumeoperationrequest/cnsvolumeoperationrequest.go:406      Clean up of stale CnsVolumeOperationRequest complete.   {"TraceId": "ed38494d-be52-4503-9fef-d11d0b39157d"}

Special notes for your reviewer:

Release note:

Cleanup stale volume operation requests from snapshot operations

[k8s-ci-robot]

Hi @lintongj. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[svcbot-qecnsdp]

Started vanilla Block pipeline... Build Number: 624

[svcbot-qecnsdp]

Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
JUnit report was created: /home/worker/workspace/Block-Vanilla/Results/624/vsphere-csi-driver/tests/e2e/junit.xml

Ran 1 of 244 Specs in 414.344 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 243 Skipped
PASS

Ginkgo ran 1 suite in 7m42.292948992s
Test Suite Passed
--
JUnit report was created: /home/worker/workspace/Block-Vanilla/Results/624/vsphere-csi-driver/tests/e2e/junit.xml

Ran 14 of 244 Specs in 6977.391 seconds
SUCCESS! -- 14 Passed | 0 Failed | 0 Pending | 230 Skipped
PASS

Ginkgo ran 1 suite in 1h56m31.078246824s
Test Suite Passed
--
/home/worker/workspace/Block-Vanilla/Results/624/vsphere-csi-driver/tests/e2e/csi_cns_telemetry.go:203

Ran 41 of 244 Specs in 489.763 seconds
FAIL! -- 40 Passed | 1 Failed | 0 Pending | 203 Skipped


Ginkgo ran 1 suite in 8m24.395433002s
Test Suite Failed

[lintongj]

Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
JUnit report was created: /home/worker/workspace/Block-Vanilla/Results/624/vsphere-csi-driver/tests/e2e/junit.xml

Ran 1 of 244 Specs in 414.344 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 243 Skipped
PASS

Ginkgo ran 1 suite in 7m42.292948992s
Test Suite Passed
--
JUnit report was created: /home/worker/workspace/Block-Vanilla/Results/624/vsphere-csi-driver/tests/e2e/junit.xml

Ran 14 of 244 Specs in 6977.391 seconds
SUCCESS! -- 14 Passed | 0 Failed | 0 Pending | 230 Skipped
PASS

Ginkgo ran 1 suite in 1h56m31.078246824s
Test Suite Passed
--
/home/worker/workspace/Block-Vanilla/Results/624/vsphere-csi-driver/tests/e2e/csi_cns_telemetry.go:203

Ran 41 of 244 Specs in 489.763 seconds
FAIL! -- 40 Passed | 1 Failed | 0 Pending | 203 Skipped


Ginkgo ran 1 suite in 8m24.395433002s
Test Suite Failed

The test case, CNS-CSI Cluster Distribution Telemetry, was failed due to Wrong/empty cluster-distribution name present on CNS. It is not related with the change in this PR.

[xing-yang]

/ok-to-test

[xing-yang]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lintongj, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [xing-yang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[lintongj]

Hi @xing-yang, we still need a lgtm label to get this PR merged. Would you please help with it? Thanks

[deepakkinni]

/lgtm

[k8s-ci-robot]

@deepakkinni: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[xing-yang]

/lgtm