New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Topic/nigupta/add windows csi node code #1328
Topic/nigupta/add windows csi node code #1328
Conversation
…ndows driver images (kubernetes-sigs#1296)" (kubernetes-sigs#1327)" This reverts commit 0d78446.
Hi @nigupta1. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Started Vanilla block pre-checkin pipeline... Build Number: 461 |
|
/ok-to-test |
Started Vanilla block pre-checkin pipeline... Build Number: 471 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, nigupta1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This pr is to add windows node support. Earlier it was merged but backed out because k8s prows post-build failed. Made changes to login before pushing to gcr.
What this PR does / why we need it:
Which issue this PR fixes
fixes #123
Testing done:
Linux Worker Nodes Testing - #1328 (comment)
Windows Worker Nodes Testing - Manually executed volume Life cycle Operation workflows and created and deleted multiple Pods on Windows worker nodes.
Special notes for your reviewer:
Release note: