Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic/nigupta/add windows csi node code #1328

Conversation

nigupta1
Copy link
Contributor

@nigupta1 nigupta1 commented Oct 9, 2021

This pr is to add windows node support. Earlier it was merged but backed out because k8s prows post-build failed. Made changes to login before pushing to gcr.
What this PR does / why we need it:

Which issue this PR fixes
fixes #123

Testing done:
Linux Worker Nodes Testing - #1328 (comment)
Windows Worker Nodes Testing - Manually executed volume Life cycle Operation workflows and created and deleted multiple Pods on Windows worker nodes.

Special notes for your reviewer:

Release note:

windows csi node support

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @nigupta1. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 9, 2021
@svcbot-qecnsdp
Copy link

Started Vanilla block pre-checkin pipeline... Build Number: 461

@svcbot-qecnsdp
Copy link

Build ID: 461
Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
JUnit report was created: /home/worker/workspace/csi-block-vanilla-pre-check-in/461/vsphere-csi-driver/tests/e2e/junit.xml

Ran 1 of 244 Specs in 311.234 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 243 Skipped
PASS

Ginkgo ran 1 suite in 5m54.944650324s
Test Suite Passed
--
JUnit report was created: /home/worker/workspace/csi-block-vanilla-pre-check-in/461/vsphere-csi-driver/tests/e2e/junit.xml

Ran 12 of 244 Specs in 6708.687 seconds
SUCCESS! -- 12 Passed | 0 Failed | 0 Pending | 232 Skipped
PASS

Ginkgo ran 1 suite in 1h52m2.329906725s
Test Suite Passed
--
/home/worker/workspace/csi-block-vanilla-pre-check-in/461/vsphere-csi-driver/tests/e2e/vsphere_volume_expansion.go:2527

Ran 39 of 244 Specs in 1193.568 seconds
FAIL! -- 36 Passed | 3 Failed | 0 Pending | 205 Skipped


Ginkgo ran 1 suite in 20m9.077892278s
Test Suite Failed

@divyenpatel
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 11, 2021
@svcbot-qecnsdp
Copy link

Started Vanilla block pre-checkin pipeline... Build Number: 471

@svcbot-qecnsdp
Copy link

Build ID: 471
Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 

Ran 3 of 244 Specs in 622.538 seconds
FAIL! -- 1 Passed | 2 Failed | 0 Pending | 241 Skipped
--- FAIL: TestE2E (622.65s)
FAIL

Ginkgo ran 1 suite in 11m21.305729411s
Test Suite Failed

Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, nigupta1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6b1cb0d into kubernetes-sigs:master Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vSphere-CSI-Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows CSI Proxy
4 participants