Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick-release-2.3] protect migrated volume from vm deletion (#1762) #1767

Conversation

divyenpatel
Copy link
Member

@divyenpatel divyenpatel commented Jun 2, 2022

What this PR does / why we need it:
Cherry Pick #1762 to release 2.3 branch.

Testing done:
Build Passes

% make images
hack/release.sh
building gcr.io/cloud-provider-vsphere/csi/ci/driver:v2.3.1-2-g68375f91
GOPROXY=https://proxy.golang.org
[+] Building 113.3s (17/17) FINISHED
 => [internal] load build definition from Dockerfile                                                                                                                                  0.0s
 => => transferring dockerfile: 2.93kB                                                                                                                                                0.0s
 => [internal] load .dockerignore                                                                                                                                                     0.0s
 => => transferring context: 2B                                                                                                                                                       0.0s
 => [internal] load metadata for gcr.io/cloud-provider-vsphere/extra/csi-driver-base:latest                                                                                           0.7s
 => [internal] load metadata for docker.io/library/golang:1.15                                                                                                                        1.7s
 => [auth] library/golang:pull token for registry-1.docker.io                                                                                                                         0.0s
 => [stage-1 1/4] FROM gcr.io/cloud-provider-vsphere/extra/csi-driver-base:latest@sha256:1a9d0b302233988c3d21722d3d10765e901ea95ae206938c530c9f17fa818991                             2.6s
 => => resolve gcr.io/cloud-provider-vsphere/extra/csi-driver-base:latest@sha256:1a9d0b302233988c3d21722d3d10765e901ea95ae206938c530c9f17fa818991                                     0.0s
 => => sha256:1a9d0b302233988c3d21722d3d10765e901ea95ae206938c530c9f17fa818991 736B / 736B                                                                                            0.0s
 => => sha256:ca4c3b858d26293300d22047ec2bd05ff8f69518e4ff85d339c60f9a438b6fdb 1.84kB / 1.84kB                                                                                        0.0s
 => => sha256:30cc4273883f497a2a67571d9305f49e077f5cee7d189366ad27c4dcd9ee73d0 17.54MB / 17.54MB                                                                                      1.2s
 => => sha256:e19901b42ce4dee4f6faf3d8964727abbb10474b180fcf13ca06343a11ed6a03 571B / 571B                                                                                            0.2s
 => => extracting sha256:30cc4273883f497a2a67571d9305f49e077f5cee7d189366ad27c4dcd9ee73d0                                                                                             0.9s
 => => extracting sha256:e19901b42ce4dee4f6faf3d8964727abbb10474b180fcf13ca06343a11ed6a03                                                                                             0.0s
 => [internal] load build context                                                                                                                                                     0.1s
 => => transferring context: 1.59MB                                                                                                                                                   0.1s
 => [builder 1/6] FROM docker.io/library/golang:1.15@sha256:ea080cc817b02a946461d42c02891bf750e3916c52f7ea8187bccde8f312b59f                                                         18.8s
 => => resolve docker.io/library/golang:1.15@sha256:ea080cc817b02a946461d42c02891bf750e3916c52f7ea8187bccde8f312b59f                                                                  0.0s
 => => sha256:eb7ebf06372b4930e0b9539b3510422c4860ec3361bb2f22b63a857990cf9efe 1.79kB / 1.79kB                                                                                        0.0s
 => => sha256:40349a2425efb3650843103390e2ace030c4288c96f3619cafb16320ab021efb 7.00kB / 7.00kB                                                                                        0.0s
 => => sha256:ea080cc817b02a946461d42c02891bf750e3916c52f7ea8187bccde8f312b59f 2.36kB / 2.36kB                                                                                        0.0s
 => => sha256:627b765e08d177e63c9a202ca4991b711448905b934435c70b7cbd7d4a9c7959 50.44MB / 50.44MB                                                                                      2.1s
 => => sha256:c040670e5e559fd936db175530ad4c1dd014bd25b2bf25ea19fa20554fe2d736 7.83MB / 7.83MB                                                                                        0.6s
 => => sha256:073a180f4992853fa3dd8da604e7b041bc8ea92157749d042c0853312f178f6a 10.00MB / 10.00MB                                                                                      1.1s
 => => sha256:bf76209566d0c8d78df205b09e6e5b52ff7f10cb4e1c03d9336ed7dd2decd919 51.84MB / 51.84MB                                                                                      2.9s
 => => sha256:6182a456504bb119011b721ede5d1e6cf4d0621447465d80cc1d4e53c0ef95e6 68.75MB / 68.75MB                                                                                      4.8s
 => => sha256:73e3d3d88c3c574f686b011dcd0f559f099f6b0e755a45d2759f3934bad1be1c 121.11MB / 121.11MB                                                                                    6.2s
 => => extracting sha256:627b765e08d177e63c9a202ca4991b711448905b934435c70b7cbd7d4a9c7959                                                                                             3.6s
 => => sha256:5946d17734ce7686f86222b2d0d804ee5cb06cdb23ee6b056279185289336add 155B / 155B                                                                                            3.1s
 => => extracting sha256:c040670e5e559fd936db175530ad4c1dd014bd25b2bf25ea19fa20554fe2d736                                                                                             0.4s
 => => extracting sha256:073a180f4992853fa3dd8da604e7b041bc8ea92157749d042c0853312f178f6a                                                                                             0.3s
 => => extracting sha256:bf76209566d0c8d78df205b09e6e5b52ff7f10cb4e1c03d9336ed7dd2decd919                                                                                             2.7s
 => => extracting sha256:6182a456504bb119011b721ede5d1e6cf4d0621447465d80cc1d4e53c0ef95e6                                                                                             2.9s
 => => extracting sha256:73e3d3d88c3c574f686b011dcd0f559f099f6b0e755a45d2759f3934bad1be1c                                                                                             5.7s
 => => extracting sha256:5946d17734ce7686f86222b2d0d804ee5cb06cdb23ee6b056279185289336add                                                                                             0.0s
 => [stage-1 2/4] RUN tdnf -y install   nfs-utils   util-linux   e2fsprogs   xfsprogs                                                                                                23.1s
 => [builder 2/6] WORKDIR /build                                                                                                                                                      1.8s
 => [builder 3/6] COPY go.mod go.sum ./                                                                                                                                               0.0s
 => [builder 4/6] COPY pkg/    pkg/                                                                                                                                                   0.0s
 => [builder 5/6] COPY cmd/    cmd/                                                                                                                                                   0.0s
 => [builder 6/6] RUN go build -a -ldflags="-w -s -extldflags=static -X sigs.k8s.io/vsphere-csi-driver/pkg/csi/service.Version=v2.3.1-2-g68375f91" -o vsphere-csi ./cmd/vsphere-csi  89.2s
 => [stage-1 3/4] RUN tdnf clean all                                                                                                                                                  0.6s
 => [stage-1 4/4] COPY --from=builder /build/vsphere-csi /bin/vsphere-csi                                                                                                             0.1s
 => exporting to image                                                                                                                                                                1.3s
 => => exporting layers                                                                                                                                                               1.3s
 => => writing image sha256:31205ccfa4220b43baff4c01c64f087d5fb3152942b016118f74b00be2512b51                                                                                          0.0s
 => => naming to gcr.io/cloud-provider-vsphere/csi/ci/driver:v2.3.1-2-g68375f91                                                                                                       0.0s
building gcr.io/cloud-provider-vsphere/csi/ci/syncer:v2.3.1-2-g68375f91
[+] Building 90.0s (19/19) FINISHED
 => [internal] load build definition from Dockerfile                                                                                                                                  0.0s
 => => transferring dockerfile: 2.41kB                                                                                                                                                0.0s
 => [internal] load .dockerignore                                                                                                                                                     0.0s
 => => transferring context: 2B                                                                                                                                                       0.0s
 => [internal] load metadata for docker.io/library/golang:1.15                                                                                                                        0.5s
 => [internal] load metadata for gcr.io/cloud-provider-vsphere/extra/csi-driver-base:latest                                                                                           0.2s
 => [builder 1/6] FROM docker.io/library/golang:1.15@sha256:ea080cc817b02a946461d42c02891bf750e3916c52f7ea8187bccde8f312b59f                                                          0.0s
 => [internal] load build context                                                                                                                                                     0.0s
 => => transferring context: 13.68kB                                                                                                                                                  0.0s
 => CACHED [stage-1 1/7] FROM gcr.io/cloud-provider-vsphere/extra/csi-driver-base:latest@sha256:1a9d0b302233988c3d21722d3d10765e901ea95ae206938c530c9f17fa818991                      0.0s
 => CACHED [builder 2/6] WORKDIR /build                                                                                                                                               0.0s
 => CACHED [builder 3/6] COPY go.mod go.sum ./                                                                                                                                        0.0s
 => CACHED [builder 4/6] COPY pkg/    pkg/                                                                                                                                            0.0s
 => CACHED [builder 5/6] COPY cmd/    cmd/                                                                                                                                            0.0s
 => [builder 6/6] RUN go build -a -ldflags="-w -s -extldflags=static -X sigs.k8s.io/vsphere-csi-driver/pkg/syncer.Version=v2.3.1-2-g68375f91" -o vsphere-syncer ./cmd/syncer         88.5s
 => [stage-1 2/7] COPY --from=builder /build/vsphere-syncer /bin/vsphere-syncer                                                                                                       0.1s
 => [stage-1 3/7] RUN mkdir -p config                                                                                                                                                 0.2s
 => [stage-1 4/7] ADD pkg/apis/cnsoperator/config/cnsregistervolume_crd.yaml /config/                                                                                                 0.0s
 => [stage-1 5/7] ADD pkg/apis/cnsoperator/config/cnsfileaccessconfig_crd.yaml /config/                                                                                               0.0s
 => [stage-1 6/7] ADD pkg/internalapis/cnsoperator/config/cnsfilevolumeclient_crd.yaml /config/                                                                                       0.0s
 => [stage-1 7/7] ADD pkg/internalapis/cnsoperator/config/triggercsifullsync_crd.yaml /config/                                                                                        0.0s
 => exporting to image                                                                                                                                                                0.3s
 => => exporting layers                                                                                                                                                               0.3s
 => => writing image sha256:f4b8b39e826cc705c54ab4573ccfefe22a78c05e46b88182eee40cdc60f5413c                                                                                          0.0s
 => => naming to gcr.io/cloud-provider-vsphere/csi/ci/syncer:v2.3.1-2-g68375f91                                                                                                       0.0s
tagging image gcr.io/cloud-provider-vsphere/csi/ci/driver:v2.3.1-2-g68375f91 as latest
tagging image gcr.io/cloud-provider-vsphere/csi/ci/syncer:v2.3.1-2-g68375f91 as latest

Special notes for your reviewer:

Release note:

protect migrated volume from vm deletion

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 2, 2022
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 2, 2022
@divyenpatel divyenpatel force-pushed the cherry-pick-pr-1762-release-2.3 branch 4 times, most recently from 7e6fd54 to 8502a9d Compare June 3, 2022 14:59
@divyenpatel divyenpatel force-pushed the cherry-pick-pr-1762-release-2.3 branch from 8502a9d to 68375f9 Compare June 3, 2022 15:07
Copy link
Collaborator

@chethanv28 chethanv28 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chethanv28,divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 3, 2022
@k8s-ci-robot k8s-ci-robot merged commit c674fbe into kubernetes-sigs:release-2.3 Jun 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants