Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pick CSI namespace from environment variable in idempotency feature #1946

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Pick CSI namespace from environment variable in idempotency feature #1946

merged 1 commit into from
Aug 30, 2022

Conversation

shalini-b
Copy link
Collaborator

@shalini-b shalini-b commented Aug 28, 2022 •
edited
Loading

What this PR does / why we need it: This PR picks up the CSI driver namespace from the environment variable and makes sure internal resources for idempotency feature are created in that namespace instead of hardcoding it to vmware-system-csi.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
E2E tests ran successfully on WCP and Vanilla

Special notes for your reviewer:

Release note:

Pick CSI namespace from environment variable in idempotency feature

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 28, 2022
@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1407

@svcbot-qecnsdp
Copy link

Started WCP block pre-checkin pipeline... Build Number: 631

@svcbot-qecnsdp
Copy link 

Build ID: 631
WCP build status: FAILURE 
Stage before exit: null

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: testbed-deployment

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1408

@svcbot-qecnsdp
Copy link

Started WCP block pre-checkin pipeline... Build Number: 632

@svcbot-qecnsdp
Copy link 

Build ID: 632
WCP build status: SUCCESS 
Stage before exit: finally 
Jenkins E2E Test Results: 

Ran 14 of 621 Specs in 2952.185 seconds
SUCCESS! -- 14 Passed | 0 Failed | 0 Pending | 607 Skipped
PASS

Ginkgo ran 1 suite in 50m5.635629322s
Test Suite Passed
make: Leaving directory `/home/worker/workspace/csi-wcp-pre-check-in/Results/632/vsphere-csi-driver`

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: testbed-deployment

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1409

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1410

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: testbed-deployment

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
JUnit report was created: /home/worker/workspace/Block-Vanilla/Results/1409/vsphere-csi-driver/tests/e2e/junit.xml

Ran 1 of 621 Specs in 432.668 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 620 Skipped
PASS

Ginkgo ran 1 suite in 8m16.859845114s
Test Suite Passed
--
JUnit report was created: /home/worker/workspace/Block-Vanilla/Results/1409/vsphere-csi-driver/tests/e2e/junit.xml

Ran 13 of 621 Specs in 5062.244 seconds
SUCCESS! -- 13 Passed | 0 Failed | 0 Pending | 608 Skipped
PASS

Ginkgo ran 1 suite in 1h24m38.19751986s
Test Suite Passed
--
/home/worker/workspace/Block-Vanilla/Results/1409/vsphere-csi-driver/tests/e2e/csi_cns_telemetry.go:181

Ran 41 of 621 Specs in 549.884 seconds
FAIL! -- 39 Passed | 2 Failed | 0 Pending | 580 Skipped


Ginkgo ran 1 suite in 9m26.361558274s
Test Suite Failed

@shalini-b shalini-b force-pushed the sbhaskara/fix-idempotency-ns branch from f1a149a to 2af42e1 Compare August 29, 2022 23:12
@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1412

@svcbot-qecnsdp
Copy link 

Block vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
JUnit report was created: /home/worker/workspace/Block-Vanilla/Results/1412/vsphere-csi-driver/tests/e2e/junit.xml

Ran 1 of 622 Specs in 402.318 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 621 Skipped
PASS

Ginkgo ran 1 suite in 8m9.880313309s
Test Suite Passed
--

Ran 13 of 622 Specs in 4042.788 seconds
FAIL! -- 11 Passed | 2 Failed | 0 Pending | 609 Skipped
--- FAIL: TestE2E (4043.02s)
FAIL

Ginkgo ran 1 suite in 1h7m42.998542367s
Test Suite Failed

@svcbot-qecnsdp
Copy link

Started vanilla Block pipeline... Build Number: 1417

@svcbot-qecnsdp
Copy link 

Block vanilla build status: SUCCESS 
Stage before exit: finally 
Jenkins E2E Test Results: 
JUnit report was created: /home/worker/workspace/Block-Vanilla@2/Results/1417/vsphere-csi-driver/tests/e2e/junit.xml

Ran 1 of 622 Specs in 404.687 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 621 Skipped
PASS

Ginkgo ran 1 suite in 8m27.86921385s
Test Suite Passed
--
JUnit report was created: /home/worker/workspace/Block-Vanilla@2/Results/1417/vsphere-csi-driver/tests/e2e/junit.xml

Ran 13 of 622 Specs in 5192.454 seconds
SUCCESS! -- 13 Passed | 0 Failed | 0 Pending | 609 Skipped
PASS

Ginkgo ran 1 suite in 1h26m51.911787239s
Test Suite Passed
--
------------------------------

Ran 41 of 622 Specs in 1130.655 seconds
SUCCESS! -- 41 Passed | 0 Failed | 0 Pending | 581 Skipped


Ginkgo ran 1 suite in 19m13.957695845s
Test Suite Passed

divyenpatel
divyenpatel approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divyenpatel, shalini-b

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [divyenpatel,shalini-b]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divyenpatel
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4c491d4 into kubernetes-sigs:master Aug 30, 2022
shalini-b added a commit to shalini-b/vsphere-csi-driver that referenced this pull request Aug 31, 2022
@shalini-b
Pick CSI namespace from environment in idempotency feature (kubernete…
66fd10f 
…s-sigs#1946)
@shalini-b shalini-b mentioned this pull request Aug 31, 2022
Merged
shalini-b added a commit to shalini-b/vsphere-csi-driver that referenced this pull request Aug 31, 2022
@shalini-b
Pick CSI namespace from environment in idempotency feature (kubernete…
1451d65 
…s-sigs#1946)
@shalini-b shalini-b mentioned this pull request Aug 31, 2022
Merged
shalini-b added a commit to shalini-b/vsphere-csi-driver that referenced this pull request Aug 31, 2022
@shalini-b
Pick CSI namespace from environment in idempotency feature (kubernete…
3c2f424 
…s-sigs#1946)
@shalini-b shalini-b mentioned this pull request Aug 31, 2022
Merged
k8s-ci-robot pushed a commit that referenced this pull request Aug 31, 2022
@shalini-b
Pick CSI namespace from environment in idempotency feature (#1946) (#…
6a3e0e4 
…1953)
k8s-ci-robot pushed a commit that referenced this pull request Aug 31, 2022
@shalini-b
Pick CSI namespace from environment in idempotency feature (#1946) (#…
ed0958c 
…1951)
k8s-ci-robot pushed a commit that referenced this pull request Aug 31, 2022
@shalini-b
Pick CSI namespace from environment in idempotency feature (#1946) (#…
875ab31 
…1952)
adikul30 pushed a commit to adikul30/vsphere-csi-driver that referenced this pull request Sep 22, 2022
@shalini-b @adikul30
Pick CSI namespace from environment in idempotency feature (kubernete…
85a4735 
…s-sigs#1946)
@RomanBednar RomanBednar mentioned this pull request Sep 23, 2022
Merged
@divyenpatel divyenpatel mentioned this pull request Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyenpatel divyenpatel divyenpatel approved these changes

@gnufied gnufied Awaiting requested review from gnufied

@SandeepPissay SandeepPissay Awaiting requested review from SandeepPissay

Assignees

@divyenpatel divyenpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shalini-b @svcbot-qecnsdp @k8s-ci-robot @divyenpatel