-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pick CSI namespace from environment variable in idempotency feature #1946
Pick CSI namespace from environment variable in idempotency feature #1946
Conversation
Started vanilla Block pipeline... Build Number: 1407 |
Started WCP block pre-checkin pipeline... Build Number: 631 |
|
|
Started vanilla Block pipeline... Build Number: 1408 |
Started WCP block pre-checkin pipeline... Build Number: 632 |
|
|
Started vanilla Block pipeline... Build Number: 1409 |
Started vanilla Block pipeline... Build Number: 1410 |
|
|
pkg/internalapis/cnsvolumeoperationrequest/cnsvolumeoperationrequest.go
Outdated
Show resolved
Hide resolved
f1a149a
to
2af42e1
Compare
Started vanilla Block pipeline... Build Number: 1412 |
|
Started vanilla Block pipeline... Build Number: 1417 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, shalini-b The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it: This PR picks up the CSI driver namespace from the environment variable and makes sure internal resources for idempotency feature are created in that namespace instead of hardcoding it to
vmware-system-csi
.Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done:
E2E tests ran successfully on WCP and Vanilla
Special notes for your reviewer:
Release note: