Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more thorough when deciding whether a volume is mounted or not. #2004

Merged
merged 1 commit into from Oct 14, 2022

Conversation

cphvmware
Copy link
Contributor

@cphvmware cphvmware commented Sep 26, 2022

What this PR does / why we need it:
On Windows, use of isLikelyNotMountPoint() is not a reliable way to decide whether a mount point is usable. This change adds additional logic to get a reliable result.

Testing done:
#2004 (comment)

Special notes for your reviewer:

Release note:

Be more thorough when deciding whether a volume is mounted or not

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 26, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 26, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cphvmware. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 26, 2022
@divyenpatel
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 27, 2022
@cphvmware
Copy link
Contributor Author

Testing done:
`Power Off/Power On:

...after a while...

kubo@BYgyz7NY8iIQz:~$ kubectl get pods -o wide
NAME    READY   STATUS    RESTARTS            AGE   IP            NODE                                                     NOMINATED NODE   READINESS GATES
web-0   1/1     Running   1 (<invalid> ago)   20m   100.96.3.16   tkg-vc-antrea-md-0-windows-containerd-5c7888d6bc-wdnvm   <none>           <none>

Delete pod:

kubectl delete pods web-0 --grace-period=0 --force
warning: Immediate deletion does not wait for confirmation that the running resource has been terminated. The resource may continue to run on the cluster indefinitely.
pod "web-0" force deleted

...after a while...

kubo@BYgyz7NY8iIQz:~$ kubectl get pods -o wide
NAME    READY   STATUS    RESTARTS   AGE   IP            NODE                                                     NOMINATED NODE   READINESS GATES
web-0   1/1     Running   0          86s   100.96.3.17   tkg-vc-antrea-md-0-windows-containerd-5c7888d6bc-wdnvm   <none>           <none>

`

@cphvmware cphvmware marked this pull request as ready for review October 13, 2022 22:36
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 13, 2022
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 14, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cphvmware, divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 4dcbe66 into kubernetes-sigs:master Oct 14, 2022
skogta pushed a commit to skogta/vsphere-csi-driver that referenced this pull request Oct 17, 2022
skogta pushed a commit to skogta/vsphere-csi-driver that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants