New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make separate CNS creation and deletion maps for VCs during full Sync #2163
Make separate CNS creation and deletion maps for VCs during full Sync #2163
Conversation
Hi @skogta. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2115eaf
to
9464d73
Compare
/ok-to-test |
@akankshapanse: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: akankshapanse, divyenpatel, skogta The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
cnsCreationMap and cnsDeletion maps are being shared across all VCs which is causing clean up of volumes from these maps. To fix this, these maps will become map of map where each VC will have its separate map of volumes to be deleted and created.
Testing done:
Tested for vanilla (FSS enabled as well as disabled) and SV cluster:
Tested for vanilla (FSS enabled as well as disabled) and SV cluster:
Special notes for your reviewer:
Release note: