-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: GenerateDatastoreMapForBlockVolumes fails if there are no entities #2443
fix: GenerateDatastoreMapForBlockVolumes fails if there are no entities #2443
Conversation
…dObjectReferences
Hi @Mattes83. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/approve |
@Mattes83 we are trying to understand the usecase. So you have just added another vCenter in the config secret and at later point of time, planning to add nodes and datastores? |
Yes, exactly. We are currently in the process of migrating clusters from one vcenter to another. In between we have nodes in multiple vcenters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: divyenpatel, Mattes83, shalini-b The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
We have a multi vcenter setup in which all datastores are currently in only one vcenter.
This leads to many errors like the following:
{"level":"error","time":"2023-06-22T11:14:01.916433945Z","caller":"common/authmanager.go:247","msg":"failed to get datastores with required priv for vCenter \"xxx\". Error: ServerFaultCode: \nRequired parameter entities is missing\n\nwhile parsing call information for method HasUserPrivilegeOnEntities\nat line 2, column 66\n\nwhile parsing SOAP body\nat line 2, column 60\n\nwhile parsing SOAP envelope\nat line 2, column 0\n\nwhile parsing HTTP request for method hasUserPrivilegeOnEntities\non object of type vim.AuthorizationManager\nat line 1, column 0","TraceId":"2b45f0db-1d50-4299-9f15-f6a34f8807ec","stacktrace":"sigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/common.GenerateDatastoreMapForBlockVolumes\n\t/build/pkg/csi/service/common/authmanager.go:247\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/common.(*AuthManager).refreshDatastoreMapForBlockVolumes\n\t/build/pkg/csi/service/common/authmanager.go:158\nsigs.k8s.io/vsphere-csi-driver/v3/pkg/csi/service/common.ComputeDatastoreMapForBlockVolumes\n\t/build/pkg/csi/service/common/authmanager.go:199"} {"level":"warn","time":"2023-06-22T11:14:01.916459756Z","caller":"common/authmanager.go:166","msg":"auth manager: failed to get updated datastoreMapForBlockVolumes for vCenter \"xxx\", Err: ServerFaultCode: \nRequired parameter entities is missing\n\nwhile parsing call information for method HasUserPrivilegeOnEntities\nat line 2, column 66\n\nwhile parsing SOAP body\nat line 2, column 60\n\nwhile parsing SOAP envelope\nat line 2, column 0\n\nwhile parsing HTTP request for method hasUserPrivilegeOnEntities\non object of type vim.AuthorizationManager\nat line 1, column 0","TraceId":"2b45f0db-1d50-4299-9f15-f6a34f8807ec"}
We also suspect this to be responsible for the need to restart the csi vsphere controller from time to time to get volumes provisioned.
Testing done:
Not sure if I need to write a test for this. If yes i'd appreciate a hint on where to add it.
Special notes for your reviewer:
Release note: