Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Topology code fixes #2536

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Topology code fixes #2536

merged 1 commit into from
Sep 14, 2023

Conversation

sipriyaa
Copy link
Contributor

@sipriyaa sipriyaa commented Sep 5, 2023

What this PR does / why we need it:
Multi vc code fixes

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #
Multi vc code fixes

Testing done:
Yes

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 5, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 5, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @sipriyaa. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 5, 2023
@svcbot-qecnsdp
Copy link

Started Vanilla block pre-checkin pipeline... Build Number: 482

@svcbot-qecnsdp
Copy link

Started Vanilla block pre-checkin pipeline... Build Number: 483

@sipriyaa sipriyaa changed the title [WIP] Multi vc code fixes Topology code fixes Sep 14, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
rajguptavm
rajguptavm approved these changes Sep 14, 2023
View reviewed changes
Copy link
Contributor

@rajguptavm rajguptavm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@rajguptavm: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kavyashree-r
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kavyashree-r, rajguptavm, sipriyaa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@kavyashree-r
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit abcfed6 into kubernetes-sigs:master Sep 14, 2023
12 checks passed
@svcbot-qecnsdp
Copy link

Started Vanilla block pre-checkin pipeline... Build Number: 484

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajguptavm rajguptavm rajguptavm approved these changes

@kavyashree-r kavyashree-r Awaiting requested review from kavyashree-r

@sashrith sashrith Awaiting requested review from sashrith

Assignees

@kavyashree-r kavyashree-r

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sipriyaa @k8s-ci-robot @svcbot-qecnsdp @kavyashree-r @rajguptavm