-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate vCenter username and crash CSI driver if username is not a fully qualified domain name #2631
Validate vCenter username and crash CSI driver if username is not a fully qualified domain name #2631
Conversation
Add few info level logs in authmanager code (kubernetes-sigs#2490) Validate vCenter username and don't allow username without domain name (kubernetes-sigs#2595)
Hi @vdkotkar. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/approve
@vdkotkar can you update testing done section so we can merge this PR? |
Started vanilla Block pipeline... Build Number: 2265 |
|
Started vanilla Block pipeline... Build Number: 2269 |
|
@vdkotkar can you verify test manually. Seem pipeline is failing. |
Started vanilla Block pipeline... Build Number: 2274 |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28, divyenpatel, vdkotkar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
What this PR does / why we need it:
Cherry picking changes from #2490 and #2595 to release-2.6 branch.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Testing done:
Will run e2e tests
Special notes for your reviewer:
Release note: