Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frequently used go libs to latest releases #2779

Merged

Conversation

chethanv28
Copy link
Collaborator

@chethanv28 chethanv28 commented Jan 29, 2024

What this PR does / why we need it:
Update frequently used go libs to latest releases:

	github.com/fsnotify/fsnotify v1.7.0
	github.com/kubernetes-csi/csi-lib-utils v0.17.0
	github.com/kubernetes-csi/csi-proxy/client v1.1.3
	github.com/kubernetes-csi/external-snapshotter/client/v6 v6.3.3
	github.com/prometheus/client_golang v1.18.0
	go.uber.org/zap v1.26.0
	golang.org/x/crypto v0.18.0
	google.golang.org/grpc v1.60.0
        sigs.k8s.io/controller-runtime v0.17.0

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:
Verified build & basic e2e test works as expected. See #2779 (comment)

Verified reload config works as expected:

# kubectl get secret -n vmware-system-csi
# kubectl edit secret vsphere-config-secret -n vmware-system-csi

kubectl logs vsphere-csi-controller-7f8c6965dc-77r98 -c vsphere-csi-controller -n vmware-system-csi

{"level":"info","time":"2024-02-01T23:32:46.059505766Z","caller":"vanilla/controller.go:384","msg":"Reloading Configuration","TraceId":"504174e1-f6d3-498d-bd6f-f8f767bca5ff"}
{"level":"info","time":"2024-02-01T23:32:46.067188498Z","caller":"vsphere/utils.go:259","msg":"Defaulting timeout for vCenter Client to 5 minutes","TraceId":"504174e1-f6d3-498d-bd6f-f8f767bca5ff"}
{"level":"info","time":"2024-02-01T23:32:46.069715543Z","caller":"volume/manager.go:346","msg":"Re-initializing defaultManager.virtualCenter","TraceId":"504174e1-f6d3-498d-bd6f-f8f767bca5ff"}
{"level":"info","time":"2024-02-01T23:32:46.071658861Z","caller":"volume/manager.go:353","msg":"VC client timeout is set to 5m0s","TraceId":"504174e1-f6d3-498d-bd6f-f8f767bca5ff"}
{"level":"info","time":"2024-02-01T23:32:46.072095886Z","caller":"volume/manager.go:355","msg":"Done resetting volume.defaultManager","TraceId":"504174e1-f6d3-498d-bd6f-f8f767bca5ff"}
{"level":"info","time":"2024-02-01T23:32:46.073232214Z","caller":"common/authmanager.go:148","msg":"Resetting vCenter Instance in the AuthManager","TraceId":"504174e1-f6d3-498d-bd6f-f8f767bca5ff"}
{"level":"info","time":"2024-02-01T23:32:46.075282172Z","caller":"kubernetes/kubernetes.go:85","msg":"k8s client using in-cluster config","TraceId":"504174e1-f6d3-498d-bd6f-f8f767bca5ff"}
{"level":"info","time":"2024-02-01T23:32:46.077979835Z","caller":"kubernetes/kubernetes.go:382","msg":"Setting client QPS to 100.000000 and Burst to 100.","TraceId":"504174e1-f6d3-498d-bd6f-f8f767bca5ff"}
{"level":"info","time":"2024-02-01T23:32:46.081977393Z","caller":"vanilla/controller.go:312","msg":"Successfully reloaded configuration from: \"/etc/cloud/csi-vsphere.conf\"","TraceId":"0d57c3e4-16f8-4b07-b6e2-c2f0b1b700f8"}

Special notes for your reviewer:

Release note:

Update frequently used go libs to latest releases

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 29, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2024
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 29, 2024
@svcbot-qecnsdp
Copy link

Started Vanilla block pre-checkin pipeline... Build Number: 2637

@svcbot-qecnsdp
Copy link

Build ID: 2637
Block vanilla build status: SUCCESS 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
------------------------------

Ran 1 of 816 Specs in 42.428 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 815 Skipped
PASS

Ginkgo ran 1 suite in 2m11.198861916s
Test Suite Passed

@divyenpatel
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 1, 2024
Copy link
Member

@divyenpatel divyenpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [chethanv28,divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@divyenpatel
Copy link
Member

we will cut release-3.2 branch with this change. so removing label for release-3.2.0-candidate

@k8s-ci-robot k8s-ci-robot merged commit 5873766 into kubernetes-sigs:master Feb 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants