Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove listview-tasks feature gate #2851

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Remove listview-tasks feature gate #2851

merged 1 commit into from
Jul 11, 2024

Conversation

adikul30
Copy link
Contributor

@adikul30 adikul30 commented Apr 11, 2024 •
edited
Loading

What this PR does / why we need it:

ListView FSS has been part of previous vanilla releases and has also been enabled on supervisor since some time. We can now remove this FSS.

As part of this change, we will reuse a single VC session throughout a container. This will reduce the number of VC sessions created by CSI.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Testing done:

### Vanilla

Build #2633 (Jul 10, 2024, 2:19:34 PM)
adkulkarni
PR 2851

Ran 1 of 877 Specs in 365.975 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 876 Skipped
PASS

Ginkgo ran 1 suite in 7m13.124314528s
Test Suite Passed
--
Ran 14 of 877 Specs in 12169.237 seconds
FAIL! -- 13 Passed | 1 Failed | 0 Pending | 863 Skipped
--- FAIL: TestE2E (12169.35s)
FAIL

Ginkgo ran 1 suite in 3h23m7.447861368s

### supervisor

Build #1470 (Jul 10, 2024, 6:07:17 PM)
adkulkarni
PR 2851
Ran 1 of 877 Specs in 278.803 seconds SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 876 Skipped PASS Ginkgo ran 1 suite in 6m4.450727696s Test Suite Passed make: Leaving directory `/home/worker/workspace/csi-wcp-precheckin/Results/1470/vsphere-csi-driver'

Special notes for your reviewer:

Release note:

Remove listview-tasks feature gate

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adikul30

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 11, 2024
@adikul30 adikul30 changed the title rm listview feature gate rm listview-tasks feature gate Apr 11, 2024
@adikul30 adikul30 changed the title rm listview-tasks feature gate (wip) rm listview-tasks feature gate Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2024
@adikul30 adikul30 force-pushed the rm-listview-feature-gate branch 2 times, most recently from 92e98c8 to 35c0c62 Compare June 26, 2024 18:28
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 26, 2024
@adikul30 adikul30 force-pushed the rm-listview-feature-gate branch 3 times, most recently from 0ea0374 to 5eb276e Compare June 28, 2024 19:05
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 28, 2024
@adikul30 adikul30 force-pushed the rm-listview-feature-gate branch 2 times, most recently from ebf4325 to c18d020 Compare June 28, 2024 21:15
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 28, 2024
@adikul30 adikul30 force-pushed the rm-listview-feature-gate branch 3 times, most recently from c4c00c6 to e10e840 Compare July 3, 2024 22:53
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 10, 2024
@adikul30 adikul30 force-pushed the rm-listview-feature-gate branch 2 times, most recently from 2048ecf to 24797c6 Compare July 10, 2024 11:00
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 10, 2024
@adikul30 adikul30 force-pushed the rm-listview-feature-gate branch 5 times, most recently from 070c1ab to 3774e06 Compare July 10, 2024 23:14
@adikul30 adikul30 changed the title (wip) rm listview-tasks feature gate Remove listview-tasks feature gate Jul 10, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 10, 2024
@adikul30
Copy link
Contributor Author

cc: @divyenpatel, this PR can be merged.

@divyenpatel
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jul 11, 2024
@divyenpatel
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 228efdb into kubernetes-sigs:master Jul 11, 2024
12 checks passed
adikul30 added a commit to adikul30/vsphere-csi-driver that referenced this pull request Jul 11, 2024
@adikul30
rm listview feature gate (kubernetes-sigs#2851)
2b2d77e
@adikul30 adikul30 mentioned this pull request Jul 11, 2024
Merged
k8s-ci-robot pushed a commit that referenced this pull request Jul 11, 2024
@adikul30
Cherry-pick session cleanup changes for release-3.3 (#2951)
5386268 
* attempt to logout and clear idle sessions before creating new one (#2930)

* Use client-go package for leaderelection to add cleanup logic after leader change (#2948)

* rm listview feature gate (#2851)

* Create tag for v3.3.1-rc.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chethanv28 chethanv28 Awaiting requested review from chethanv28

@shalini-b shalini-b Awaiting requested review from shalini-b

Assignees

@divyenpatel divyenpatel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-3.3.1-candiate size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adikul30 @k8s-ci-robot @divyenpatel