Add volume capabilities validation in Vanilla Create Volume Request #459

chethanv28 · 2020-10-22T21:04:20Z

What this PR does / why we need it:
This PR is adding a validation for create block volume request to avoid incorrect (SC - fstype : PVC- AccessMode) combination used in volume creation
For ex: Creating a block volume with fstype: nfs or nfs4

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

root@k8s-master:~# cat sc.yaml 
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: sc
  annotations:
    storageclass.kubernetes.io/is-default-class: "false"
provisioner: csi.vsphere.vmware.com
parameters:
  storagepolicyname: "vSAN Default Storage Policy"  # Optional Parameter
  csi.storage.k8s.io/fstype: "nfs4"            <<<<<<<<============


root@k8s-master:~# cat pvc-test.yaml 
kind: PersistentVolumeClaim
apiVersion: v1
metadata:
  name: pvc-test
spec:
  accessModes:
    - ReadWriteOnce                   <<<<<<<<============
  resources:
    requests:
      storage: 1Mi
  storageClassName: sc

# kubectl get pvc -A
NAMESPACE   NAME         STATUS    VOLUME                                     CAPACITY   ACCESS MODES   STORAGECLASS   AGE
default     pvc-test     Pending                                                                        sc             8s

root@k8s-master:~# kubectl describe pvc pvc-test
Name:          pvc-test
Namespace:     default
StorageClass:  sc
Status:        Pending
Volume:        
Labels:        <none>
Annotations:   volume.beta.kubernetes.io/storage-provisioner: csi.vsphere.vmware.com
Finalizers:    [kubernetes.io/pvc-protection]
Capacity:      
Access Modes:  
VolumeMode:    Filesystem
Mounted By:    <none>
Events:
  Type     Reason                Age                    From                                                                                                 Message
  ----     ------                ----                   ----                                                                                                 -------
  Normal   ExternalProvisioning  4m27s (x102 over 29m)  persistentvolume-controller                                                                          waiting for a volume to be created, either by external provisioner "csi.vsphere.vmware.com" or manually created by system administrator
  Normal   Provisioning          70s (x14 over 29m)     csi.vsphere.vmware.com_vsphere-csi-controller-8496dc54c9-xkczs_ee5f6153-e388-45e6-965c-ca1035e6f40b  External provisioner is provisioning volume for claim "default/example-vanilla-block-pvc"
  Warning  ProvisioningFailed    70s (x14 over 29m)     csi.vsphere.vmware.com_vsphere-csi-controller-8496dc54c9-xkczs_ee5f6153-e388-45e6-965c-ca1035e6f40b  failed to provision volume with StorageClass "example-vanilla-file-sc": rpc error: code = InvalidArgument desc = Volume capability not supported. Err: NFS fstype not supported for ReadWriteOnce volume creation

Release note:

Validate access mode and fstype for CreateVolume workflow

chethanv28 · 2020-10-22T21:05:59Z

Make check:

$ make check
hack/check-format.sh
go: finding golang.org/x/tools latest
go: downloading golang.org/x/tools v0.0.0-20201022035929-9cf592e881e9
go: extracting golang.org/x/tools v0.0.0-20201022035929-9cf592e881e9
hack/check-lint.sh
go: finding golang.org/x/lint latest

hack/check-shell.sh
hack/check-staticcheck.sh
hack/check-vet.sh
docker run --rm -v /Users/chethanv/Downloads/csi-external/vsphere-csi-driver:/app -w /app golangci/golangci-lint:v1.28.3 golangci-lint run -v  --timeout=1200s
Unable to find image 'golangci/golangci-lint:v1.28.3' locally
v1.28.3: Pulling from golangci/golangci-lint
e9afc4f90ab0: Pull complete 
989e6b19a265: Pull complete 
af14b6c2f878: Pull complete 
5573c4b30949: Pull complete 
d4020e2aa747: Pull complete 
90833167b3a6: Pull complete 
56c4bef2c0bb: Pull complete 
f1f854810281: Pull complete 
Digest: sha256:cdc34420777786f5c3fbd9e551f674df00ead33e2d4972c2968da7c645e4c7d4
Status: Downloaded newer image for golangci/golangci-lint:v1.28.3
level=info msg="[config_reader] Config search paths: [./ /app /]"
level=info msg="[lintersdb] Active 10 linters: [deadcode errcheck gosimple govet ineffassign staticcheck structcheck typecheck unused varcheck]"
level=info msg="[loader] Go packages loading at mode 575 (deps|exports_file|name|compiled_files|files|imports|types_sizes) took 2m27.3725277s"
level=info msg="[runner/filename_unadjuster] Pre-built 0 adjustments in 299.3719ms"
level=info msg="[linters context/goanalysis] analyzers took 2m20.4817903s with top 10 stages: buildir: 2m2.5880654s, inspect: 4.5313999s, fact_deprecated: 2.159747s, ctrlflow: 1.8211266s, printf: 1.7329128s, fact_purity: 1.4575682s, ineffassign: 1.4333503s, isgenerated: 888.1744ms, S1038: 213.9082ms, errcheck: 204.0227ms"
level=info msg="[linters context/goanalysis] analyzers took 10.8285405s with top 10 stages: buildir: 10.2047558s, U1000: 623.7847ms"
level=info msg="[runner] Issues before processing: 70, after processing: 0"
level=info msg="[runner] Processors filtering stat (out/in): identifier_marker: 12/12, skip_files: 70/70, autogenerated_exclude: 12/70, cgo: 70/70, filename_unadjuster: 70/70, path_prettifier: 70/70, skip_dirs: 70/70, exclude: 0/12"
level=info msg="[runner] processing took 59.7952ms with stages: autogenerated_exclude: 31.3363ms, path_prettifier: 23.7134ms, skip_dirs: 2.1893ms, identifier_marker: 1.867ms, exclude: 458.4µs, cgo: 24.7µs, nolint: 17.3µs, max_same_issues: 16.9µs, skip_files: 16.4µs, uniq_by_line: 15.9µs, max_from_linter: 15.8µs, path_shortener: 15.7µs, diff: 15.6µs, source_code: 15.6µs, severity-rules: 15.5µs, exclude-rules: 15.4µs, filename_unadjuster: 15.4µs, max_per_file_from_linter: 15.3µs, path_prefixer: 15.3µs"
level=info msg="[runner] linters took 48.1943339s with stages: goanalysis_metalinter: 43.0510186s, unused: 5.0826273s"
level=info msg="File cache stats: 0 entries of total size 0B"
level=info msg="Memory: 1863 samples, avg is 243.1MB, max is 1221.4MB"
level=info msg="Execution took 3m15.9063202s"

Unit tests:


$ make unit-test
env -u VSPHERE_SERVER -u VSPHERE_DATACENTER -u VSPHERE_PASSWORD -u VSPHERE_USER -u VSPHERE_STORAGE_POLICY_NAME -u KUBECONFIG -u WCP_ENDPOINT -u WCP_PORT -u WCP_NAMESPACE -u TOKEN -u CERTIFICATE go test -v -count=1 -coverprofile coverage_report.out ./pkg/common/config ./pkg/csi/service ./pkg/csi/service/common ./pkg/csi/service/common/commonco/k8sorchestrator ./pkg/csi/service/vanilla ./pkg/csi/service/wcp ./pkg/csi/service/wcpguest ./pkg/syncer ./pkg/syncer/admissionhandler
=== RUN   TestValidateConfigWithNoNetPermissionParams
{"level":"info","time":"2020-10-22T13:37:37.48843-07:00","caller":"config/config.go:296","msg":"No Net Permissions given in Config. Using default permissions."}
{"level":"info","time":"2020-10-22T13:37:37.488768-07:00","caller":"config/config.go:328","msg":"No feature states config information is provided in the Config. Using default config map name: internal-feature-states.csi.vsphere.vmware.com and namespace: kube-system"}
--- PASS: TestValidateConfigWithNoNetPermissionParams (0.00s)
=== RUN   TestValidateConfigWithMultipleNetPermissionParams
{"level":"info","time":"2020-10-22T13:37:37.488948-07:00","caller":"config/config.go:328","msg":"No feature states config information is provided in the Config. Using default config map name: internal-feature-states.csi.vsphere.vmware.com and namespace: kube-system"}
--- PASS: TestValidateConfigWithMultipleNetPermissionParams (0.00s)
=== RUN   TestValidateConfigWithInvalidPermissions
{"level":"error","time":"2020-10-22T13:37:37.489671-07:00","caller":"config/config.go:305","msg":"Invalid value WRITE_ONLY for Permissions under NetPermission Config A","stacktrace":"sigs.k8s.io/vsphere-csi-driver/pkg/common/config.validateConfig\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/common/config/config.go:305\nsigs.k8s.io/vsphere-csi-driver/pkg/common/config.TestValidateConfigWithInvalidPermissions\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/common/config/config_test.go:143\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:909"}
--- PASS: TestValidateConfigWithInvalidPermissions (0.00s)
=== RUN   TestValidateConfigWithInvalidClusterId
{"level":"error","time":"2020-10-22T13:37:37.490003-07:00","caller":"config/config.go:257","msg":"cluster id must not exceed 64 characters","stacktrace":"sigs.k8s.io/vsphere-csi-driver/pkg/common/config.validateConfig\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/common/config/config.go:257\nsigs.k8s.io/vsphere-csi-driver/pkg/common/config.TestValidateConfigWithInvalidClusterId\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/common/config/config_test.go:155\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:909"}
--- PASS: TestValidateConfigWithInvalidClusterId (0.00s)
PASS
coverage: 19.4% of statements
ok      sigs.k8s.io/vsphere-csi-driver/pkg/common/config        0.029s  coverage: 19.4% of statements
=== RUN   TestGetDisk
=== RUN   TestGetDisk/#00
=== PAUSE TestGetDisk/#00
=== RUN   TestGetDisk/#01
=== PAUSE TestGetDisk/#01
=== CONT  TestGetDisk/#00
=== CONT  TestGetDisk/#01
--- PASS: TestGetDisk (0.00s)
    --- PASS: TestGetDisk/#00 (0.00s)
    --- PASS: TestGetDisk/#01 (0.00s)
PASS
coverage: 1.8% of statements
ok      sigs.k8s.io/vsphere-csi-driver/pkg/csi/service  0.063s  coverage: 1.8% of statements
=== RUN   TestIsFileVolumeRequestForBlock
--- PASS: TestIsFileVolumeRequestForBlock (0.00s)
=== RUN   TestIsFileVolumeRequestForBlockWithUnsetFsType
--- PASS: TestIsFileVolumeRequestForBlockWithUnsetFsType (0.00s)
=== RUN   TestIsFileVolumeRequestForFile
--- PASS: TestIsFileVolumeRequestForFile (0.00s)
=== RUN   TestValidVolumeCapabilitiesForBlock
--- PASS: TestValidVolumeCapabilitiesForBlock (0.00s)
=== RUN   TestInvalidVolumeCapabilitiesForBlock
--- PASS: TestInvalidVolumeCapabilitiesForBlock (0.00s)
=== RUN   TestValidVolumeCapabilitiesForFile
--- PASS: TestValidVolumeCapabilitiesForFile (0.00s)
=== RUN   TestInvalidVolumeCapabilitiesForFile
--- PASS: TestInvalidVolumeCapabilitiesForFile (0.00s)
=== RUN   TestParseStorageClassParamsWithDeprecatedFSType
{"level":"warn","time":"2020-10-22T13:37:44.260261-07:00","caller":"common/util.go:216","msg":"param 'fstype' is deprecated, please use 'csi.storage.k8s.io/fstype' instead"}
--- PASS: TestParseStorageClassParamsWithDeprecatedFSType (0.00s)
=== RUN   TestParseStorageClassParamsWithValidParams
--- PASS: TestParseStorageClassParamsWithValidParams (0.00s)
=== RUN   TestParseStorageClassParamsWithMigrationEnabledNagative
--- PASS: TestParseStorageClassParamsWithMigrationEnabledNagative (0.00s)
    util_test.go:324: expected err received. err: vSphere CSI driver does not support creating volume using in-tree vSphere volume plugin parameter key:objectspacereservation-migrationparam, value:50
=== RUN   TestParseStorageClassParamsWithDiskFormatMigrationEnableNegative
--- PASS: TestParseStorageClassParamsWithDiskFormatMigrationEnableNegative (0.00s)
    util_test.go:337: expected err received. err: invalid parameter. key:diskformat-migrationparam, value:thick
=== RUN   TestParseStorageClassParamsWithDiskFormatMigrationEnablePositive
--- PASS: TestParseStorageClassParamsWithDiskFormatMigrationEnablePositive (0.00s)
=== RUN   TestParseStorageClassParamsWithMigrationEnabledPositive
--- PASS: TestParseStorageClassParamsWithMigrationEnabledPositive (0.00s)
=== RUN   TestParseStorageClassParamsWithMigrationDisabled
--- PASS: TestParseStorageClassParamsWithMigrationDisabled (0.00s)
    util_test.go:391: expected err received. err: Invalid param: "hostfailurestotolerate-migrationparam" and value: "1"
PASS
coverage: 8.3% of statements
ok      sigs.k8s.io/vsphere-csi-driver/pkg/csi/service/common   0.044s  coverage: 8.3% of statements
=== RUN   TestIsFSSEnabledInGcWithSync
{"level":"info","time":"2020-10-22T13:37:50.387301-07:00","caller":"k8sorchestrator/k8sorchestrator.go:322","msg":"volume-health feature state set to false in internal-feature-states.csi.vsphere.vmware.com ConfigMap"}
--- PASS: TestIsFSSEnabledInGcWithSync (0.00s)
=== RUN   TestIsFSSEnabledInGcWithoutSync
{"level":"info","time":"2020-10-22T13:37:50.387594-07:00","caller":"k8sorchestrator/k8sorchestrator.go:322","msg":"volume-extend feature state set to false in internal-feature-states.csi.vsphere.vmware.com ConfigMap"}
{"level":"info","time":"2020-10-22T13:37:50.38786-07:00","caller":"k8sorchestrator/k8sorchestrator.go:338","msg":"volume-health feature state set to false in csi-feature-states ConfigMap"}
--- PASS: TestIsFSSEnabledInGcWithoutSync (0.00s)
=== RUN   TestIsFSSEnabledInGcWrongValues
{"level":"error","time":"2020-10-22T13:37:50.388027-07:00","caller":"k8sorchestrator/k8sorchestrator.go:317","msg":"Error while converting volume-extend feature state value: false to boolean. Setting the feature state to false","stacktrace":"sigs.k8s.io/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator.(*K8sOrchestrator).IsFSSEnabled\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator.go:317\nsigs.k8s.io/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator.TestIsFSSEnabledInGcWrongValues\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator_test.go:140\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:909"}
--- PASS: TestIsFSSEnabledInGcWrongValues (0.00s)
=== RUN   TestIsFSSEnabledInSV
{"level":"error","time":"2020-10-22T13:37:50.38841-07:00","caller":"k8sorchestrator/k8sorchestrator.go:305","msg":"Error while converting csi-migration feature state value: false to boolean. Setting the feature state to false","stacktrace":"sigs.k8s.io/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator.(*K8sOrchestrator).IsFSSEnabled\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator.go:305\nsigs.k8s.io/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator.TestIsFSSEnabledInSV\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator_test.go:176\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:909"}
--- PASS: TestIsFSSEnabledInSV (0.00s)
=== RUN   TestIsFSSEnabledInVanilla
{"level":"error","time":"2020-10-22T13:37:50.38927-07:00","caller":"k8sorchestrator/k8sorchestrator.go:293","msg":"Error while converting volume-health feature state value: false to boolean. Setting the feature state to false","stacktrace":"sigs.k8s.io/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator.(*K8sOrchestrator).IsFSSEnabled\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator.go:293\nsigs.k8s.io/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator.TestIsFSSEnabledInVanilla\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator/k8sorchestrator_test.go:214\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:909"}
--- PASS: TestIsFSSEnabledInVanilla (0.00s)
=== RUN   TestIsFSSEnabledWithWrongClusterFlavor
--- PASS: TestIsFSSEnabledWithWrongClusterFlavor (0.00s)
PASS
coverage: 25.8% of statements
ok      sigs.k8s.io/vsphere-csi-driver/pkg/csi/service/common/commonco/k8sorchestrator  0.081s  coverage: 25.8% of statements
=== RUN   TestCreateVolumeWithStoragePolicy
{"level":"error","time":"2020-10-22T13:37:50.767163-07:00","caller":"config/config.go:252","msg":"no Virtual Center hosts defined","stacktrace":"sigs.k8s.io/vsphere-csi-driver/pkg/common/config.validateConfig\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/common/config/config.go:252\nsigs.k8s.io/vsphere-csi-driver/pkg/common/config.FromEnv\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/common/config/config.go:236\nsigs.k8s.io/vsphere-csi-driver/pkg/csi/service/vanilla.configFromEnvOrSim\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/vanilla/controller_test.go:142\nsigs.k8s.io/vsphere-csi-driver/pkg/csi/service/vanilla.getControllerTest.func1\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/vanilla/controller_test.go:246\nsync.(*Once).doSlow\n\t/usr/local/go/src/sync/once.go:66\nsync.(*Once).Do\n\t/usr/local/go/src/sync/once.go:57\nsigs.k8s.io/vsphere-csi-driver/pkg/csi/service/vanilla.getControllerTest\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/vanilla/controller_test.go:243\nsigs.k8s.io/vsphere-csi-driver/pkg/csi/service/vanilla.TestCreateVolumeWithStoragePolicy\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/vanilla/controller_test.go:317\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:909"}
{"level":"info","time":"2020-10-22T13:37:50.812524-07:00","caller":"vsphere/utils.go:126","msg":"Defaulting timeout for vCenter Client to 5 minutes"}
{"level":"info","time":"2020-10-22T13:37:50.812685-07:00","caller":"vsphere/virtualcentermanager.go:64","msg":"Initializing defaultVirtualCenterManager..."}
{"level":"info","time":"2020-10-22T13:37:50.812707-07:00","caller":"vsphere/virtualcentermanager.go:66","msg":"Successfully initialized defaultVirtualCenterManager"}
{"level":"info","time":"2020-10-22T13:37:50.812859-07:00","caller":"vsphere/virtualcentermanager.go:110","msg":"Successfully registered VC \"127.0.0.1\""}
{"level":"info","time":"2020-10-22T13:37:50.82126-07:00","caller":"vsphere/virtualcenter.go:153","msg":"New session ID for 'user' = 312897ae-5df1-4a05-bf79-48276169fff1"}
{"level":"info","time":"2020-10-22T13:37:50.82159-07:00","caller":"volume/manager.go:100","msg":"Initializing new volume.defaultManager..."}
{"level":"info","time":"2020-10-22T13:37:50.822398-07:00","caller":"vanilla/controller.go:544","msg":"CreateVolume: called with args {Name:test-pvc-68b580e9-17d2-4dbb-86a1-45716a6eb6fd CapacityRange:required_bytes:1073741824  VolumeCapabilities:[access_mode:<mode:SINGLE_NODE_WRITER > ] Parameters:map[storagepolicyname:vSAN Default Storage Policy] Secrets:map[] VolumeContentSource:<nil> AccessibilityRequirements:<nil> XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}","TraceId":"314ea875-fce3-42ec-b5b4-4bd35c0e1e9b"}
{"level":"info","time":"2020-10-22T13:37:50.837215-07:00","caller":"volume/manager.go:215","msg":"CreateVolume: VolumeName: \"test-pvc-68b580e9-17d2-4dbb-86a1-45716a6eb6fd\", opId: \"\"","TraceId":"314ea875-fce3-42ec-b5b4-4bd35c0e1e9b"}
{"level":"info","time":"2020-10-22T13:37:50.837251-07:00","caller":"volume/manager.go:263","msg":"CreateVolume: Volume created successfully. VolumeName: \"test-pvc-68b580e9-17d2-4dbb-86a1-45716a6eb6fd\", opId: \"\", volumeID: \"9e8f6a24-231c-4ac2-9fe9-7f3b4b4987b0\"","TraceId":"314ea875-fce3-42ec-b5b4-4bd35c0e1e9b"}
{"level":"info","time":"2020-10-22T13:37:50.843115-07:00","caller":"vanilla/controller.go:570","msg":"DeleteVolume: called with args: {VolumeId:9e8f6a24-231c-4ac2-9fe9-7f3b4b4987b0 Secrets:map[] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}","TraceId":"9af074f8-ef5f-449b-afa9-8e43667775e1"}
{"level":"info","time":"2020-10-22T13:37:50.846479-07:00","caller":"volume/manager.go:463","msg":"DeleteVolume: volumeID: \"9e8f6a24-231c-4ac2-9fe9-7f3b4b4987b0\", opId: \"\"","TraceId":"9af074f8-ef5f-449b-afa9-8e43667775e1"}
{"level":"info","time":"2020-10-22T13:37:50.846528-07:00","caller":"volume/manager.go:481","msg":"DeleteVolume: Volume deleted successfully. volumeID: \"9e8f6a24-231c-4ac2-9fe9-7f3b4b4987b0\", opId: \"\"","TraceId":"9af074f8-ef5f-449b-afa9-8e43667775e1"}
--- PASS: TestCreateVolumeWithStoragePolicy (0.08s)
=== RUN   TestCreateVolumeWithMultipleDatastores
{"level":"info","time":"2020-10-22T13:37:50.8478-07:00","caller":"vanilla/controller.go:544","msg":"CreateVolume: called with args {Name:test-pvc-42212330-68fd-4d0c-9c84-aa93be31b76c CapacityRange:required_bytes:1073741824  VolumeCapabilities:[access_mode:<mode:SINGLE_NODE_WRITER > ] Parameters:map[] Secrets:map[] VolumeContentSource:<nil> AccessibilityRequirements:<nil> XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}","TraceId":"02aeca9d-2c46-4347-a0be-23f28775b776"}
{"level":"info","time":"2020-10-22T13:37:50.856715-07:00","caller":"volume/manager.go:215","msg":"CreateVolume: VolumeName: \"test-pvc-42212330-68fd-4d0c-9c84-aa93be31b76c\", opId: \"\"","TraceId":"02aeca9d-2c46-4347-a0be-23f28775b776"}
{"level":"info","time":"2020-10-22T13:37:50.856754-07:00","caller":"volume/manager.go:263","msg":"CreateVolume: Volume created successfully. VolumeName: \"test-pvc-42212330-68fd-4d0c-9c84-aa93be31b76c\", opId: \"\", volumeID: \"55bf66c9-5b18-41c0-a757-adcea4623895\"","TraceId":"02aeca9d-2c46-4347-a0be-23f28775b776"}
{"level":"info","time":"2020-10-22T13:37:50.857453-07:00","caller":"vanilla/controller.go:570","msg":"DeleteVolume: called with args: {VolumeId:55bf66c9-5b18-41c0-a757-adcea4623895 Secrets:map[] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}","TraceId":"37af0856-8f41-4511-acfc-eaaa1d120aab"}
{"level":"info","time":"2020-10-22T13:37:50.860419-07:00","caller":"volume/manager.go:463","msg":"DeleteVolume: volumeID: \"55bf66c9-5b18-41c0-a757-adcea4623895\", opId: \"\"","TraceId":"37af0856-8f41-4511-acfc-eaaa1d120aab"}
{"level":"info","time":"2020-10-22T13:37:50.860449-07:00","caller":"volume/manager.go:481","msg":"DeleteVolume: Volume deleted successfully. volumeID: \"55bf66c9-5b18-41c0-a757-adcea4623895\", opId: \"\"","TraceId":"37af0856-8f41-4511-acfc-eaaa1d120aab"}
--- PASS: TestCreateVolumeWithMultipleDatastores (0.01s)
=== RUN   TestExtendVolume
{"level":"info","time":"2020-10-22T13:37:50.861283-07:00","caller":"vanilla/controller.go:544","msg":"CreateVolume: called with args {Name:test-pvc-1c666f0b-d090-44a1-8490-9062a156874c CapacityRange:required_bytes:1073741824  VolumeCapabilities:[access_mode:<mode:SINGLE_NODE_WRITER > ] Parameters:map[] Secrets:map[] VolumeContentSource:<nil> AccessibilityRequirements:<nil> XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}","TraceId":"fa13f7d4-4bad-441b-b6a2-c2846c658b2a"}
{"level":"info","time":"2020-10-22T13:37:50.87035-07:00","caller":"volume/manager.go:215","msg":"CreateVolume: VolumeName: \"test-pvc-1c666f0b-d090-44a1-8490-9062a156874c\", opId: \"\"","TraceId":"fa13f7d4-4bad-441b-b6a2-c2846c658b2a"}
{"level":"info","time":"2020-10-22T13:37:50.870391-07:00","caller":"volume/manager.go:263","msg":"CreateVolume: Volume created successfully. VolumeName: \"test-pvc-1c666f0b-d090-44a1-8490-9062a156874c\", opId: \"\", volumeID: \"8983a450-abc5-493b-b450-fe4602239a44\"","TraceId":"fa13f7d4-4bad-441b-b6a2-c2846c658b2a"}
{"level":"info","time":"2020-10-22T13:37:50.872421-07:00","caller":"vanilla/controller.go:803","msg":"ControllerExpandVolume: called with args {VolumeId:8983a450-abc5-493b-b450-fe4602239a44 CapacityRange:required_bytes:2147483648  Secrets:map[] VolumeCapability:access_mode:<mode:SINGLE_NODE_WRITER >  XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}","TraceId":"ffb7df8f-4702-47c4-8532-fbf5a82143fe"}
{"level":"info","time":"2020-10-22T13:37:50.872449-07:00","caller":"node/manager.go:75","msg":"Initializing node.defaultManager...","TraceId":"ffb7df8f-4702-47c4-8532-fbf5a82143fe"}
{"level":"info","time":"2020-10-22T13:37:50.872461-07:00","caller":"node/manager.go:79","msg":"node.defaultManager initialized","TraceId":"ffb7df8f-4702-47c4-8532-fbf5a82143fe"}
{"level":"info","time":"2020-10-22T13:37:50.873528-07:00","caller":"common/vsphereutil.go:397","msg":"Requested size 2048 Mb is greater than current size for volumeID: \"8983a450-abc5-493b-b450-fe4602239a44\". Need volume expansion.","TraceId":"ffb7df8f-4702-47c4-8532-fbf5a82143fe"}
{"level":"info","time":"2020-10-22T13:37:50.874044-07:00","caller":"volume/manager.go:573","msg":"Calling CnsClient.ExtendVolume: VolumeID [\"8983a450-abc5-493b-b450-fe4602239a44\"] Size [2048] cnsExtendSpecList [[]types.CnsVolumeExtendSpec{types.CnsVolumeExtendSpec{DynamicData:types.DynamicData{}, VolumeId:types.CnsVolumeId{DynamicData:types.DynamicData{}, Id:\"8983a450-abc5-493b-b450-fe4602239a44\"}, CapacityInMb:2048}}]","TraceId":"ffb7df8f-4702-47c4-8532-fbf5a82143fe"}
{"level":"info","time":"2020-10-22T13:37:50.876433-07:00","caller":"volume/manager.go:589","msg":"ExpandVolume: volumeID: \"8983a450-abc5-493b-b450-fe4602239a44\", opId: \"\"","TraceId":"ffb7df8f-4702-47c4-8532-fbf5a82143fe"}
{"level":"info","time":"2020-10-22T13:37:50.876454-07:00","caller":"volume/manager.go:607","msg":"ExpandVolume: Volume expanded successfully. volumeID: \"8983a450-abc5-493b-b450-fe4602239a44\", opId: \"\"","TraceId":"ffb7df8f-4702-47c4-8532-fbf5a82143fe"}
{"level":"info","time":"2020-10-22T13:37:50.876467-07:00","caller":"common/vsphereutil.go:403","msg":"Successfully expanded volume for volumeid \"8983a450-abc5-493b-b450-fe4602239a44\" to new size 2048 Mb.","TraceId":"ffb7df8f-4702-47c4-8532-fbf5a82143fe"}
{"level":"info","time":"2020-10-22T13:37:50.877159-07:00","caller":"vanilla/controller.go:570","msg":"DeleteVolume: called with args: {VolumeId:8983a450-abc5-493b-b450-fe4602239a44 Secrets:map[] XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}","TraceId":"cf304f20-75bd-4f6f-b1ed-658cc849adc7"}
{"level":"info","time":"2020-10-22T13:37:50.879475-07:00","caller":"volume/manager.go:463","msg":"DeleteVolume: volumeID: \"8983a450-abc5-493b-b450-fe4602239a44\", opId: \"\"","TraceId":"cf304f20-75bd-4f6f-b1ed-658cc849adc7"}
{"level":"info","time":"2020-10-22T13:37:50.879494-07:00","caller":"volume/manager.go:481","msg":"DeleteVolume: Volume deleted successfully. volumeID: \"8983a450-abc5-493b-b450-fe4602239a44\", opId: \"\"","TraceId":"cf304f20-75bd-4f6f-b1ed-658cc849adc7"}
--- PASS: TestExtendVolume (0.02s)
    controller_test.go:566: ControllerExpandVolume will be called with req +{8983a450-abc5-493b-b450-fe4602239a44 required_bytes:2147483648  map[] access_mode:<mode:SINGLE_NODE_WRITER >  {} [] 0}
    controller_test.go:574: ControllerExpandVolume succeeded: volume is expanded to requested size 2147483648
=== RUN   TestMigratedExtendVolume
{"level":"info","time":"2020-10-22T13:37:50.880278-07:00","caller":"vanilla/controller.go:803","msg":"ControllerExpandVolume: called with args {VolumeId:[vsanDatastore] 08281a5f-a21d-1eff-62d6-02009d0f19a1/004dbb1694f14e3598abef852b113e3b.vmdk CapacityRange:required_bytes:1024  Secrets:map[] VolumeCapability:<nil> XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}","TraceId":"adb17256-b6c9-485d-82dc-1a835bbb905f"}
{"level":"error","time":"2020-10-22T13:37:50.880306-07:00","caller":"vanilla/controller.go:807","msg":"Cannot expand migrated vSphere volume. :\"[vsanDatastore] 08281a5f-a21d-1eff-62d6-02009d0f19a1/004dbb1694f14e3598abef852b113e3b.vmdk\"","TraceId":"adb17256-b6c9-485d-82dc-1a835bbb905f","stacktrace":"sigs.k8s.io/vsphere-csi-driver/pkg/csi/service/vanilla.(*controller).ControllerExpandVolume\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/vanilla/controller.go:807\nsigs.k8s.io/vsphere-csi-driver/pkg/csi/service/vanilla.TestMigratedExtendVolume\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/csi/service/vanilla/controller_test.go:623\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:909"}
--- PASS: TestMigratedExtendVolume (0.00s)
    controller_test.go:622: ControllerExpandVolume will be called with req +{[vsanDatastore] 08281a5f-a21d-1eff-62d6-02009d0f19a1/004dbb1694f14e3598abef852b113e3b.vmdk required_bytes:1024  map[] <nil> {} [] 0}
    controller_test.go:625: Expected error received. migrated volume with VMDK path can not be expanded
=== RUN   TestCompleteControllerFlow
{"level":"info","time":"2020-10-22T13:37:50.881048-07:00","caller":"vanilla/controller.go:544","msg":"CreateVolume: called with args {Name:test-pvc-658f6f6e-782e-4241-974d-dd556041065d CapacityRange:required_bytes:1073741824  VolumeCapabilities:[access_mode:<mode:SINGLE_NODE_WRITER > ] Parameters:map[] Secrets:map[] VolumeContentSource:<nil> AccessibilityRequirements:<nil> XXX_NoUnkeyedLiteral:{} XXX_unrecognized:[] XXX_sizecache:0}","TraceId":"ae29cfdc-02a9-447a-a6b5-d49eaa1ac4f9"}
{"level":"info","time":"2020-10-22T13:37:50.888179-07:00","caller":"volume/manager.go:215","msg":"CreateVolume: VolumeName: \"test-pvc-658f6f6e-782e-4241-974d-dd556041065d\", opId: \"\"","TraceId":"ae29cfdc-02a9-447a-a6b5-d49eaa1ac4f9"}
...
...
07:00","caller":"admissionhandler/validatestorageclass.go:75","msg":"Validating StorageClass: \"sc\""}
{"level":"error","time":"2020-10-22T13:37:50.398325-07:00","caller":"admissionhandler/validatestorageclass.go:99","msg":"validation of StorageClass: \"sc\" Failed","stacktrace":"sigs.k8s.io/vsphere-csi-driver/pkg/syncer/admissionhandler.validateStorageClass\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/syncer/admissionhandler/validatestorageclass.go:99\nsigs.k8s.io/vsphere-csi-driver/pkg/syncer/admissionhandler.TestValidateStorageClassForMigrationParameter\n\t/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/pkg/syncer/admissionhandler/validatestorageclass_test.go:60\ntesting.tRunner\n\t/usr/local/go/src/testing/testing.go:909"}
--- PASS: TestValidateStorageClassForMigrationParameter (0.00s)
    validatestorageclass_test.go:64: TestValidateStorageClassForMigrationParameter Passed
=== RUN   TestValidateStorageClassForValidStorageClass
{"level":"info","time":"2020-10-22T13:37:50.398508-07:00","caller":"admissionhandler/validatestorageclass.go:75","msg":"Validating StorageClass: \"sc\""}
{"level":"info","time":"2020-10-22T13:37:50.398527-07:00","caller":"admissionhandler/validatestorageclass.go:97","msg":"Validation of StorageClass: \"sc\" Passed"}
--- PASS: TestValidateStorageClassForValidStorageClass (0.00s)
    validatestorageclass_test.go:79: TestValidateStorageClassForValidStorageClass Passed
PASS
coverage: 14.6% of statements
ok      sigs.k8s.io/vsphere-csi-driver/pkg/syncer/admissionhandler      0.137s  coverage: 14.6% of statements

pkg/csi/service/vanilla/controller.go

divyenpatel

/approve

pkg/csi/service/common/util.go

chethanv28 · 2020-10-29T05:02:21Z

jtest file-vanilla

svcbot-qecnsdp · 2020-10-29T05:04:57Z

Started vanilla file pipeline...

pkg/csi/service/common/util.go

SandeepPissay · 2020-10-29T06:16:23Z

LGTM. Lets wait for successful vanilla test results.

/approve

k8s-ci-robot · 2020-10-29T06:16:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chethanv28, divyenpatel, SandeepPissay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [SandeepPissay,chethanv28,divyenpatel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chethanv28 · 2020-10-29T06:18:56Z

jtest file-vanilla

svcbot-qecnsdp · 2020-10-29T06:22:45Z

Started vanilla file pipeline...

svcbot-qecnsdp · 2020-10-29T07:37:20Z

File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 24 of 149 Specs in 2364.605 seconds
FAIL! -- 23 Passed | 1 Failed | 0 Pending | 125 Skipped
--- FAIL: TestE2E (2364.63s)
FAIL

Ginkgo ran 1 suite in 39m47.347217225s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/github-csi-file-vanilla/Results/96/vsphere-csi-driver`

svcbot-qecnsdp · 2020-10-29T09:49:37Z

File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 24 of 149 Specs in 5563.876 seconds
FAIL! -- 18 Passed | 6 Failed | 0 Pending | 125 Skipped
--- FAIL: TestE2E (5563.90s)
FAIL

Ginkgo ran 1 suite in 1h33m6.578469046s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/github-csi-file-vanilla@2/Results/97/vsphere-csi-driver`

svcbot-qecnsdp · 2020-10-29T14:15:00Z

Started vanilla file pipeline...

svcbot-qecnsdp · 2020-10-29T14:21:00Z

File vanilla build status: FAILURE 
Stage before exit: Parallel `images` block

svcbot-qecnsdp · 2020-10-29T14:40:06Z

Started vanilla file pipeline...

svcbot-qecnsdp · 2020-10-29T17:06:49Z

File vanilla build status: FAILURE 
Stage before exit: e2e-tests

svcbot-qecnsdp · 2020-10-29T17:25:33Z

Started vanilla file pipeline...

svcbot-qecnsdp · 2020-10-29T17:30:52Z

File vanilla build status: FAILURE 
Stage before exit: Parallel `images` block

svcbot-qecnsdp · 2020-10-29T18:10:25Z

Started vanilla file pipeline...

svcbot-qecnsdp · 2020-10-29T20:18:13Z

File vanilla build status: FAILURE 
Stage before exit: e2e-tests

svcbot-qecnsdp · 2020-10-29T20:36:19Z

Started vanilla file pipeline...

svcbot-qecnsdp · 2020-10-29T20:36:24Z

File vanilla build status: FAILURE 
Stage before exit: testbed-deploy

svcbot-qecnsdp · 2020-10-29T20:37:27Z

Started vanilla file pipeline...

svcbot-qecnsdp · 2020-10-29T20:37:31Z

File vanilla build status: FAILURE 
Stage before exit: testbed-deploy

svcbot-qecnsdp · 2020-10-29T20:39:29Z

Started vanilla file pipeline...

svcbot-qecnsdp · 2020-10-29T20:39:35Z

File vanilla build status: FAILURE 
Stage before exit: testbed-deploy

svcbot-qecnsdp · 2020-10-29T20:58:39Z

Started vanilla file pipeline...

svcbot-qecnsdp · 2020-10-29T21:07:04Z

File vanilla build status: FAILURE 
Stage before exit: testbed-deploy

chethanv28 · 2020-10-29T21:38:22Z

File vanilla build status: FAILURE 
Stage before exit: e2e-tests 
Jenkins E2E Test Results: 
Ran 24 of 149 Specs in 2364.605 seconds
FAIL! -- 23 Passed | 1 Failed | 0 Pending | 125 Skipped
--- FAIL: TestE2E (2364.63s)
FAIL

Ginkgo ran 1 suite in 39m47.347217225s
Test Suite Failed
make: Leaving directory `/home/worker/workspace/github-csi-file-vanilla/Results/96/vsphere-csi-driver`

1 test failed because the test expects a generic error message. I have changed the test case to expect the exact error message reran the failed e2e test:

$ time make test-e2e
hack/run-e2e-test.sh
go: finding golang.org/x/sys latest
go: finding gopkg.in/tomb.v1 latest
Oct 29 14:36:15.027: INFO: The --provider flag is not set. Continuing as if --provider=skeleton had been used.
W1029 14:36:15.026967   32651 test_context.go:414] Unable to find in-cluster config, using default host : http://127.0.0.1:8080
I1029 14:36:15.027109   32651 test_context.go:423] Tolerating taints "" when considering if nodes are ready
Running Suite: CNS CSI Driver End-to-End Tests
==============================================
Random Seed: 1604007366 - Will randomize all specs
Will run 1 of 149 specs

SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
------------------------------
[csi-file-vanilla] Basic Testing 
  [csi-file-vanilla] verify dynamic provisioning with access mode ReadWriteOnce using datastoreURL specified in storage class matching one of the URLs specified in TargetvSANFileShareDatastoreURLs
  /Users/chethanv/Downloads/csi-external/vsphere-csi-driver/tests/e2e/vsphere_file_volume_basic.go:202
[BeforeEach] [csi-file-vanilla] Basic Testing
  /Users/chethanv/go/pkg/mod/k8s.io/kubernetes@v1.18.5/test/e2e/framework/framework.go:178
STEP: Creating a kubernetes client
Oct 29 14:36:15.045: INFO: >>> kubeConfig: /Users/chethanv/.kube/config
STEP: Building a namespace api object, basename file-volume-basic
Oct 29 14:36:15.327: INFO: Found PodSecurityPolicies; assuming PodSecurityPolicy is enabled.
Oct 29 14:36:15.458: INFO: Found ClusterRoles; assuming RBAC is enabled.
STEP: Binding the e2e-test-privileged-psp PodSecurityPolicy to the default service account in file-volume-basic-8081
STEP: Waiting for a default service account to be provisioned in namespace
[BeforeEach] [csi-file-vanilla] Basic Testing
  /Users/chethanv/Downloads/csi-external/vsphere-csi-driver/tests/e2e/vsphere_file_volume_basic.go:50
[It] [csi-file-vanilla] verify dynamic provisioning with access mode ReadWriteOnce using datastoreURL specified in storage class matching one of the URLs specified in TargetvSANFileShareDatastoreURLs
  /Users/chethanv/Downloads/csi-external/vsphere-csi-driver/tests/e2e/vsphere_file_volume_basic.go:202
STEP: Creating Storage Class with access mode "ReadWriteOnce" and fstype "nfs4"
STEP: Creating StorageClass  with scParameters: map[DatastoreURL:ds:///vmfs/volumes/vsan:52f0b4870bdcea96-4be3229edf074554/ csi.storage.k8s.io/fstype:nfs4] and allowedTopologies: [] and ReclaimPolicy:  and allowVolumeExpansion: false
STEP: Creating PVC using the Storage Class sc-sl5hf with disk size  and labels: map[] accessMode: ReadWriteOnce
STEP: Expect claim to fail as the access mode "ReadWriteOnce" is not supported for File volumes
Oct 29 14:36:15.918: INFO: Waiting up to 30s for PersistentVolumeClaims [pvc-j5gdr] to have phase Bound
Oct 29 14:36:15.939: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:17.964: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:19.982: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:22.003: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:24.022: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:26.105: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:28.131: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:30.151: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:32.184: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:34.203: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:36.221: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:38.249: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:40.268: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:42.292: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
Oct 29 14:36:44.331: INFO: PersistentVolumeClaim pvc-j5gdr found but phase is Pending instead of Bound.
STEP: Expected failure message: "NFS fstype not supported for ReadWriteOnce volume creation"
STEP: EventList item: "waiting for a volume to be created, either by external provisioner \"csi.vsphere.vmware.com\" or manually created by system administrator" 

STEP: EventList item: "External provisioner is provisioning volume for claim \"file-volume-basic-8081/pvc-j5gdr\"" 

STEP: EventList item: "failed to provision volume with StorageClass \"sc-sl5hf\": rpc error: code = InvalidArgument desc = Volume capability not supported. Err: NFS fstype not supported for ReadWriteOnce volume creation" 

Oct 29 14:36:46.355: INFO: Deleting PersistentVolumeClaim "pvc-j5gdr"
[AfterEach] [csi-file-vanilla] Basic Testing
  /Users/chethanv/go/pkg/mod/k8s.io/kubernetes@v1.18.5/test/e2e/framework/framework.go:179
Oct 29 14:36:46.443: INFO: Waiting up to 3m0s for all (but 0) nodes to be ready
STEP: Destroying namespace "file-volume-basic-8081" for this suite.

• [SLOW TEST:31.496 seconds]
[csi-file-vanilla] Basic Testing
/Users/chethanv/Downloads/csi-external/vsphere-csi-driver/tests/e2e/vsphere_file_volume_basic.go:43
  [csi-file-vanilla] verify dynamic provisioning with access mode ReadWriteOnce using datastoreURL specified in storage class matching one of the URLs specified in TargetvSANFileShareDatastoreURLs
  /Users/chethanv/Downloads/csi-external/vsphere-csi-driver/tests/e2e/vsphere_file_volume_basic.go:202
------------------------------
SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
Ran 1 of 149 Specs in 31.497 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 148 Skipped
PASS

Ginkgo ran 1 suite in 39.994708074s
Test Suite Passed

real	0m46.901s
user	0m17.398s
sys	0m17.748s

SandeepPissay · 2020-10-29T21:49:23Z

/lgtm

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 22, 2020

k8s-ci-robot requested review from divyenpatel and RaunakShah October 22, 2020 21:04

k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 22, 2020

SandeepPissay reviewed Oct 23, 2020

View reviewed changes

pkg/csi/service/vanilla/controller.go Outdated Show resolved Hide resolved

divyenpatel approved these changes Oct 23, 2020

View reviewed changes

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2020

SandeepPissay reviewed Oct 28, 2020

View reviewed changes

pkg/csi/service/common/util.go Outdated Show resolved Hide resolved

SandeepPissay reviewed Oct 29, 2020

View reviewed changes

pkg/csi/service/common/util.go Outdated Show resolved Hide resolved

Add volume capabilities validation in Vanilla Create Volume Request

4a448fe

k8s-ci-robot assigned SandeepPissay Oct 29, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 29, 2020

k8s-ci-robot merged commit 736ba4c into kubernetes-sigs:master Oct 29, 2020

divyenpatel added the release-2.1.0-candidate label Oct 30, 2020

divyenpatel mentioned this pull request Oct 30, 2020

cherry-pick commits to release 2.1 branch #476

Merged

divyenpatel added the release-2.1.0-cherry-picked label Oct 30, 2020

tejohnson123 mentioned this pull request Aug 17, 2021

Support for RWO on NFS #1233

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add volume capabilities validation in Vanilla Create Volume Request #459

Add volume capabilities validation in Vanilla Create Volume Request #459

chethanv28 commented Oct 22, 2020 •

edited

chethanv28 commented Oct 22, 2020

divyenpatel left a comment

chethanv28 commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

SandeepPissay commented Oct 29, 2020

k8s-ci-robot commented Oct 29, 2020

chethanv28 commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

chethanv28 commented Oct 29, 2020

SandeepPissay commented Oct 29, 2020

Add volume capabilities validation in Vanilla Create Volume Request #459

Add volume capabilities validation in Vanilla Create Volume Request #459

Conversation

chethanv28 commented Oct 22, 2020 • edited

chethanv28 commented Oct 22, 2020

divyenpatel left a comment

Choose a reason for hiding this comment

chethanv28 commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

SandeepPissay commented Oct 29, 2020

k8s-ci-robot commented Oct 29, 2020

chethanv28 commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

svcbot-qecnsdp commented Oct 29, 2020

chethanv28 commented Oct 29, 2020

SandeepPissay commented Oct 29, 2020

chethanv28 commented Oct 22, 2020 •

edited