New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for vanilla file services solution in a VC deployment when there is no cluster available in a datacenter #460
Fix for vanilla file services solution in a VC deployment when there is no cluster available in a datacenter #460
Conversation
c6ec014
to
0500b50
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Started vanilla file pipeline... |
/ok-to-test |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BaluDontu, chethanv28, divyenpatel The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The change looks good to me. Can you describe the testing done for this PR? |
Started vanilla file pipeline... |
|
Started vanilla file pipeline... |
|
/lgtm |
What this PR does / why we need it:
Currently we fail if the datacenters doesn't have any clusters inside it - https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/pkg/csi/service/common/vsphereutil.go#L518. But it is also possible to have ESX hosts directly inside the DC without a cluster. In that case it gives following error
This function is internally called via IsFileServiceEnabled as part vanilla CSI controller init - https://github.com/kubernetes-sigs/vsphere-csi-driver/blob/master/pkg/csi/service/vanilla/controller.go#L133
since this is a valid deployment, this PR provides a fix for it.
This bug seems to exist from the time when vanilla file services solutions is released.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes # #455Release note:
cc @divyenpatel @chethanv28