New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make auth check interval configurable. #462
Make auth check interval configurable. #462
Conversation
Hi @lipingxue. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
29e25d6
to
8b913e2
Compare
/retest |
8b913e2
to
0f28a3a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just one comment.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chethanv28, lipingxue The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0f28a3a
to
670f5dd
Compare
@lipingxue does this code affect CSI E2E tests for vanilla k8s? I'm asking since I do not see any E2E test results for this PR. |
/lgtm |
This change is to make the auth check interval configurable.
What this PR does / why we need it:
With this change, user can configure the auth check iterval.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
Test Setup:
In vsphere.conf file, set the auth check interval to 2 minutes
Use this vsphere.conf to deploy CSI.
Check the CSI log, the auth check is triggered at 2 minutes interval
Create a PVC, and PVC create succeed.
Release note: