Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go images to 1.12.10 #74

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

codenrhoden
Copy link
Contributor

What this PR does / why we need it:
Update from 1.12.6. There have been several security fixes since that
version.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

Update from 1.12.6. There have been several security fixes since that
version.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 3, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: codenrhoden

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 3, 2019
@codenrhoden
Copy link
Contributor Author

One question I have around this... We specify an explicit patch verserion (1.12.10) instead of just the minor (1.12). I think we do this for repeatability. 1.12 is a moving tag that always points to the latest release in that minor stream.

How important is that in this scenario? The downside is that we stay on old versions when security fixes come out. And that has happened a few times with 1.12.x.

Thoughts @dvonthenen and @divyenpatel ?

@frapposelli pinging you too, because we have the same issue in the CPI.

@codenrhoden
Copy link
Contributor Author

/hold
Want to wait until we get consensus on 1.12.10 vs 1.12...

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2019
@codenrhoden
Copy link
Contributor Author

So after thinking about this a bit more, surveying other projects, and talking to other folks involved in release, I think we should stick with the patch version. That way it doesn't slide without us knowing and we are left wondering "what changed?" if our program behavior suddenly changes.

/hold cancel
/assign @dvonthenen

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 4, 2019
@dvonthenen
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 4, 2019
@k8s-ci-robot k8s-ci-robot merged commit 7a5f6e3 into kubernetes-sigs:master Oct 4, 2019
@codenrhoden codenrhoden deleted the update-go branch October 4, 2019 16:43
gnufied pushed a commit to gnufied/vsphere-csi-driver that referenced this pull request May 3, 2023
…ncy-openshift-4.14-vmware-vsphere-syncer

Updating vmware-vsphere-syncer images to be consistent with ART
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants