Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds kubearmor-adapter to generate and update policyreports based on Policy Report CRD #95

Merged

Conversation

haardikdharma10
Copy link
Contributor

This PR aims to fix #59

This adapter is built as a part of the LFX Mentorship Program and it converts outputs received from KubeArmor and creates/updates a PolicyReport based on the Policy Report CRD.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2021
@k8s-ci-robot
Copy link
Contributor

Welcome @haardikdharma10!

It looks like this is your first PR to kubernetes-sigs/wg-policy-prototypes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/wg-policy-prototypes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Nov 30, 2021
Copy link
Member

@JimBugwadia JimBugwadia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @haardikdharma10 - thanks! Can you please replace the CRD and generated clientset, etc. with ones at:

https://github.com/kubernetes-sigs/wg-policy-prototypes/tree/master/policy-report/pkg

@haardikdharma10
Copy link
Contributor Author

Hi @haardikdharma10 - thanks! Can you please replace the CRD and generated clientset, etc. with ones at:

https://github.com/kubernetes-sigs/wg-policy-prototypes/tree/master/policy-report/pkg

Thank you @JimBugwadia, made the necessary changes :)

@JimBugwadia JimBugwadia self-requested a review December 13, 2021 18:41
@JimBugwadia
Copy link
Member

/lgtm
/approved

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haardikdharma10, JimBugwadia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2021
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 4680856 into kubernetes-sigs:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KubeArmor support for producing PolicyReport CRs
3 participants