Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding internal traffic policy work #20

Merged
merged 1 commit into from Jan 20, 2023
Merged

Adding internal traffic policy work #20

merged 1 commit into from Jan 20, 2023

Conversation

marosset
Copy link
Collaborator

Signed-off-by: Mark Rossetti marosset@microsoft.com

Implementing internal traffic policy (Added into in-tree kube-proxy via kubernetes/kubernetes#114407)
And also fixing some commented out code

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2023
@marosset
Copy link
Collaborator Author

/assign @jayunit100 @knabben

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 20, 2023
@marosset
Copy link
Collaborator Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2023
@marosset
Copy link
Collaborator Author

I got load balancer rules working in a CAPZ cluster with these changes.

@marosset
Adding internal traffic policy work
7a60527 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@marosset
Copy link
Collaborator Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 20, 2023
@knabben
Copy link
Member

knabben commented Jan 20, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5be884d into kubernetes-sigs:main Jan 20, 2023
marosset
marosset commented Jan 20, 2023
View reviewed changes
backend/kernelspace/proxier_events.go
// localTrafficDSR := false
//}
localTrafficDSR := false
localTrafficDSR := service.ExternalTrafficToLocal // TODO: verify this is the correct field in the KPNG localv1 API
Copy link
Collaborator Author

@marosset marosset Jan 20, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayunit100 or @knabben - Is what I am doing the correct assignments for localTrafficDSR and internalTrafficLocal ?
These wre previously checking against core.v1 types

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's correct, the upstream model is different from the kpng one related to these bool services parameters

knabben
knabben reviewed Jan 20, 2023
View reviewed changes
backend/kernelspace/proxier.go
@@ -555,10 +555,10 @@ func (proxier *Proxier) syncProxyRules() {
// merge stale services gathered from updateEndpointsMap
for _, svcPortName := range endpointUpdateResult.StaleServiceNames {
klog.InfoS("echo %v", svcPortName)
//if svcInfo, ok := proxier.serviceMap[svcPortName]; ok && svcInfo != nil && svcInfo.Protocol() == v1.ProtocolUDP {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't this required for UDP stale services and cleanup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knabben knabben knabben left review comments

@jayunit100 jayunit100 Awaiting requested review from jayunit100

Assignees

@jayunit100 jayunit100

@knabben knabben

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@marosset @k8s-ci-robot @knabben @jayunit100