Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows Kube-Proxy implementation for internal traffic policy #114407

Merged
merged 1 commit into from Dec 13, 2022
Merged

Windows Kube-Proxy implementation for internal traffic policy #114407

merged 1 commit into from Dec 13, 2022

Conversation

princepereira
Copy link
Contributor

@princepereira princepereira commented Dec 11, 2022 •
edited

What type of PR is this?

/kind bug

What this PR does / why we need it:

Adding internal traffic policy changes to optimize load balancing policy recreation during scaling. This can minimize the blackholing during scaling in big clusters. Changes are made as part of KEP-2086. The changes include:

  • When a InternalTrafficPolicy is set to Local, consider only local endpoints for creating cluster ip load balancer.
  • When both InternalTrafficPolicy and ExternalTrafficPolicy is set to Local, ignore creating remote endpoints.
Optimizing loadbalancer creation with the help of attribute Internal Traffic Policy: Local

Which issue(s) this PR fixes:

#114419

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 11, 2022
@k8s-ci-robot
Copy link
Contributor

@princepereira: This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Hi @princepereira. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. sig/network Categorizes an issue or PR as relevant to SIG Network. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Dec 11, 2022
@princepereira princepereira changed the title Implementing internal traffic policy changes. Windows Kube-Proxy implementation for internal traffic policy Dec 12, 2022
@princepereira princepereira marked this pull request as ready for review December 12, 2022 07:29
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2022
@sbangari
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: princepereira, sbangari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@sbangari
Copy link
Contributor

/remove-lgtm

@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Dec 12, 2022
@sbangari
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@princepereira
Copy link
Contributor Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Dec 13, 2022
@princepereira
Copy link
Contributor Author

/ok-to-test

@princepereira
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

@princepereira: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@princepereira
Copy link
Contributor Author

/test pull-kubernetes-e2e-gce

@k8s-ci-robot
Copy link
Contributor

@princepereira: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test pull-kubernetes-e2e-gce

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbangari
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 13, 2022
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-unit

1 similar comment
@princepereira
Copy link
Contributor Author

/test pull-kubernetes-unit

@princepereira
Copy link
Contributor Author

@jsturtevant , @marosset ,

Please label with milestone information.

@k8s-ci-robot k8s-ci-robot merged commit c9fb0c1 into kubernetes:master Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.27 milestone Dec 13, 2022
This was referenced Dec 13, 2022
Merged
Merged
Merged
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Dec 14, 2022
k8s-ci-robot added a commit that referenced this pull request Dec 16, 2022
@k8s-ci-robot
Merge pull request #114466 from princepereira/automated-cherry-pick-o…
543207b 
…f-#114407-upstream-release-1.24

Automated cherry pick of #114407: Windows Kube-Proxy implementation for internal traffic
k8s-ci-robot added a commit that referenced this pull request Dec 16, 2022
@k8s-ci-robot
Merge pull request #114468 from princepereira/automated-cherry-pick-o…
5bef9f4 
…f-#114407-upstream-release-1.26

Automated cherry pick of #114407: Windows Kube-Proxy implementation for internal traffic
k8s-ci-robot added a commit that referenced this pull request Dec 16, 2022
@k8s-ci-robot
Merge pull request #114467 from princepereira/automated-cherry-pick-o…
7282062 
…f-#114407-upstream-release-1.25

Automated cherry pick of #114407: Windows Kube-Proxy implementation for internal traffic
@marosset marosset mentioned this pull request Jan 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daschott daschott Awaiting requested review from daschott

@sbangari sbangari Awaiting requested review from sbangari

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees

@sbangari sbangari

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.27
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@princepereira @k8s-ci-robot @sbangari