Add readme for running unit tests on windows node #92

liyanhui1228 · 2019-07-16T22:04:21Z

No description provided.

k8s-ci-robot · 2019-07-16T22:04:21Z

Welcome @liyanhui1228!

It looks like this is your first PR to kubernetes-sigs/windows-testing 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/windows-testing has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

liyanhui1228 · 2019-07-16T22:05:07Z

/assign @yujuhong

yujuhong · 2019-07-16T22:10:24Z

/cc @pjh

k8s-ci-robot · 2019-07-16T22:10:25Z

@yujuhong: GitHub didn't allow me to request PR reviews from the following users: pjh.

Note that only kubernetes-sigs members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @pjh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yujuhong · 2019-07-16T22:17:56Z

README.md

+
+#### Install golang on Windows machine
+
+Download the go msi for windows from [here](https://golang.org/dl/) and scp it


Suggestion for some details:

Pick the Go version that is compatible with the Kubernetes version you intend to build. Download the MSI file to the Windows machine for development.

Invoke-Webrequest https://dl.google.com/go/go-<version>.windows-amd64.msi -Outfile go<version>.windows-amd64.msi

Start the MSI installer, e.g., Start-Process .\go<version.windows-amd64.msi and finish the installation.

yujuhong · 2019-07-16T23:06:50Z

README.md

@@ -129,11 +129,67 @@ kubetest --test=true \
  --test_args=--node-os-distro=windows --ginkgo.focus=\\[Conformance\\]|\\[NodeConformance\\]|\\[sig-windows\\]|\\[sig-apps\\].CronJob --ginkgo.skip=\\[LinuxOnly\\]|\\[k8s.io\\].Pods.*should.cap.back-off.at.MaxContainerBackOff.\\[Slow\\]\\[NodeConformance\\]|\\[k8s.io\\].Pods.*should.have.their.auto-restart.back-off.timer.reset.on.image.update.\\[Slow\\]\\[NodeConformance\\]
 ```

+## Running unit test
+
+Note: This assumes the Windows node is running on GCE, but should be applicable


@PatrickLang some of content (e.g., setting up git, etc) fits better in a development guide (e.g., https://github.com/kubernetes/community/blob/master/contributors/devel/development.md).

I don't think there's one for Windows, so it seems okay to add it here. Let us know if you think otherwise.

yujuhong · 2019-07-16T23:09:55Z

README.md

+
+to install git.
+
+#### Scp the files and corresponding test files to the Windows machine


I think we can leave this section out since it's really GCE-specific and also depends on individual's workflow. The rest of the change seems generic.

OK! Removed.

yujuhong · 2019-07-16T23:15:36Z

README.md

+gcloud compute scp --recurse [FILE_PATHS_LOCAL]  [WINDOWS_NODE_NAME]:/C:/[PATH_ON_WINDOWS]
+```
+
+#### Run the tests


Set up the Kubernetes repository on the node by following the instructions in Github workflow

pjh

Thanks for adding this!

pjh · 2019-07-17T00:05:45Z

README.md

+## Running unit test
+
+Note: This assumes the Windows node is running on GCE, but should be applicable
+to other platforms with slight changes.


I don't see anything GCP-specific below (maybe it was here previously but was then removed). Just remove this note?

Yep, removed.

liyanhui1228 · 2019-07-17T17:16:26Z

PTAL, thanks!

adelina-t · 2019-07-18T14:55:24Z

README.md

+Add go path to the `PATH` environment variable:
+
+```
+$env:PATH=$env:PATH+";C"\go\bin"


Typo here? should be c:\go\bin

Thanks for finding this out! Fixed.

PatrickLang · 2019-08-06T00:29:54Z

/lgtm

liyanhui1228 · 2019-08-06T20:59:41Z

Friendly ping! Can someone approve this PR?

yujuhong · 2019-08-13T23:33:05Z

@adelina-t @PatrickLang could one of you approve this? Thanks!

jingxu97 · 2019-08-14T21:51:09Z

README.md

+choco install git.install
+```
+
+to install git.


also need to add git path into env?

Good catch! Added.

PatrickLang · 2019-09-11T21:03:38Z

I'm sorry I missed this earlier. Thanks so much for getting this documented!
/approve

michmike

/lgtm
/approve

k8s-ci-robot · 2019-09-11T21:09:03Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liyanhui1228, michmike, PatrickLang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [PatrickLang,michmike]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Add readme for running unit tests on windows node

003d8ab

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 16, 2019

k8s-ci-robot requested review from adelina-t and PatrickLang July 16, 2019 22:04

k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 16, 2019

k8s-ci-robot assigned yujuhong Jul 16, 2019

yujuhong reviewed Jul 16, 2019

View reviewed changes

Address the comments

39940a9

pjh reviewed Jul 17, 2019

View reviewed changes

Remove notes

d7660d3

adelina-t reviewed Jul 18, 2019

View reviewed changes

fix typo

fe750aa

k8s-ci-robot assigned PatrickLang Aug 6, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 6, 2019

jingxu97 reviewed Aug 14, 2019

View reviewed changes

Add git to PATH

a970030

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 14, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 11, 2019

michmike approved these changes Sep 11, 2019

View reviewed changes

k8s-ci-robot assigned michmike Sep 11, 2019

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 11, 2019

k8s-ci-robot merged commit 7aadd34 into kubernetes-sigs:master Sep 11, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add readme for running unit tests on windows node #92

Add readme for running unit tests on windows node #92

liyanhui1228 commented Jul 16, 2019

k8s-ci-robot commented Jul 16, 2019

liyanhui1228 commented Jul 16, 2019

yujuhong commented Jul 16, 2019

k8s-ci-robot commented Jul 16, 2019

yujuhong Jul 16, 2019

liyanhui1228 Jul 16, 2019

yujuhong Jul 16, 2019

yujuhong Jul 16, 2019

liyanhui1228 Jul 16, 2019

yujuhong Jul 16, 2019

liyanhui1228 Jul 16, 2019

pjh left a comment

pjh Jul 17, 2019

liyanhui1228 Jul 17, 2019

liyanhui1228 commented Jul 17, 2019

adelina-t Jul 18, 2019

liyanhui1228 Jul 18, 2019

PatrickLang commented Aug 6, 2019

liyanhui1228 commented Aug 6, 2019

yujuhong commented Aug 13, 2019

jingxu97 Aug 14, 2019

liyanhui1228 Aug 14, 2019

PatrickLang commented Sep 11, 2019

michmike left a comment

k8s-ci-robot commented Sep 11, 2019


		#### Install golang on Windows machine

		Download the go msi for windows from [here](https://golang.org/dl/) and scp it


		to install git.

		#### Scp the files and corresponding test files to the Windows machine

Add readme for running unit tests on windows node #92

Add readme for running unit tests on windows node #92

Conversation

liyanhui1228 commented Jul 16, 2019

k8s-ci-robot commented Jul 16, 2019

liyanhui1228 commented Jul 16, 2019

yujuhong commented Jul 16, 2019

k8s-ci-robot commented Jul 16, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pjh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liyanhui1228 commented Jul 17, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PatrickLang commented Aug 6, 2019

liyanhui1228 commented Aug 6, 2019

yujuhong commented Aug 13, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PatrickLang commented Sep 11, 2019

michmike left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 11, 2019