Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 2.3.0 for v2 fork #104

Closed
tamalsaha opened this issue Dec 24, 2023 · 1 comment
Closed

Use 2.3.0 for v2 fork #104

tamalsaha opened this issue Dec 24, 2023 · 1 comment

Comments

@tamalsaha
Copy link

The 2.4.0 version added the line wrap issue which was not present in 2.3.0 . Is it possible to use 2.3.0 for v2 fork? Thanks

@liggitt
Copy link

liggitt commented Jan 2, 2024

I don't think that's accurate. v2.4.0 restored compatibility with pre-2.3.0 behavior, which is what we want.

The default formatting of v2 was erroneously changed in v2.3.0 and reverted in v2.4.0, at which point this function was introduced to help migration.

Looking at the history of this repo, we never relied on 2.3.0 because it broke compat tests - https://github.com/kubernetes-sigs/yaml/commits/master/go.mod - we jumped from 2.2.8 to 2.4.0

@liggitt liggitt closed this as not planned Won't fix, can't repro, duplicate, stale Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants