[addon-resizer] deployment update drops existing toleration fields

[djsly]

Probably due to the version of the k8s go client used by the addon-resizer

#kubectl create -f heapster-controller.yaml
deployment "heapster" created
# kubectl get deployment heapster -o yaml | grep tolerations -A6
      tolerations:
      - key: CriticalAddonsOnly
        operator: Exists
      - effect: NoSchedule
        key: role
        operator: Equal
        value: k8s-edge-node
# kubectl get deployment heapster -o yaml | grep tolerations -A6
      tolerations:
      - key: CriticalAddonsOnly
        operator: Exists
      - effect: NoSchedule
        key: role
        operator: Equal
        value: k8s-edge-node
# kubectl get deployment heapster -o yaml | grep tolerations -A6
# kubectl get deployment heapster -o yaml | grep tolerations -A6

Go client version

       {
            "ImportPath": "k8s.io/kubernetes/pkg/client/clientset_generated/release_1_3",
            "Comment": "v1.3.0-alpha.5-165-g7476d97",
            "Rev": "7476d97781563b70e8b89a8bd3f99ea75ae6c290"
        },

[djsly]

@piosz @wojtek-t @Q-Lee

[djsly]

@x13n @MaciekPytel since you guys seems to be the new owner :)

[x13n]

PodSpec used by pod_nanny (via DeploymentInterface -> Deployment -> DeploymentSpec -> PodTemplateSpec) doesn't have Tolarations field defined, looks like it's using an older definition of Pod. Old godeps?

[djsly]

looks like it indeed, from my understanding it is using an old k8s go client. version v1.3.0-alpha.5-165-g7476d97

[x13n]

@djsly I briefly chatted with @MaciekPytel today about this. Neither me nor him can look into this immediately, but this should get fixed some time between now and 1.8. This should be a matter of updating godeps. Of course, PR to fix this would be welcome.

[djsly]

Thanks @x13n, I will try to find time for this as well, I had a question, how can I know the version of GO used by all of the different k8s projects? when I started to look at fixing, I got stuck at which version of GO do I need :)

[piosz]

@djsly there is something in godeps https://github.com/kubernetes/autoscaler/blob/master/addon-resizer/Godeps/Godeps.json#L3, though there is not guarantee it was built with this version.

[mwielgus]

@piosz - kubernetes/autoscaler contains the new version that has not been fully release yet. The old one lived in kubernetes/contrib.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

[djsly]

This is fixed in the latest release, closing.

[seh]

Which release is that? I still see this behavior—for both the "tolerations" and "affinity" fields in the pod spec—using the container image k8s.gcr.io/addon-resizer:1.7.

[seh]

Ah, I see there was a release of version 1.8.1 on 8 December 2017.

[seh]

Version 1.8.1 does not parse command-line flags properly (per #559). There is also a later container image k8s.gcr.io/addon-resizer:1.8.3 that's free of that problem.