Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

addon-resizer eats Deployment affinity/tolerations (needs newer version) #85

Closed
anguslees opened this issue Aug 16, 2018 · 2 comments
Closed

addon-resizer eats Deployment affinity/tolerations (needs newer version) #85

anguslees opened this issue Aug 16, 2018 · 2 comments
Assignees
@anguslees
Labels
bug Something isn't working good first issue Good for newcomers
Projects
BKPR

Comments

@anguslees
Copy link
Contributor

An external kubecfg user encountered this (and initially thought it was a kubecfg bug). We will encounter the same issue with addon-resizer too. Apparently the fix is to upgrade to (at least) k8s.gcr.io/addon-resizer:1.8.3

See also: kubernetes/autoscaler#188
@anguslees anguslees added bug Something isn't working good first issue Good for newcomers labels Aug 16, 2018
@arapulido arapulido added this to Inbox in BKPR via automation Nov 1, 2018
@arapulido arapulido removed this from Inbox in BKPR Nov 1, 2018
@arapulido
Copy link
Contributor

@anguslees is this still relevant?

@anguslees
Copy link
Contributor Author

Yes, we're still using gcr.io/google_containers/addon-resizer:1.0 in the prometheus manifests.

@falfaro falfaro added this to Inbox in BKPR via automation Nov 19, 2018
@falfaro falfaro moved this from Inbox to Backlog in BKPR Nov 19, 2018
@falfaro falfaro moved this from Backlog to Committed in BKPR Dec 31, 2018
anguslees added a commit to anguslees/kube-prod-runtime that referenced this issue Jan 7, 2019
@anguslees
Upgrade addon-resizer to 1.8.4
8e43270 
Significantly newer version than our previous ancient 1.0.
Fixes vmware-archive#85 and many other minor issues.
@anguslees anguslees mentioned this issue Jan 7, 2019
Merged
bors bot added a commit that referenced this issue Jan 7, 2019
@bors @anguslees
Merge #301
c976560 
301: Upgrade addon-resizer to 1.8.4 r=sameersbn a=anguslees

Significantly newer version than our previous ancient 1.0.
Fixes #85 and many other minor issues.

Co-authored-by: Angus Lees <gus@inodes.org>
@bors bors bot closed this as completed in #301 Jan 7, 2019
BKPR automation moved this from Committed to Done Jan 7, 2019
bors bot pushed a commit that referenced this issue Feb 6, 2019
@anguslees
Upgrade addon-resizer to 1.8.4
bec8033 
Significantly newer version than our previous ancient 1.0.
Fixes #85 and many other minor issues.

(cherry picked from commit 8e43270)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anguslees anguslees

Labels
bug Something isn't working good first issue Good for newcomers
Projects
BKPR
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anguslees @arapulido