-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster autoscaler provider build tags broken for several providers #6492
Comments
/good-first-issue |
@elmiko: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Thanks, @elmiko for highlighting this issue. |
I would like to work on it. |
Fixed it here: #6494 |
@Shubham82 probably a good idea, although the breaking change only came in recently so i would double check to see how far we need to backport. |
I checked these changes were merged in CA 1.29, before CA 1.29 I will raise a PR for it once PR #6494 is merged. |
thanks @Shubham82 ! |
I have opened PR #6590 to backport the changes to the |
closing this issue, as corresponding PRs are merged. |
/close |
@Shubham82: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Which component are you using?:
cluster-autoscaler
What version of the component are you using?:
Component version: master
What k8s version are you using (
kubectl version
)?:n/a
What environment is this in?:
n/a, build environment
What did you expect to happen?:
expect target binary to be built
What happened instead?:
How to reproduce it (as minimally and precisely as possible):
run the following
Anything else we need to know?:
pr #5820 added an argument to the
buildCloudProvider
function, when building for all tags or kwok the build works fine, but when specifying a provider which has not implemented the builder change then the error listed above happens on build.this is fairly easy to fix, but requires updating many of the builder files. an example fix can be seen in #6491
providers that need fixing:
The text was updated successfully, but these errors were encountered: