New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add informer argument to the CloudProviders builder. #6494
Add informer argument to the CloudProviders builder. #6494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for picking this up @Shubham82
/lgtm
Hi @BigDarkClown |
cc @x13n |
Thanks @Shubham82 ! /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Shubham82, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…nt to the CloudProviders builder into CA1.29
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR adds the
informer factory
as an argument to thebuildCloudProvider
function in all the Cloud Providers builders (Where it is missing) so that building the Cluster Autoscaler with tags will work correctly.Which issue(s) this PR fixes:
Part of #6492
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: