-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommender capps recommendation according to policy. #1354
Conversation
I'll take a look. |
vertical-pod-autoscaler/pkg/recommender/routines/recommender.go
Outdated
Show resolved
Hide resolved
vertical-pod-autoscaler/pkg/recommender/routines/recommender.go
Outdated
Show resolved
Hide resolved
76aa28c
to
21f76e1
Compare
Reworked a bit. I think this looks better now. |
Thanks, it indeed looks better. LGTM |
/lgtm |
@bskiba: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bskiba The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…ubernetes#1354) * [util] Add admissioncheck * Review Remarks * Review Remarks * Review Remarks * Review Remarks
No description provided.