Cluster Autoscaler: Cleanup GetInstanceID() interface #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
bskiba
added
area/cluster-autoscaler
area/provider/azure
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mwielgus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #1738.
As we agreed, #1738 is a temporary workaround for fixing the isues in stable releases. For the following v1.14, kubernetes/kubernetes#74882 has made a change in kubernetes repo, so that resourceGroupName in providerID would be always in lower cases.
This PR reverts the changes in #1738 and also aligned the providerID in same format from #74882.
Note that with this change, because the providerID is in different format, master branch (or following v1.14 release) of CA won't work again with kubernetes <=1.14.0-beta.1. This is ok because beta version won't be run in production and CA should always be used with matched version of kubernetes according to the version matrix .
/assign @MaciekPytel @mwielgus @losipiuk
/cc @ritazh @andyzhangx