Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix expectedToRegister to respect instances with nil status #6528

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Fix expectedToRegister to respect instances with nil status #6528

merged 1 commit into from
Feb 22, 2024

Conversation

yarinm
Copy link
Contributor

@yarinm yarinm commented Feb 13, 2024

Fix for #6524

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Feb 13, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @yarinm!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 13, 2024
@yarinm yarinm mentioned this pull request Feb 13, 2024
Closed
@azylinski
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 13, 2024
@x13n
Copy link
Member

x13n commented Feb 13, 2024

Thanks!

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x13n, yarinm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@Shubham82
Copy link
Contributor

@yarinm
you have to sign the CLA, to merge the PR.
See the following document to sign the CLA: Signing Contributor License Agreements(CLA)

@Shubham82
Copy link
Contributor

To check EasyCLA

/easycla

@yarinm
Copy link
Contributor Author

yarinm commented Feb 15, 2024 •
edited
Loading

@Shubham82 I'm waiting for the legal department on the firm I'm working for this, I hope to get the necessary approvals in the next few days

@yarinm
Copy link
Contributor Author

yarinm commented Feb 20, 2024

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 22, 2024
@yarinm
Copy link
Contributor Author

yarinm commented Feb 22, 2024

@Shubham82 We've signed the CLA, can you please merge the PR?

@k8s-ci-robot k8s-ci-robot merged commit 6ca8414 into kubernetes:master Feb 22, 2024
6 checks passed
@domenicbozzuto domenicbozzuto mentioned this pull request Mar 8, 2024
Closed
@daimaxiaxie daimaxiaxie mentioned this pull request Mar 21, 2024
Closed
@tallaxes
Copy link
Contributor

Shouldn't this be cherry-picked into 1.28 and 1.29?

@Shubham82
Copy link
Contributor

@tallaxes, I think we can fix this in the previous supported releases.
Let's wait for other members' opinions.

@chuyee chuyee mentioned this pull request Jun 3, 2024
Open
@Shubham82
Copy link
Contributor

@tallaxes I will open PRs to backport this fix into CA 1.28 and CA 1.29.

Shubham82 added a commit to Shubham82/autoscaler that referenced this pull request Jun 5, 2024
@Shubham82
Backport kubernetes#6528 [CA] Fix expectedToRegister to respect insta…
a400607 
…nces with nil status into CA1.28
@Shubham82 Shubham82 mentioned this pull request Jun 5, 2024
Merged
Shubham82 added a commit to Shubham82/autoscaler that referenced this pull request Jun 5, 2024
@Shubham82
Backport kubernetes#6528 [CA] Fix expectedToRegister to respect insta…
7d87a8a 
…nces with nil status into CA1.29
@Shubham82 Shubham82 mentioned this pull request Jun 5, 2024
Merged
@Shubham82
Copy link
Contributor

JFI: I have raised the following PR:
For CA 1.28 #6892
For CA 1.29 #6893

k8s-ci-robot added a commit that referenced this pull request Jun 7, 2024
@k8s-ci-robot
Merge pull request #6892 from Shubham82/cherry-picked-of-#6528-upstre…
0c97874 
…am-cluster-autoscaler-release-1.28

Backport #6528 [CA] Fix expectedToRegister to respect instances with nil status into CA1.28
k8s-ci-robot added a commit that referenced this pull request Jun 7, 2024
@k8s-ci-robot
Merge pull request #6893 from Shubham82/cherry-picked-of-#6528-upstre…
90591b5 
…am-cluster-autoscaler-release-1.29

Backport #6528 [CA] Fix expectedToRegister to respect instances with nil status into CA1.29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

@x13n x13n Awaiting requested review from x13n

Assignees

@azylinski azylinski

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@yarinm @k8s-ci-robot @azylinski @x13n @Shubham82 @tallaxes