Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vpa-release-1.1] Automated cherry pick of #6903: vpa-updater: Log the Pod namespace when evicting a Pod #6964

Merged
merged 1 commit into from
Jun 27, 2024
Merged

[vpa-release-1.1] Automated cherry pick of #6903: vpa-updater: Log the Pod namespace when evicting a Pod #6964

merged 1 commit into from
Jun 27, 2024

Conversation

ialidzhikov
Copy link
Contributor

@ialidzhikov ialidzhikov commented Jun 23, 2024 •
edited
Loading

/area vertical-pod-autoscaler
/kind bug

Cherry pick of #6903 on vpa-release-1.1.

#6903: vpa-updater: Log the Pod namespace when evicting a Pod

Release Notes:

vpa-updater logging is now improved. In many cases it now logs the objects' namespaces as well.

@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 23, 2024
@ialidzhikov
Copy link
Contributor Author

/cc @kwiesmueller

@Shubham82
Copy link
Contributor

Thanks, @ialidzhikov for the fix.
The changes look good to me.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2024
@ialidzhikov
Copy link
Contributor Author

@kwiesmueller could you have a look when you have time? Thanks in advance!

kwiesmueller
kwiesmueller approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@kwiesmueller kwiesmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ialidzhikov, kwiesmueller

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 27, 2024
@k8s-ci-robot k8s-ci-robot merged commit 635eba1 into kubernetes:vpa-release-1.1 Jun 27, 2024
7 checks passed
@ialidzhikov ialidzhikov deleted the automated-cherry-pick-of-#6903-origin-vpa-release-1.1 branch July 2, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwiesmueller kwiesmueller kwiesmueller approved these changes

@jbartosik jbartosik Awaiting requested review from jbartosik

@krzysied krzysied Awaiting requested review from krzysied

Assignees

@kwiesmueller kwiesmueller

@Shubham82 Shubham82

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ialidzhikov @Shubham82 @k8s-ci-robot @kwiesmueller