Skip to content
This repository has been archived by the owner on Feb 22, 2022. It is now read-only.

Add default function from chart template to check release name match #5592

Closed
wants to merge 3 commits into from

Conversation

timm088
Copy link
Contributor

@timm088 timm088 commented May 16, 2018

What this PR does / why we need it:

When releasing these charts, service name will be prefixed with the release name, resulting in name-name. This also impacts DNS resolutions.

Special notes for your reviewer:

From my research, looks like the default chart template was changed (i.e., when running helm create locally), this function was just not added here.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: timm088
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: viglesiasce

Assign the PR to them by writing /assign @viglesiasce in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Hi @timm088. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 16, 2018
@timm088
Copy link
Contributor Author

timm088 commented May 16, 2018

I have signed the CLA

@timm088
Copy link
Contributor Author

timm088 commented May 16, 2018

/assign @viglesiasce

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 16, 2018
@unguiculus
Copy link
Member

Please create separate PRs per chart. Thanks.

@timm088
Copy link
Contributor Author

timm088 commented May 20, 2018

Will do. Looks like the chart has been updated in the last < 1w for the consul chart also.
Will close this PR and then open again as seperate PRs

@timm088 timm088 closed this May 20, 2018
@timm088 timm088 deleted the add-release-name-checks branch May 20, 2018 23:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants