-
Notifications
You must be signed in to change notification settings - Fork 16.8k
Add default function from chart template to check release name match #5592
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: timm088 Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @timm088. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I have signed the CLA |
/assign @viglesiasce |
Please create separate PRs per chart. Thanks. |
Will do. Looks like the chart has been updated in the last < 1w for the consul chart also. |
What this PR does / why we need it:
When releasing these charts, service name will be prefixed with the release name, resulting in
name-name
. This also impacts DNS resolutions.Special notes for your reviewer:
From my research, looks like the default chart template was changed (i.e., when running helm create locally), this function was just not added here.