[gitea] Initial Commit #6124

midnightconman · 2018-06-14T23:32:59Z

What this PR does / why we need it:
Adds a helm chart for gitea: https://gitea.io/en-US/

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:
This is very similar to gogs helm chart, with subtle differences.

k8s-ci-robot · 2018-06-14T23:33:05Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: midnightconman
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: foxish

Assign the PR to them by writing /assign @foxish in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2018-06-14T23:33:07Z

Hi @midnightconman. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

midnightconman · 2018-06-14T23:33:43Z

/assign @foxish

unguiculus · 2018-06-17T20:05:54Z

There's another PR for Gitea: #3408 You may want to join forces.

unguiculus · 2018-06-17T20:06:06Z

/assign

filoozom · 2018-06-18T22:30:50Z

Would your initContainers workaround work in a Deployment with multiple replicas though? Wouldn't INTERNAL_TOKEN need to be shared across them?

Nodraak · 2018-06-19T07:23:33Z

incubator/gitea/README.md

+The following table lists some of the configurable parameters of the Gitea
+chart and their default values.
+
+| Parameter                        | Description                                                  | Default                                                    |


No sure what it's worth, but usually other Charts list every possible configuration settings of values.yaml. I'm not sure if that's really a benefit, because your values.yaml seems to have enough comments. Anyway, that's just my 2 cents

Nodraak · 2018-06-19T07:24:25Z

incubator/gitea/values.yaml

+
+    ## Enable this to use captcha validation for registration.
+    ##
+    serverDomain: gitea.example.com


The comment and the key does not seems to go toogether

Nodraak · 2018-06-19T07:26:01Z

incubator/gitea/values.yaml

+## Persistent Volume Storage configuration.
+## ref: https://kubernetes.io/docs/user-guide/persistent-volumes
+##
+persistence:


Could you allow one to specify a existing PVC ? For exmaple jenkins does this.

Yep, that works... read line 249.

Nodraak · 2018-06-19T07:27:13Z

incubator/gitea/values.yaml

+    ##
+    databaseType: postgres
+
+    ## Database host.  Unused unless `postgresql.install` is false.


Double negatives are hard to read and understand, could you use "Used only when postgresql.install is true." ? thanks :)

jfelten · 2018-06-22T01:05:07Z

well darn it - I just created my own similar gitea chart since this PR was not there when I started. Feel free to borrow anything from my chart if helpful or let me know how I can help:

https://github.com/jfelten/gitea-helm-chart

anapsix · 2018-07-11T12:12:21Z

used this chart to setup Gitea, having some trouble
resolving these issues, I was able to use this chart to provision Gitea

reading config

I don't think it's picking up the config at all..
Logs show the following:

2018/07/11 11:51:03 [T] AppPath: /app/gitea/gitea
2018/07/11 11:51:03 [T] AppWorkPath: /app/gitea
2018/07/11 11:51:03 [T] Custom path: /data/gitea
2018/07/11 11:51:03 [T] Log path: /data/gitea/log
2018/07/11 11:51:03 [I] Log Mode: Console(Info)
2018/07/11 11:51:03 [I] XORM Log Mode: Console(Info)
2018/07/11 11:51:03 [I] Cache Service Enabled
2018/07/11 11:51:03 [I] Session Service Enabled
2018/07/11 11:51:03 [I] SQLite3 Supported
2018/07/11 11:51:03 [I] Run Mode: Development
2018/07/11 11:51:03 [I] Gitea v1.4.2 built with: bindata, sqlite
2018/07/11 11:51:03 [I] Listen: http://0.0.0.0:3000

copied the config, but got an error

cp /etc/gitea/conf/app.ini /data/gitea/conf/app.ini
s6-svc -h /etc/s6/gitea
## logs
2018/07/11 12:26:49 [T] AppPath: /app/gitea/gitea
2018/07/11 12:26:49 [T] AppWorkPath: /app/gitea
2018/07/11 12:26:49 [T] Custom path: /data/gitea
2018/07/11 12:26:49 [T] Log path: /app/gitea/log
2018/07/11 12:26:49 [I] Log Mode: Console(Info)
2018/07/11 12:26:49 [I] XORM Log Mode: Console(Info)
2018/07/11 12:26:49 [I] Cache Service Enabled
2018/07/11 12:26:49 [I] Session Service Enabled
2018/07/11 12:26:49 [I] Gitea v1.4.2 built with: bindata, sqlite
2018/07/11 12:26:49 [I] PING DATABASE postgres
2018/07/11 12:26:49 [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: pq: SSL is not enabled on the server

postgresql

adding SSL_MODE = disable to [database] section of configmap helps

    [database]
    DB_TYPE = {{ .Values.service.gitea.databaseType | quote }}
    HOST = {{ template "gitea.database.host" . }}
    {{ if .Values.postgresql.install -}}
    SSL_MODE = disable
    {{- end }}
    NAME = {{ template "gitea.database.name" . }}
    USER = {{ template "gitea.database.user" . }}
    PASSWD = {{ template "gitea.database.password" . }}
    PATH = {{ .Values.service.gitea.databasePath | quote }}

But initContainers should be fixed to copy the config to the right place, if I understand the issue correctly.
I've removed config-rw and updated init container with the following:

      initContainers:
        - name: copy-app-ini
          image: alpine:3.7
          command: ["/bin/sh"]
          args: 
            - -c
            - "cp /config/* /data/gitea/conf/; chmod 640 /data/gitea/conf/*; chown 1000:1000 -R /data/gitea/conf/*"
          volumeMounts:
            - name: config
              mountPath: /config
            - name: data
              mountPath: /data

indexerIssuePath

is defined as /data/issues.bleve, but it generates the following error:

InitIssueIndexer()] [E] InitIssuesIndexer: create index, mkdir /data/issues.bleve: permission denied

changing it to /data/gitea/issues.bleve helps

jpds

A newer version of Gitea is out.

jpds · 2018-09-04T15:38:03Z

incubator/gitea/values.yaml

+
+image:
+  repository: gitea/gitea
+  tag: 1.4.2


Gitea 1.5.1 is out.

stormmore · 2018-09-08T18:30:18Z

incubator/gitea/templates/secrets.yaml

@@ -0,0 +1,12 @@
+apiVersion: v1


Shouldn't this only be created if .Values.postgresql.create=true?

stormmore · 2018-09-10T02:38:30Z

incubator/gitea/templates/deployment.yaml

+            - name: data
+              mountPath: /data
+            - name: config-rw
+              mountPath: /etc/gitea/conf


I suspect you mean to mount this to /etc/templates/ so that it gets consumed by https://github.com/go-gitea/gitea/blob/6e03390aa8fa096206457962db1955d642860b57/docker/etc/s6/gitea/setup#L39 on initial start up

stormmore · 2018-09-10T02:50:28Z

On top of the 2 comments I have made, It should be noted that the config file that is used is in /data/gitea/conf/app.ini so during an upgrade, changing any setting in the Chart's values will have no impact on the configuration.

One solution would be to have a pre-upgrade hook that deletes /data/conf/app.ini and do the mount to /etc/templates per my other comment. Seems a bit of overkill.

I suspect, the config could simply be mounted to /data/gitea/conf/ after the /data/ volume is mounted.

Another thing I noticed while investigating this chart is that there is a difference between the app.ini content in the chart and what is written by the gitea installer in the UI. Unfortunately, I forgot to save the diff and I suspect it is just a diff between different gitea releases.

stale · 2018-10-10T03:11:57Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale · 2018-10-24T03:58:26Z

This issue is being automatically closed due to inactivity.

ArnauFauquer

all tested, and perfect

Tchoupinax · 2019-10-28T18:41:45Z

Hello :)

What is the state of this project branch ?

[gitea] Initial Commit

3449e63

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 14, 2018

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jun 14, 2018

k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 14, 2018

k8s-ci-robot requested review from alejandroEsc and lachie83 June 14, 2018 23:33

k8s-ci-robot assigned foxish Jun 14, 2018

k8s-ci-robot assigned unguiculus Jun 17, 2018

midnightconman mentioned this pull request Jun 18, 2018

[WIP] Adds Gitea to the incubator #3408

Closed

Nodraak reviewed Jun 19, 2018

View reviewed changes

mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2018

jpds suggested changes Sep 4, 2018

View reviewed changes

incubator/gitea/values.yaml

image:

repository: gitea/gitea

tag: 1.4.2

Copy link

Collaborator

jpds Sep 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitea 1.5.1 is out.

pojntfx reacted with thumbs up emoji

stormmore reviewed Sep 8, 2018

View reviewed changes

incubator/gitea/templates/secrets.yaml

@@ -0,0 +1,12 @@

apiVersion: v1

Copy link

stormmore Sep 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this only be created if .Values.postgresql.create=true?

stormmore reviewed Sep 10, 2018

View reviewed changes

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 10, 2018

stale bot closed this Oct 24, 2018

ArnauFauquer reviewed Sep 3, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[gitea] Initial Commit #6124

[gitea] Initial Commit #6124

midnightconman commented Jun 14, 2018

k8s-ci-robot commented Jun 14, 2018

k8s-ci-robot commented Jun 14, 2018

midnightconman commented Jun 14, 2018

unguiculus commented Jun 17, 2018 •

edited

unguiculus commented Jun 17, 2018

filoozom commented Jun 18, 2018

Nodraak Jun 19, 2018

Nodraak Jun 19, 2018

Nodraak Jun 19, 2018

midnightconman Jun 20, 2018

Nodraak Jun 19, 2018 •

edited

jfelten commented Jun 22, 2018 •

edited

anapsix commented Jul 11, 2018 •

edited

jpds left a comment

jpds Sep 4, 2018

stormmore Sep 8, 2018

stormmore Sep 10, 2018

stormmore commented Sep 10, 2018 •

edited

stale bot commented Oct 10, 2018

stale bot commented Oct 24, 2018

ArnauFauquer left a comment

Tchoupinax commented Oct 28, 2019

[gitea] Initial Commit #6124

[gitea] Initial Commit #6124

Conversation

midnightconman commented Jun 14, 2018

k8s-ci-robot commented Jun 14, 2018

k8s-ci-robot commented Jun 14, 2018

midnightconman commented Jun 14, 2018

unguiculus commented Jun 17, 2018 • edited

unguiculus commented Jun 17, 2018

filoozom commented Jun 18, 2018

Nodraak Jun 19, 2018

Choose a reason for hiding this comment

Nodraak Jun 19, 2018

Choose a reason for hiding this comment

Nodraak Jun 19, 2018

Choose a reason for hiding this comment

midnightconman Jun 20, 2018

Choose a reason for hiding this comment

Nodraak Jun 19, 2018 • edited

Choose a reason for hiding this comment

jfelten commented Jun 22, 2018 • edited

anapsix commented Jul 11, 2018 • edited

reading config

postgresql

indexerIssuePath

jpds left a comment

Choose a reason for hiding this comment

jpds Sep 4, 2018

Choose a reason for hiding this comment

stormmore Sep 8, 2018

Choose a reason for hiding this comment

stormmore Sep 10, 2018

Choose a reason for hiding this comment

stormmore commented Sep 10, 2018 • edited

stale bot commented Oct 10, 2018

stale bot commented Oct 24, 2018

ArnauFauquer left a comment

Choose a reason for hiding this comment

Tchoupinax commented Oct 28, 2019

unguiculus commented Jun 17, 2018 •

edited

Nodraak Jun 19, 2018 •

edited

jfelten commented Jun 22, 2018 •

edited

anapsix commented Jul 11, 2018 •

edited

stormmore commented Sep 10, 2018 •

edited