[WIP] Adds Gitea to the incubator #3408

cdrage · 2018-01-22T20:48:27Z

This is a follow up to PR's
#2083 as well as #346

Gitea is a fork of Gogs and thus, (most) of this PR has been adapted
from: https://github.com/kubernetes/charts/tree/master/incubator/gogs

At the moment there is no Gitea chart available in the incubator.
Unfortunately there is little activity on Gogs (see:
https://github.com/gogits/gogs) since it's ran by only one maintainer
(rather than a community).

cdrage · 2018-01-22T20:52:09Z

/retest

mattfarina · 2018-01-23T15:05:23Z

@cdrage it looks like you need to re-create the requirements.lock file. That's the CI issue.

mattfarina

Thanks for the PR. I did a quick review and have a little feedback.

mattfarina · 2018-01-23T15:06:48Z

incubator/gitea/Chart.yaml

+description: 'Gitea: Go Git Service'
+name: gitea
+version: 1.3.2
+appVersion: 0.0.1


It looks like you have the version and appVersion switched. The version is the version of the chart or, rather, the configuration to deploy to Kubernetes. The appVersion is the version of the underlying application being deployed.

mattfarina · 2018-01-23T15:07:27Z

incubator/gitea/Chart.yaml

+- git
+- gitea
+maintainers:
+- name: Charlie Drage


Instead of your name can you please put your github username here. That will make it easier for us to contact you in continued maintenance of the chart.

mattfarina · 2018-01-23T15:17:10Z

incubator/gitea/requirements.yaml

@@ -0,0 +1,5 @@
+dependencies:
+  - name: postgresql
+    version: 0.8.1


You can use a SemVer range for the version. You can read about the details at https://github.com/Masterminds/semver#basic-comparisons

Hey @mattfarina I think you're wrong. A lot of the stable charts use the exact same dependency with 0.8.1

The latest version of that chart is 0.8.9 which means there have been 8 patch releases you'll not get. These include bug fixes and minor improvements.

In the chart best practices guide, in the helm docs, it recommends using ranges.

There are a number of charts here that aren't doing that. We likely need to make fixes to those other charts to clean up quality. PRs are welcome.

mattfarina · 2018-01-23T15:19:41Z

incubator/gitea/templates/deployment.yaml

@@ -0,0 +1,64 @@
+apiVersion: extensions/v1beta1
+kind: Deployment


In Kubernetes 1.10 this API version can be dropped. Since this Deployments have gone to apps/v1beta1, apps/v1beta2, and most recently apps/v1. In 1.10 anything prior to apps/v1beta2 can be dropped. This is the version I would recommend specifying unless you want to support multiple versions by checking in Capabilities.APIVersions for a version.

See other comment, sorry! I'm following the other stable charts as well for motivation. Seems to be in-line with how the others do it.

To add some more context, there is a deprecation policy page with details and examples. Based on the timing, this API has not been removed due to a bug.

A bunch of the charts were created with extensions/v1beta1. One of the TODOs we need to tackle for the charts repo is updating them before the API version goes away. To have less work when that happens we've been asking charts to use a newer API version.

mattfarina · 2018-01-23T15:20:41Z

incubator/gitea/templates/service.yaml

+spec:
+  type: {{ .Values.serviceType }}
+  ports:
+  - port: {{ .Values.service.httpPort | int }}


In some files the list indentation is 0 and in other files it's 2 spaces. Can you please make it consistent across the chart at a 2 space indentation.

mattfarina · 2018-02-07T14:28:20Z

/retest

cdrage · 2018-02-07T17:42:01Z

@mattfarina Thanks so much for the review. I updated the last two sections (version switched to ~0.8.9) and the deployment kind changes to apps/v1beta1).

filoozom · 2018-02-14T12:26:16Z

Can we maybe add gitea.database.path and a PVC to support SQLite? Maybe even just add it to the current PVC. I can help if need be.

Also looks like requirements.lock is still broken?

cdrage · 2018-02-20T02:54:30Z

@filoozom Odd, I rebuilt it... didn't seem to work.

filoozom · 2018-02-20T14:59:06Z

Are you talking about requirements.lock?

$ helm dependency build
...Successfully got an update from the "incubator" chart repository
...Successfully got an update from the "stable" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 1 charts
Downloading postgresql from repo https://kubernetes-charts.storage.googleapis.com/
Deleting outdated charts
$ cat requirements.lock
dependencies:
- name: postgresql
  repository: https://kubernetes-charts.storage.googleapis.com/
  version: 0.8.12
digest: sha256:fa8809a605bfa4b36a22ff37b10a7b94f36b227e4d2bca359e6a3a11b791dced
generated: 2018-02-20T14:54:32.069629245Z

filoozom

Would also be nice to add service.gitea.disableSsh (DISABLE_SSH) too 😃

filoozom · 2018-02-20T15:25:28Z

incubator/gitea/values.yaml

+    ##
+    cacheHost:
+
+    ## Enable this to use captcha validation for registration.


Wrong description message for serverDomain

k8s-ci-robot · 2018-02-20T15:54:13Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cdrage
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: prydonius

Assign the PR to them by writing /assign @prydonius in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

filoozom · 2018-02-26T12:04:36Z

@mattfarina Can we get this merged so that I can work on extending this chart in a new PR?

cdrage · 2018-02-26T15:46:21Z

Yeah, sorry @filoozom been busy with a few other projects, but yes 👍 I'd be down to get this merged if @mattfarina has anything else to say about this

unguiculus · 2018-02-26T17:48:03Z

/hold

unguiculus · 2018-02-26T17:49:01Z

I'd like you to have a look at our review guidelines, especially regarding standard labels.

unguiculus · 2018-02-26T17:49:10Z

/assign

cdrage · 2018-02-27T19:42:04Z

/assign @prydonius

cdrage · 2018-03-07T16:25:59Z

Ping @mattfarina Any updates?

unguiculus · 2018-03-08T15:27:20Z

@cdrage See my comment above. We are actually waiting for an update from your side. Thanks. Feel free to ask if you have questions.

cdrage · 2018-03-08T15:46:03Z

Hi @unguiculus I did read your comment: I'd like you to have a look at our review guidelines, especially regarding standard labels.

If you don't mind helping within the code-review, that'd be great. I believe I'm simply missing the labels within Deployment? https://github.com/kubernetes/charts/pull/3408/files#diff-c701936730a96a12c3f3ca5a38e30228R6

cdrage · 2018-03-19T16:08:53Z

ping @unguiculus @prydonius (I've already gone ahead and updated a few of the charts / templates with the afformentioned changes)

cdrage · 2018-03-20T14:21:21Z

/retest

cdrage · 2018-03-20T15:37:05Z

/retest

cdrage · 2018-03-20T15:37:21Z

Going to set this as a [WIP]. Seems like I broke something but I'm a bit busy this week to test it out.

filoozom · 2018-03-20T15:53:05Z

@cdrage Guess it's because of this: go-gitea/gitea#3246

This is a follow up to PR's #2083 as well as #346 Gitea is a fork of Gogs and thus, (most) of this PR has been adapted from: https://github.com/kubernetes/charts/tree/master/incubator/gogs At the moment there is no Gitea chart available in the incubator. Unfortunately there is little activity on Gogs (see: https://github.com/gogits/gogs) since it's ran by only one maintainer (rather than a community).

k8s-ci-robot · 2018-03-26T19:51:50Z

@cdrage: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-charts-e2e	`b6f066f`	link	`/test pull-charts-e2e`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

cdrage · 2018-03-27T17:50:51Z

@filoozom Yeah... this sucks. We're blocked because of: go-gitea/gitea#3246 Why they use app.ini as a status, I do not know.

midnightconman · 2018-06-18T21:43:16Z

I have a working chart in PR #6124, take a look and see if there are things we can merge here. I used an init container and an emptyDir shared volume to get around the INTERNAL_TOKEN issue.

stale · 2018-08-08T01:01:09Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Activing will cause the issue to no longer be considered stale. Thank you for your contributions.

mattfarina · 2018-08-09T18:16:19Z

Is this still considered work in progress as the title suggests?

cdrage · 2018-08-13T14:41:52Z

@mattfarina blocked more like it, since we're waiting for an issue to be resolved from Gitea (go-gitea/gitea#3246)

mattfarina · 2018-08-16T13:40:28Z

@cdrage Thanks for the update

stale · 2018-09-15T14:01:04Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

stale · 2018-09-29T16:03:47Z

This issue is being automatically closed due to inactivity.

denis111 · 2019-05-03T11:02:18Z

As i understand the blocking issue is solved here go-gitea/gitea#5812 ? so maybe it's time to add it to incubator?

paolo-rendano · 2019-05-31T13:55:38Z

Any chance to get gitea charts on incubator??

wyattjsmith1 · 2019-07-21T18:03:53Z

Yah, I would be very interested in a gitea helm chart. It looks like the blocking issue has been resolved. It would be great to get this into incubator!

cdrage · 2019-07-24T19:16:48Z

I can work on getting this back into the incubator, although with changes to Helm and Gitea I hope it'd work.

k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 22, 2018

mattfarina reviewed Jan 23, 2018

View reviewed changes

filoozom reviewed Feb 20, 2018

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 26, 2018

k8s-ci-robot assigned unguiculus Feb 26, 2018

k8s-ci-robot assigned prydonius Feb 27, 2018

cdrage mentioned this pull request Mar 19, 2018

Gogs does not meet guidelines #4280

Closed

cdrage changed the title ~~Adds Gitea to the incubator~~ [WIP] Adds Gitea to the incubator Mar 20, 2018

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2018

cdrage mentioned this pull request Mar 27, 2018

Feature Request: Move INTERNAL_TOKEN value out of app.ini go-gitea/gitea#3246

Closed

7 tasks

unguiculus mentioned this pull request Jun 17, 2018

[gitea] Initial Commit #6124

Closed

stale bot added the wontfix label Aug 8, 2018

mattfarina added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2018

stale bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 13, 2018

mattfarina added the Contribution Allowed If the contributor has signed the DCO or the CNCF CLA (prior to the move to a DCO). label Aug 27, 2018

stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 15, 2018

stale bot closed this Sep 29, 2018

		@@ -0,0 +1,64 @@
		apiVersion: extensions/v1beta1
		kind: Deployment

[WIP] Adds Gitea to the incubator #3408

[WIP] Adds Gitea to the incubator #3408

Conversation

cdrage commented Jan 22, 2018

cdrage commented Jan 22, 2018

mattfarina commented Jan 23, 2018

mattfarina left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattfarina commented Feb 7, 2018

cdrage commented Feb 7, 2018

filoozom commented Feb 14, 2018 • edited Loading

cdrage commented Feb 20, 2018

filoozom commented Feb 20, 2018 • edited Loading

filoozom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Feb 20, 2018

filoozom commented Feb 26, 2018 • edited Loading

cdrage commented Feb 26, 2018

unguiculus commented Feb 26, 2018

unguiculus commented Feb 26, 2018

unguiculus commented Feb 26, 2018

cdrage commented Feb 27, 2018

cdrage commented Mar 7, 2018

unguiculus commented Mar 8, 2018

cdrage commented Mar 8, 2018

cdrage commented Mar 19, 2018 • edited Loading

cdrage commented Mar 20, 2018

cdrage commented Mar 20, 2018

cdrage commented Mar 20, 2018

filoozom commented Mar 20, 2018

k8s-ci-robot commented Mar 26, 2018

cdrage commented Mar 27, 2018

midnightconman commented Jun 18, 2018

stale bot commented Aug 8, 2018

mattfarina commented Aug 9, 2018

cdrage commented Aug 13, 2018 • edited Loading

mattfarina commented Aug 16, 2018

stale bot commented Sep 15, 2018

stale bot commented Sep 29, 2018

denis111 commented May 3, 2019

paolo-rendano commented May 31, 2019

wyattjsmith1 commented Jul 21, 2019

cdrage commented Jul 24, 2019

filoozom commented Feb 14, 2018 •

edited

Loading

filoozom commented Feb 20, 2018 •

edited

Loading

filoozom commented Feb 26, 2018 •

edited

Loading

cdrage commented Mar 19, 2018 •

edited

Loading

cdrage commented Aug 13, 2018 •

edited

Loading