This repository has been archived by the owner on Feb 22, 2022. It is now read-only.
[stable/influxdb] Allow alternate schedulers #6235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
needs-ok-to-test
|
cc chart maintainer, @jackzampolin |
|
/assign @sameersbn |
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: knorby, unguiculus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
or1can
pushed a commit
to or1can/charts
that referenced
this pull request
Jul 10, 2018
* Adding option to set scheduler * Bumping version * Bump minor version for new feature
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows for an alternative scheduler to be used on Influxdb, e.g. stork. This is of relevance to influxdb, given persistent volumes (stork is primarily focused on data scheduling).
Special notes for your reviewer:
There is no reason to hard set a default value for the scheduler, but it should default to 'default-scheduler' if that helps for testing. The scheduler itself doesn't affect much beyond node selection, so there isn't really an impact to see from different schedulers beyond that. No need to setup Stork!