[stable/anchore-engine] Update to v0.2.3 of anchore-engine #6668
Conversation
…w feature support * Adds prometheus metric support * Adds archive driver support for using s3, swift, or db based storage for analysis output * Removes the "localanchore" analyzer mode, as it has been removed in anchore-engine * Switch to using the pod name as the "hostid" for anchore services, internal ids for service components
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
|
@davidkarlsen: changing LGTM is restricted to assignees, and only kubernetes/charts repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| log_level: {{ .Values.workerConfig.logLevel }} | ||
| #host_id: 'e3651c16-5161-412f-a188-2bfae2d2dcf0' | ||
| host_id: ${ANCHORE_POD_NAME} |
There was a problem hiding this comment.
What is this used for? What happens if/when the pod dies and comes up with a new name?
There was a problem hiding this comment.
anchore handles that by registering a new service with the new host id. Eventually we'll move to using StatefulSets to help stabilize the id, but anchore-engine handles this (just like a scale-out operation).
stable/anchore-engine/Chart.yaml
Outdated
| @@ -1,6 +1,6 @@ | |||
| name: anchore-engine | |||
| version: 0.1.7 | |||
| appVersion: 0.1.10 | |||
| version: 0.1.8 | |||
There was a problem hiding this comment.
Likely a 0.2.0 version makes sense here.
There was a problem hiding this comment.
I was going to wait to bump when we move to StatefulSets and remap how processes are run in the containers (now it's multiple procs per container, will move to one per container), but to track the app version I'm fine with a minor version bump if that is best practice.
There was a problem hiding this comment.
This is a significant enough change that its worth at least a minor. For the stateful set change you'll need to do a major version bump since it will almost certainly be backwards incompatible.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: davidkarlsen, viglesiasce, zhill The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
thx @viglesiasce |
* [stable/anchore-engine] Update to v0.2.3 of anchore-engine and add new feature support * Adds prometheus metric support * Adds archive driver support for using s3, swift, or db based storage for analysis output * Removes the "localanchore" analyzer mode, as it has been removed in anchore-engine * Switch to using the pod name as the "hostid" for anchore services, internal ids for service components * Fix some lint issues * Change version from v0.1.x to v0.2.0 for chart corresponding to v0.2.x in app version
* [stable/anchore-engine] Update to v0.2.3 of anchore-engine and add new feature support * Adds prometheus metric support * Adds archive driver support for using s3, swift, or db based storage for analysis output * Removes the "localanchore" analyzer mode, as it has been removed in anchore-engine * Switch to using the pod name as the "hostid" for anchore services, internal ids for service components * Fix some lint issues * Change version from v0.1.x to v0.2.0 for chart corresponding to v0.2.x in app version Signed-off-by: aba182 <ajwilhel@gmail.com>
* [stable/anchore-engine] Update to v0.2.3 of anchore-engine and add new feature support * Adds prometheus metric support * Adds archive driver support for using s3, swift, or db based storage for analysis output * Removes the "localanchore" analyzer mode, as it has been removed in anchore-engine * Switch to using the pod name as the "hostid" for anchore services, internal ids for service components * Fix some lint issues * Change version from v0.1.x to v0.2.0 for chart corresponding to v0.2.x in app version Signed-off-by: Giancarlo Rubio <gianrubio@gmail.com>
* [stable/anchore-engine] Update to v0.2.3 of anchore-engine and add new feature support * Adds prometheus metric support * Adds archive driver support for using s3, swift, or db based storage for analysis output * Removes the "localanchore" analyzer mode, as it has been removed in anchore-engine * Switch to using the pod name as the "hostid" for anchore services, internal ids for service components * Fix some lint issues * Change version from v0.1.x to v0.2.0 for chart corresponding to v0.2.x in app version Signed-off-by: Jakob Niggel <info@jakobniggel.de>
* [stable/anchore-engine] Update to v0.2.3 of anchore-engine and add new feature support * Adds prometheus metric support * Adds archive driver support for using s3, swift, or db based storage for analysis output * Removes the "localanchore" analyzer mode, as it has been removed in anchore-engine * Switch to using the pod name as the "hostid" for anchore services, internal ids for service components * Fix some lint issues * Change version from v0.1.x to v0.2.0 for chart corresponding to v0.2.x in app version
Update the chart to support anchore-engine v0.2.3 and some features introduced since v0.2.1.
What this PR does / why we need it:
Updates anchore-engine chart to support anchore-engine v0.2.3. Adds support for archive drivers, prometheus metrics, and fixes some issues that the old chart had with newer versions of anchore-engine.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer: