New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete Deployment / ReplicaSet not working #91
Comments
What version of Kubernetes is the cluster are you running against? Until
the deployment controller begins using the GC, you'll need to scale the
deployment to zero before deleting it. That change should be in 1.6 if it
didn't make 1.5.
…On Fri, Feb 3, 2017 at 12:20 PM, Steve Sloka ***@***.***> wrote:
I'm developing a client which is consuming the k8s using the client-go.
I'm creating Deployments with the client and they work great, but when I
try and delete, the deployments delete but the pods stay running.
I've also added logic to delete the ReplicaSets and they delete, but the
pods still stay running.
I'm currently using tag v2.0.0-alpha.1
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#91>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAngluFwUfuG1aB1Ayfq_2F0s2asNvF4ks5rY4v5gaJpZM4L2w9A>
.
|
Right now I'm on v1.5.1. I can try scaling to zero first. |
Yeah, I think it may have just missed the 1.5 cut.
…On Fri, Feb 3, 2017 at 12:51 PM, Steve Sloka ***@***.***> wrote:
Right now I'm on v1.5.1. I can try scaling to zero first.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#91 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAngltUPy7IuOXZLdDtN33_H_G8g9wJkks5rY5NAgaJpZM4L2w9A>
.
|
Thanks for the help @lavalamp that worked by scaling it down first. I had to do the same for my StatefulSet as well. |
Great! Just to repeat myself, this is an API thing, not a client thing. The
API ought to do what people expect after using kubectl, but it doesn't
(because kubectl manually does two things). This should be significantly
ameliorated once all the controller types use the GC. Currently I think
only RS/RC do so.
…On Fri, Feb 3, 2017 at 7:33 PM, Steve Sloka ***@***.***> wrote:
Closed #91 <#91>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#91 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAngluGtfvewjncR8J69NuHByx2b53KSks5rY_FwgaJpZM4L2w9A>
.
|
k8s-publishing-bot
added a commit
that referenced
this issue
Mar 21, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove YEAR field of all generated files and fix kubernetes boilerplate checker **What this PR does / why we need it**: Remove YEAR field of all generated files and fix kubernetes boilerplate checker xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91) **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes [#gengo/issues/24](kubernetes/gengo#24) **Special notes for your reviewer**: /cc @thockin @lavalamp @sttts **Release note**: ```release-note NONE ``` Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts
pushed a commit
to sttts/client-go
that referenced
this issue
Apr 9, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove YEAR field of all generated files and fix kubernetes boilerplate checker **What this PR does / why we need it**: Remove YEAR field of all generated files and fix kubernetes boilerplate checker xref: [remove YEAR fileds in gengo kubernetes#91](kubernetes/gengo#91) **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes [#gengo/issues/24](kubernetes/gengo#24) **Special notes for your reviewer**: /cc @thockin @lavalamp @sttts **Release note**: ```release-note NONE ``` Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm developing a client which is consuming the k8s using the client-go. I'm creating Deployments with the client and they work great, but when I try and delete, the deployments delete but the pods stay running.
I've also added logic to delete the ReplicaSets and they delete, but the pods still stay running.
I'm currently using tag v2.0.0-alpha.1
The text was updated successfully, but these errors were encountered: