Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Deployment / ReplicaSet not working #91

Closed
stevesloka opened this issue Feb 3, 2017 · 5 comments
Closed

Delete Deployment / ReplicaSet not working #91

stevesloka opened this issue Feb 3, 2017 · 5 comments

Comments

@stevesloka
Copy link

I'm developing a client which is consuming the k8s using the client-go. I'm creating Deployments with the client and they work great, but when I try and delete, the deployments delete but the pods stay running.

I've also added logic to delete the ReplicaSets and they delete, but the pods still stay running.

I'm currently using tag v2.0.0-alpha.1

@lavalamp
Copy link
Member

lavalamp commented Feb 3, 2017 via email

@stevesloka
Copy link
Author

Right now I'm on v1.5.1. I can try scaling to zero first.

@lavalamp
Copy link
Member

lavalamp commented Feb 3, 2017 via email

@stevesloka
Copy link
Author

Thanks for the help @lavalamp that worked by scaling it down first. I had to do the same for my StatefulSet as well.

@lavalamp
Copy link
Member

lavalamp commented Feb 6, 2017 via email

k8s-publishing-bot added a commit that referenced this issue Mar 21, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/client-go that referenced this issue Apr 9, 2018
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo kubernetes#91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants