Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deepcopy/sets generate of new year and remove YEAR field #91

Merged
merged 3 commits into from Jan 19, 2018
Merged

fix deepcopy/sets generate of new year and remove YEAR field #91

merged 3 commits into from Jan 19, 2018

Conversation

fisherxu
Copy link
Contributor

@fisherxu fisherxu commented Jan 2, 2018 •
edited

fix the new year of 2018 and remove YEAR field
fix issue:#24

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2018
@fisherxu
Copy link
Contributor Author

fisherxu commented Jan 2, 2018

/assign @thockin @wojtek-t @sttts

@fisherxu
Copy link
Contributor Author

fisherxu commented Jan 2, 2018

/cc @sttts

@sttts
Copy link
Contributor

sttts commented Jan 2, 2018

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2018
@deads2k
Copy link
Contributor

deads2k commented Jan 2, 2018

@sttts pick to openshift fork please.

@sttts
Copy link
Contributor

sttts commented Jan 2, 2018

@deads2k we don't have boilerplate headers with YEARs.

@lavalamp lavalamp removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2018
@lavalamp
Copy link
Member

lavalamp commented Jan 2, 2018

This is a bit wrong-- new files should get the new year, but old files should not change.

Additionally, this appears to just modify the generated output instead of fixing the generator?

@sttts
Copy link
Contributor

sttts commented Jan 2, 2018

This is a bit wrong-- new files should get the new year, but old files should not change.

I don't disagree. But is this a regression? I would prefer to get CI fixed first and do a proper fix in a follow-up. A quick look at the generator suggests that the code is pretty dumb just replacing the YEAR. We would have to write to a temporary file and do a fuzzy comparison.

@sttts
Copy link
Contributor

sttts commented Jan 2, 2018

Doesn't look like a regression. We had the same in 2017: #24

@thockin
Copy link
Member

thockin commented Jan 2, 2018

Agree - this sucks, but it's not on anyone's plate right now, and is not a trivial fix.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2018
@thockin
Copy link
Member

thockin commented Jan 2, 2018

Need to also regenerate sets ?

@sttts
Copy link
Contributor

sttts commented Jan 2, 2018

Travis thinks so. @fisherxu can you update sets as well?

@fisherxu
Copy link
Contributor Author

fisherxu commented Jan 3, 2018

@sttts @thockin Have updated sets in another PR, xref: 92 , and also add .gitignore for deepcopy-gen, PTAL. :)

@sttts
Copy link
Contributor

sttts commented Jan 3, 2018 •
edited

@fisherxu can you merge both PRs so that CI is happy? One alone won't be green ;)

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2018
@fisherxu
Copy link
Contributor Author

fisherxu commented Jan 3, 2018

@sttts sure, have done :)

@sttts
Copy link
Contributor

sttts commented Jan 3, 2018

Lgtm. Maybe squash the two generation commits.

@fisherxu fisherxu changed the title fix deepcopy generate of year fix deepcopy and sets generate of new year 2018 Jan 3, 2018
@fisherxu
Copy link
Contributor Author

fisherxu commented Jan 3, 2018

@sttts Have squashed :)
Also add .gitignore for deepcopy and Makefile for set-gen. @thockin PTAL.
and will add test for default-gen later in another PR.

@sttts
Copy link
Contributor

sttts commented Feb 1, 2018

@fisherxu I fear this conflicts with kubernetes/kubernetes#57656

@fisherxu
Copy link
Contributor Author

fisherxu commented Feb 1, 2018

@sttts yes, I have seen at kubernetes/kubernetes#59172 , we can wait kubernetes/kubernetes#57656 merge first.

@sttts
Copy link
Contributor

sttts commented Feb 1, 2018

@fisherxu working with @nikhita on it right now to get it in asap.

@fisherxu
Copy link
Contributor Author

fisherxu commented Feb 1, 2018

@sttts No problem, I can help take a look for the failed CItests :)

@sttts
Copy link
Contributor

sttts commented Feb 1, 2018

@fisherxu fixing the path calculation right now. We don't want to hard-coded kube packages there.

@fisherxu
Copy link
Contributor Author

fisherxu commented Feb 1, 2018

@sttts Ok, talking with @nikhita now :)

k8s-github-robot pushed a commit to kubernetes/kubernetes that referenced this pull request Mar 21, 2018
Merge pull request #59172 from fisherxu/removeyear
e40ffd7 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts 

**Release note**:

```release-note
NONE
```
k8s-publishing-bot added a commit to kubernetes/code-generator that referenced this pull request Mar 21, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
a9a9141 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
k8s-publishing-bot added a commit to kubernetes/apimachinery that referenced this pull request Mar 21, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
3aa1cc9 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
k8s-publishing-bot added a commit to kubernetes/api that referenced this pull request Mar 21, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
2448346 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
k8s-publishing-bot added a commit to kubernetes/client-go that referenced this pull request Mar 21, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
01eabee 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
k8s-publishing-bot added a commit to kubernetes/apiserver that referenced this pull request Mar 21, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
08ff958 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
k8s-publishing-bot added a commit to kubernetes/kube-aggregator that referenced this pull request Mar 21, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
5e78cb7 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
k8s-publishing-bot added a commit to kubernetes/sample-apiserver that referenced this pull request Mar 21, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
aa0ac73 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
k8s-publishing-bot added a commit to kubernetes/sample-controller that referenced this pull request Mar 21, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
637ec76 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
k8s-publishing-bot added a commit to kubernetes/apiextensions-apiserver that referenced this pull request Mar 21, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
6ac5bd6 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
k8s-publishing-bot added a commit to kubernetes/metrics that referenced this pull request Mar 21, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
bb6a211 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/code-generator that referenced this pull request Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
cb66c0c 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo kubernetes#91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts 

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/apimachinery that referenced this pull request Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
5b5f01a 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo kubernetes#91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/api that referenced this pull request Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
53f6322 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/client-go that referenced this pull request Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
223000d 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo kubernetes#91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/apiserver that referenced this pull request Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
abaad58 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo kubernetes#91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/kube-aggregator that referenced this pull request Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
ae101d4 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/sample-apiserver that referenced this pull request Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
ded3fd1 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/sample-controller that referenced this pull request Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
10f2cc0 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo kubernetes#91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/apiextensions-apiserver that referenced this pull request Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
ec665fb 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
sttts pushed a commit to sttts/metrics that referenced this pull request Apr 9, 2018
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
b37df9c 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
openshift-publish-robot pushed a commit to openshift/kubernetes-sample-controller that referenced this pull request Jan 14, 2019
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
dd62b31 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo kubernetes#91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts 

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
openshift-publish-robot pushed a commit to openshift/kubernetes-sample-apiserver that referenced this pull request Jan 14, 2019
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
3c97391 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
akhilerm pushed a commit to akhilerm/apimachinery that referenced this pull request Sep 20, 2022
@k8s-publishing-bot
Merge pull request #59172 from fisherxu/removeyear
be3be16 
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Remove YEAR field of all generated files and fix kubernetes boilerplate checker

**What this PR does / why we need it**:
Remove YEAR field of all generated files and fix kubernetes boilerplate checker
xref: [remove YEAR fileds in gengo #91](kubernetes/gengo#91)

**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
Fixes [#gengo/issues/24](kubernetes/gengo#24)

**Special notes for your reviewer**:
/cc @thockin @lavalamp @sttts 

**Release note**:

```release-note
NONE
```

Kubernetes-commit: e40ffd71972b820aeed283946e880aa2479f8524
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts Awaiting requested review from sttts

Assignees

@sttts sttts

@thockin thockin

@wojtek-t wojtek-t

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@fisherxu @k8s-reviewable @sttts @deads2k @lavalamp @thockin @wojtek-t @k8s-ci-robot